Board Announcements

3.3.0-b2 Color selection is missing - Board Announcements

3.3.0-b2 Color selection is missing

by Tastenplayer » Thu Nov 28, 2019 8:59 pm

The extension seems to work correctly. However, I have only noticed now that the color selection is not displayed on the left.
This is only for information
More of my styles you can find in my phpBB Style Board & More My styles -3.2.10-RC2
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.
User avatar
Tastenplayer
Registered User
Posts: 732
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: 3.3.0-b2 Color selection is missing

by MattF » Fri Nov 29, 2019 2:01 am

Working fine here.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5187
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: 3.3.0-b2 Color selection is missing

by Tastenplayer » Fri Nov 29, 2019 10:55 am

announce-3.3.jpg
As you can see - I have no color selection in my forum on the left side.

Database server: MySQL(i) 10.3.18-MariaDB-1:10.3.18+maria~stretch
PHP version: 7.2.20
Board version: 3.3.0-b2 [ Re-Check version ]
More of my styles you can find in my phpBB Style Board & More My styles -3.2.10-RC2
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.
User avatar
Tastenplayer
Registered User
Posts: 732
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: 3.3.0-b2 Color selection is missing

by MattF » Fri Nov 29, 2019 4:11 pm

Because you have no color code entered into the field.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5187
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: 3.3.0-b2 Color selection is missing

by Tastenplayer » Sat Nov 30, 2019 12:30 pm

VSE wrote:Because you have no color code entered into the field.
:? I mean this color palette on the left:
colors.jpg
colors.jpg (18.18 KiB) Viewed 134 times
More of my styles you can find in my phpBB Style Board & More My styles -3.2.10-RC2
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.
User avatar
Tastenplayer
Registered User
Posts: 732
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: 3.3.0-b2 Color selection is missing

by 3Di » Sat Nov 30, 2019 1:05 pm

Try and change this line

Code: Select all

<dt style="width: 90px;" id="color_palette_placeholder" data-orientation="v" data-height="12" data-width="15" data-bbcode="true"></dt>
to

Code: Select all

<dt style="width: 90px;" id="color_palette_placeholder" data-color-palette="v" data-height="12" data-width="15" data-bbcode="true"></dt>
In ./ext/phpbb/boardannouncements/adm/style/board_announcements.html

Not tested.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
3Di
Former Team Member
Posts: 15886
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: 3.3.0-b2 Color selection is missing

by MattF » Sat Nov 30, 2019 5:00 pm

Oh for chrissakes!. Well that's a backwards incompatible update.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5187
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: 3.3.0-b2 Color selection is missing

by 3Di » Sat Nov 30, 2019 5:16 pm

Yup. We have just one extension with this issue I can fix it with a Twig if-else, preferably I'd avoid to do it.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
3Di
Former Team Member
Posts: 15886
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: 3.3.0-b2 Color selection is missing

by MattF » Sat Nov 30, 2019 5:22 pm

We're going to have to fix that in phpBB. It's an unintentional backwards breaking change.

Extension code should be left alone. Wait for next beta or release of phpBB 3.3.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5187
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: 3.3.0-b2 Color selection is missing

by Tastenplayer » Sat Nov 30, 2019 6:49 pm

No problem, I just wanted to draw attention to it. Everything else seems to be working correctly.
Misunderstandings due to my bad English can unfortunately sometimes not be avoided. I should have inserted the color scheme image from the beginning, too, sorry for the circumstances!
3Di wrote:Try and change this line

Code: Select all

<dt style="width: 90px;" id="color_palette_placeholder" data-orientation="v" data-height="12" data-width="15" data-bbcode="true"></dt>
to

Code: Select all

<dt style="width: 90px;" id="color_palette_placeholder" data-color-palette="v" data-height="12" data-width="15" data-bbcode="true"></dt>
That seems to be it. Tested in my local Quickinstall TB not online.
boardannouncement_3.3.0-b2.jpg
More of my styles you can find in my phpBB Style Board & More My styles -3.2.10-RC2
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.
User avatar
Tastenplayer
Registered User
Posts: 732
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: 3.3.0-b2 Color selection is missing

by sekellas » Fri Feb 21, 2020 12:45 pm

Is this still something that needs to be updated for 3.3?

If so, any ideas on an eta?

Thanks!
sekellas
Registered User
Posts: 18
Joined: Fri Jan 18, 2019 10:13 pm
Contact:

Re: 3.3.0-b2 Color selection is missing

by MattF » Fri Feb 21, 2020 3:51 pm

No it’s fine
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5187
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact: