phpBB • Free and Open Source Forum Software

Hi, first of all thank you for this neat extension, it's great being able to switch to dark mode instantly instead of having to change themes.

One question though, what is the purpose of the extra 15px padding added in the CSS:
It's especially noticable when browsing the forum on mobile devices with limited screen real estate. I commented it out on my forum with no apparent side effect, but if it did serve some actual purpose then I'd like to know. This padding is not added in the prosilver_se CSS by the way.

I had this note when I submitted the extension :

Chris1278 wrote: The optics in the Acp area in the dark mode would have to be improved.

I would suggest the following change to improve the optics in the Acp area.

Add in the file:

ext/aurelienazerty/darkmode/styles/all/theme/darkmode.css

In the first block that looks like this:

Code: Select all

body.darkmode {
  filter: invert (1) hue-rotate (.5turn);
 }

Just the one he looks like:

Code: Select all

body.darkmode {
  filter: invert (1) hue-rotate (.5turn);
  padding: 15px;
}

This is better displayed in the Acp.

Seems like a bug to me, even if it was a bug that came from a validator's suggestions dark/light mode should only affect color, not layout or spacing.