Digests

Edit Subscribers Stopped Working - Digests

Re: Edit Subscribers Stopped Working

by neo314 » Fri Feb 22, 2019 3:32 am

Do you have a Virtual Machine of Windows 10? That would be a way to test. I tried it in my Mac OSX VM machine and it worked there as well.
neo314
Registered User
Posts: 19
Joined: Thu May 22, 2008 12:09 am
Contact:

Re: Edit Subscribers Stopped Working

by MarkDHamill » Fri Feb 22, 2019 12:51 pm

No sorry, I don't. If that's the issue it may be something like Windows virtual memory that needs to be flushed.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3940
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Edit Subscribers Stopped Working

by Tropheus99 » Thu Oct 03, 2019 8:16 pm

Did you ever find a solution to this? I've been having the same problem for some time.

Thanks in advance.
Tropheus99
Registered User
Posts: 13
Joined: Sat Dec 01, 2018 8:32 pm
Contact:

Re: Edit Subscribers Stopped Working

by MarkDHamill » Thu Oct 03, 2019 8:30 pm

How many users are in your database?

Perhaps the index is missing from the phpbb_users table to search by username.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3940
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Edit Subscribers Stopped Working

by Tropheus99 » Thu Oct 03, 2019 9:35 pm

There are approximately 1,500 users. How do I check the index?

Thanks,

Ken.
Tropheus99
Registered User
Posts: 13
Joined: Sat Dec 01, 2018 8:32 pm
Contact:

Re: Edit Subscribers Stopped Working

by MarkDHamill » Thu Oct 03, 2019 9:47 pm

It's probably not an index issue then because 1500 users shouldn't slow things down. In phpMyAdmin you can look at the structure of the phpbb_users table. There is an index option at the bottom you can open up.
Screen Shot 2019-10-03 at 5.38.59 PM.png
You can see the query here:

https://github.com/MarkDHamill/digests/ ... #L378-L398

On line 397 of ext/phpbbservices/digests/acp/main_module.php, if you enter an echo $sql; statement the query will appear on the screen. You can use phpMyAdmin to run the query, and preface it with EXPLAIN to see how MySQL is executing it. I doubt very much there is anything about the query that should slow things down, even with the pattern matching which should still use the username_clean index.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3940
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Edit Subscribers Stopped Working

by neo314 » Fri Oct 04, 2019 4:56 am

This is the same problem I had. I gave up. I just use Safari to edit subscribers.
neo314
Registered User
Posts: 19
Joined: Thu May 22, 2008 12:09 am
Contact:

Re: Edit Subscribers Stopped Working

by Tropheus99 » Fri Oct 04, 2019 6:23 am

Thanks. I can confirm that it works in Safari for me also. I've tried IE, Edge, Chrome and Firefox all with the same error.
Tropheus99
Registered User
Posts: 13
Joined: Sat Dec 01, 2018 8:32 pm
Contact:

Re: Edit Subscribers Stopped Working

by MarkDHamill » Fri Oct 04, 2019 12:51 pm

It could be that the query returns a ton of information all of which get placed into controls, many of them hidden. Digests has a general setting where you can control the number of rows on the edit subscribers page. Reducing the number might be a workaround.

If you include a username filter in the query, the resulting SQL call looks like:

Code: Select all

SELECT *, CASE 
WHEN user_digest_send_hour_gmt + -4 >= 24 THEN user_digest_send_hour_gmt + -4 - 24 
WHEN user_digest_send_hour_gmt + -4 < 0 THEN user_digest_send_hour_gmt + -4 + 24 
ELSE user_digest_send_hour_gmt + -4 END AS send_hour_board 
FROM (phpbb_users u) WHERE username_clean LIKE '%mark%' AND user_type IN (0, 3) ORDER BY lower(username) ASC 
So all columns in the phpbb_users table are returned by the query. However, for the most part, only the ones with the pattern user_digest_* are needed. I can try tightening up the query but I think the problem lies elsewhere.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3940
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Edit Subscribers Stopped Working

by MarkDHamill » Fri Oct 04, 2019 1:03 pm

Also, try this. Add the novalidate option to the <form> tag on line 99 of /ext/phpbbservices/digests/adm/style/acp_digests.html:

from:

Code: Select all

<form id="acp_digests" method="post" action="{{ U_ACTION }}">
to:

Code: Select all

<form id="acp_digests" method="post" action="{{ U_ACTION }}" novalidate>
Purge the cache and try again. Let me know if it fixes anything.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3940
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Edit Subscribers Stopped Working

by Tropheus99 » Fri Oct 04, 2019 7:12 pm

Thanks Mark. I'll give the above a go and come back to you.

I have a test copy of my forum that I could give you access to if you want to investigate further. It's a local community forum so nothing sensitive.
Tropheus99
Registered User
Posts: 13
Joined: Sat Dec 01, 2018 8:32 pm
Contact:

Re: Edit Subscribers Stopped Working

by Tropheus99 » Fri Oct 04, 2019 7:27 pm

The second suggestion didn't work. I tried "Admin" with the SQL suggested in your first post and that only returned one account which is correct. I can't search for Admin or any other account on the Edit Subscribers form.

Ken.
Tropheus99
Registered User
Posts: 13
Joined: Sat Dec 01, 2018 8:32 pm
Contact:

Re: Edit Subscribers Stopped Working

by MarkDHamill » Fri Oct 04, 2019 8:40 pm

Worth a try. The SQL I showed is an example of what might appear. The exact SQL will be different depending on the search pattern in the username field.

If it works on one browser but not another, that's a good sign it's a browser issue. I have to assume it's related to the hundreds of fields that can be on the screen, most of them hidden.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3940
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Edit Subscribers Stopped Working

by Tropheus99 » Fri Oct 04, 2019 8:46 pm

I'll send you a PM with log in details tomorrow.
Tropheus99
Registered User
Posts: 13
Joined: Sat Dec 01, 2018 8:32 pm
Contact:

Re: Edit Subscribers Stopped Working

by iitee » Sat Oct 05, 2019 8:09 pm

Did you ever get this solved? I'm trying to get digests going, but can't, and while debugging I run into this very same error. The buttons don't work on the first page. They produce the very same error for me. I tried both Firefox and Chrome. I updated the digests from some months back version to the latest. Something fishy with both the go and submit buttons.

I also tried like suggested here, I went to the second page which has less entries. There the buttons work. Did you ever find the root cause? Or workaround?
iitee
Registered User
Posts: 11
Joined: Sun Apr 27, 2008 12:01 pm
Contact: