phpBB • Free and Open Source Forum Software

Hallo,

in the ucp - i marked in "post filters" - "Show new posts only: Yes"

Yesterday a new topic was created. Today at 1:00 pm the textuser was logged in an make all topics read.

Now (5:00 pm) the testuser got a mail from the digest system, that a new topic exist (that of yesterday)

With the option "Show new posts only: Yes" - i think, that new infos only come, if a new topic was createt after the last login of the testuser.....hmmm....

And im ACP - Default Value of "Show new posts only" is not working in the UCP.

lg Stefan

Show new posts only will filter out any posts posted prior to the date and time you last visited this board. So basically this depends on the value of user_lastvisit in the phpbb_users table at the time the digest was created. You can see the implementation here.

This value will change if you subsequently visit the forum.

How is this value set? It is usually set when the user's session expires, i.e. the value of phpbb_sessions.session_time for the user. I believe if you explicitly logoff, that time is also captured in the column. The sessions table is periodically parsed and old sessions removed as the board gets traffic.

Yes i know!
New Topic: Yesterday
last login "testuser": today 1:00
e-mail with the new top comes per e-mail at 5:00 pm today. - and that's behaviour ist not right, becaus the "testuser" was since new topic was createt in the board.
Digests Settings in the UCP of the "testuser" was set.

And im ACP - Default Value of "Show new posts only" is not working in the UCP.

Lg Stefan

It's hard to say what the issue is but if for some reason user_lastvisit is 0 for the recipient of the digest this could cause the issue. The digest extension does not zero this out but if "Reset my last visit date when I am sent a digest" is set to yes under additional criteria, it will set the value to the date and time the digest was created.

You can use the from_unixtime() function in MySQL to translate the user_lastvisit value for the recipient to something readable. But it's likely that the value will be different than when the digest was created if the user has been to the forum since the digest was received.

Okay, I think I see the issue. Line 1757 of /cron/task/digests.php is:
and should be:
$this->date_limit represents how far back to go based on the digest type. For example, a daily digests goes back 24 hours so the value represents a Unix timestamp for this time. If the user's last visit time is after this time period, then this logic fails to enforce the user_lastvisit constraint.

I need to get a new version out with a few minor tweaks and bug fixes. Hopefully I can do this within a few days. Thanks for reporting the bug.

Good morning - great support. I i think the 24 hours problem is the issue - i can say it in 1 hour.

Let me write some wishes für a update - maybe you can realis it:
I useful option i think would be, if a user can set to get immediately a message, if in a forum a new topic was created. if many user may be with minutes delay or somethin to not overload the mail system of the board.

I am looking forward to your update and like to test it.

Something about Cron Job
I like to use a cron job of my provider - but the description of the cron job setup you linked, is for me as normal user to complicated

I think i need only the cron job synthax that i have to put in at my provider - I'right?
If not - maybe someon can make a easy tutorial how to realise the cron job mechanism.

Lg Stefan

I think there is a furhter bug:
This option in UCP: Reset my last visit date when I am sent a digest: YES - does not set new topics to status "read" after sending a mail over digests
Topic only as read, if my "testuser" klicks on the topic in the forum.

lg Stefan

phpBB already has a feature for getting new topic notifications. Simply subscribe to the forum! But if you want email notifications, you usually need to go into the UCP and change the notification so it explicitly sends you an email.

Setting up a system cron can be a bit complicated because there are so many variations with hosting. Shared hosting doesn't usually let you have multiple commands in one cron job, an approach phpBB assumes. Which is why instead you often need to use curl or wget using the approach in the Wiki instead.

The reset user last visit feature merely writes the user_lastvisit timestamp to the current timestamp. It does not perform the equivalent of marking all forums read. I'll look into how much work that would be.

MarkDHamill wrote: The reset user last visit feature merely writes the user_lastvisit timestamp to the current timestamp. It does not perform the equivalent of marking all forums read. I'll look into how much work that would be.

Hmmm....before you make you much work...let me test your update a few days.

I think it's enough, to inform the user about the new topics. To read or mark as read he can go in the forum..

LG Stefan

Hallo - i think it runs no very well. But in this description may be is an error:
UCP / Additional criteria:
"Reset my last visit date when I am sent a digest:
If enabled, posts on the forum should appear as read if they were posted before the date and time your digest was created. Selecting this option effectively tells the forum that reading your digest substitutes for reading posts on the forum."

Your digest extension does not set forum topics as read - and i think that's well done. This option (i think) does set the last visit time of the user to the deliver time of the e-mail and so the next e-mail does only send newer postings. Am i right?

And i have to rvise my error reporting:
"And im ACP - Default Value of "Show new posts only" is not working in the UCP."
It runs ok - if the admin edit someting, in the UCP the user has to switch of digests, and then reset it again.

Lg Stefan

I've looked at adding the mark all forums read logic and it's not complicated, so I'll add it to the next release.