Digests

Digests 3.2.12 released - Digests

Digests 3.2.12 released

by MarkDHamill » Sat Apr 13, 2019 9:58 pm

This release is available on GitHub or can be downloaded from my digests extension page. I'll wait a week or so before submitting it for review, but I don't expect any problems.

You can see a list of changes since 3.2.11 here.

For language translators, there are some minor language changes to language/en/acp/common.php, language/en/acp/info_acp_common.php and language/en/common.php.

Summary of changes, listed in order of relevant importance:
  • Fixed the bug describe here that affected installations using phpBB crons and little site traffic.
  • If you selected the setting in the User Control Panel, Additional settings to reset your last visit date, it will now actually mark all the forums read, as well as any notifications effective at the time of digest creation. Previously it only (incorrectly) updated the user_lastvisit date for the subscriber.
  • Fixed this bug affecting the "Skip posts if new posts only logic applies" feature (User Control Panel, Post settings)
  • Moved the user control panel theme and templates for the extension into /styles/all from /styles/prosilver, addressing this bug which affected a custom style that did not inherit from prosilver
  • Fixed a minor issue with the posting <div> block and HTML digests where the right padding extended outside the window of its container
  • Updated links to language translations in README
  • Made some minor changes requested by the extension review team, none of them affecting functionality
Thanks to those reporting bugs.

If updating the extension, do it the right way: disable it, remove the files, upload new ones, then reenable it.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by stefan-franz » Sun Apr 14, 2019 6:55 pm

Cool - Thank you.

First i recognised: In ACP - Standard user configuration - Option "Show only newly published posts - Yes" - not take over as default value in the UCP (in UCP default is "No")
Same with "Remove own posts" and "Layout of the summary"

Lg Stefan
stefan-franz
Registered User
Posts: 76
Joined: Mon Mar 11, 2019 7:29 pm
Contact:

Re: Digests 3.2.12 released

by MarkDHamill » Sun Apr 14, 2019 7:18 pm

I think you mean ACP > User default settings > Show new posts only? This is the default you set for new people subscribing to digests, which they can override. They can override any setting, so this won't be consistent with their settings in the user control panel.

The same is true for any fields on this screen.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by stefan-franz » Mon Apr 15, 2019 4:12 am

Yes i mean this. Ok i understand. That's the default values for new user. I thought if in UCP switch digest off and then on, it would set.

LG Stefan
stefan-franz
Registered User
Posts: 76
Joined: Mon Mar 11, 2019 7:29 pm
Contact:

Re: Digests 3.2.12 released

by stefan-franz » Mon Apr 15, 2019 5:38 am

Topics were not marked als read.
I got a mail summary for my "testuser" - but the new topics not marked as read.
Lg Stefan
stefan-franz
Registered User
Posts: 76
Joined: Mon Mar 11, 2019 7:29 pm
Contact:

Re: Digests 3.2.12 released

by MarkDHamill » Mon Apr 15, 2019 12:25 pm

Obviously it worked for me in my testing. phpBB's markread() function is used. Applicable code is here.

I'll retest it outside of manual mode. I commented out lines 1110, 1111 and 1154 for my testing and made sure in manual mode it was not set to store digests as files. After running manual mode, I went to the index and observed the topic that was unread was read, and the notifications were gone.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by MarkDHamill » Mon Apr 15, 2019 2:54 pm

Okay, I don't quite understand this, but change line 1110 in /cron/task/digests.php from:

Code: Select all

						if (!$this->run_mode == constants::DIGESTS_RUN_MANUAL)
to:

Code: Select all

						if (!($this->run_mode == constants::DIGESTS_RUN_MANUAL))
This fixed the issue for me.

Also I recommend changing line 1149 from:

Code: Select all

								markread('all');    // Perform mark all forums read
to:

Code: Select all

								markread('all', false, false, $now);    // Perform mark all forums read
What this latter change does is mark forums read only through the time period of the hour being processed. For example, if three hours of digests are going out because a phpBB cron is being used, if now is 12:00, the variable $now represents 10:00 as a timestamp first time through the loop. This should force only those topics created at or before 10:00 to be marked read. The second time through the loop, it would mark through 11:00 as read, and the last time 12:00 as read. This way if there is some sort of fatal bug as it goes through the loop, only the topics in the digest received will be marked as read.

The markread() function only marks certain notification types as read:

Code: Select all

				'notification.type.topic',
				'notification.type.quote',
				'notification.type.bookmark',
				'notification.type.post',
				'notification.type.approve_topic',
				'notification.type.approve_post',
So I will need to clarify the text for reset last visit in the UCP.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by stefan-franz » Mon Apr 15, 2019 3:30 pm

Quick - Support - Thanks.

I suggest, you post an update of your extension when you ready fixed it and i download your 3.2.13 and install it. So we exclude that i make errors.
I would like test the update.

By the way: I don't use a cron job (since i found a easy step by step tutorial). But i think, your solution works without a cron job. Only with board actions.

Lg STefan
stefan-franz
Registered User
Posts: 76
Joined: Mon Mar 11, 2019 7:29 pm
Contact:

Re: Digests 3.2.12 released

by MarkDHamill » Mon Apr 15, 2019 3:36 pm

I will but I am trying something new: getting up to date non-English language translations into the release. So I'll wait for the translators to do their thing if possible.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by stefan-franz » Tue Apr 16, 2019 8:36 am

Hi Mark, the option "topics mark as read" is running. Thank you to repair this successfully.

One question: If this option "topics mark as read" wer set as "no" - let me write an example:

I visit the forum last at 2019-04-16 -8:00 am
News should deliver over your digests system every day at 12 am (i set the option "mark as read" to "no")

Now it's 2019-04-16 - 10:00am and someone writes a topic, i name it "TOPIC Nr 1"
At 2019-04-16 - 12:00am, i get an e-mail with the new "TOPIC Nr 1" - but, i dont log in, in the board.
At next day 2019-04-17 - 7:00am, "TOPIC NR 2" is new
What do i get now from your digests system via mail at 2019-04-17 - 12:00am?: Info about "TOPIC NR 2" or "TOPIC Nr 1" and "TOPIC NR 2"?

In a few words: Do i get all new topics since last visit the board or since last newsletter?

Lg Stefan
stefan-franz
Registered User
Posts: 76
Joined: Mon Mar 11, 2019 7:29 pm
Contact:

Re: Digests 3.2.12 released

by MarkDHamill » Tue Apr 16, 2019 12:15 pm

This feature does not exist. There is a feature to show first posts of new topics only. But if you select all posts, you will get new topics plus replies to existing topics.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by stefan-franz » Tue Apr 16, 2019 2:16 pm

I meant, whether new contributions are accumulated until a user log in again, or whether only since the last newsletter new contributions are listed.
stefan-franz
Registered User
Posts: 76
Joined: Mon Mar 11, 2019 7:29 pm
Contact:

Re: Digests 3.2.12 released

by MarkDHamill » Tue Apr 16, 2019 2:28 pm

Digests will show all relevant posts within the time period. So a daily digest will show only posts for the last 24 hours based on when the digest was created, but not for anything beyond that window. The exception is private messages, if you have that feature enabled. They will show up until you mark them as read. Of course, there are lots of filters that may remove posts, but you control these.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.
User avatar
MarkDHamill
Registered User
Posts: 3929
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.2.12 released

by kamaleon » Wed Apr 17, 2019 4:56 am

Mark, I received an email saying that I need to update the translations files, but I don't know how to add the changes to the files...
This is a test signature. I hope you love it :D
User avatar
kamaleon
Registered User
Posts: 510
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona
Contact:

Re: Digests 3.2.12 released

by Praggle » Wed Apr 17, 2019 7:40 am

I would recommend you to edit the language files directly inside your github repository. You log into your github account, click on the edit pen and make your changes to the master-branch. For users who need an older version of the digests extension and its associated translation files, it would be helpful to freeze every version seperately into a new branch. And I prefer also to create a different release from every version (https://github.com/Praggle/digests/releases) but important is, to change the files inside your master branch.

I prefer myself to use a tool called "GitEye" to make these changes offline and in a more convenient way. But it takes a while to get used to this tool.

Praggle
Praggle
Registered User
Posts: 64
Joined: Thu Feb 26, 2015 6:07 pm
Contact: