Digests

Error found - Digests

Error found

by jan_2017 » Mon Jun 03, 2019 8:56 pm

I can not change in email the word "Autor" in german language file.

How can i change it?

Bye Jan
User avatar
jan_2017
Registered User
Posts: 161
Joined: Sun May 07, 2017 3:39 pm

Re: Error found

by MarkDHamill » Mon Jun 03, 2019 9:44 pm

If there is an issue with the German language translation, you should report it to its author, Praggle, who is monitoring his discussion. The language files are in the /language/de folder of the extension. His GitHub for this is at: https://github.com/Praggle/digests/releases
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: Error found

by jan_2017 » Mon Jun 03, 2019 10:56 pm

Yes i know.

But look to this file:

Open mail_digests_html and go to line 42

Search <th>{{ lang('AUTHOR') }}</th> ... is this wrong?

In Line 11 i see this <th>{{ lang('DIGESTS_AUTHOR') }}</th>

Is Line 42 incorrect?

Bye Jan
User avatar
jan_2017
Registered User
Posts: 161
Joined: Sun May 07, 2017 3:39 pm

Re: Error found

by MarkDHamill » Mon Jun 03, 2019 11:42 pm

In the German language pack, casual honorifics, I see:

Code: Select all

	'AUTHOR'						=> 'Autor',
So it is translating it correctly, presumably as Google Translate gives the same translation:

https://translate.google.com/#view=home ... ext=Author

This is not an issue with the German translation for digests. These language strings are pulled from the official language translations for phpBB. Presumably whoever is getting this digest has their board configuration set to use German as their board language.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: Error found

by jan_2017 » Mon Jun 03, 2019 11:56 pm

I found the mistake.

The change was not transferred in the testmailer function. :roll:

After using the Mailer Reset function and the change in the file mail_digests_html line 42 from <th>{{ lang('AUTHOR') }}</th> to <th>{{ lang('DIGESTS_AUTHOR') }}</th>, the translation I saved appears.

After sending the e-mail at the specified time, the correct translation that was saved in the language file /new/ext/phpbbservices/digests/language/de/common.php line 25 in advance is now also displayed.

Thanks for help

:geek:
User avatar
jan_2017
Registered User
Posts: 161
Joined: Sun May 07, 2017 3:39 pm

Re: Error found

by MarkDHamill » Tue Jun 04, 2019 12:12 am

In English, /language/en/common.php has:

Code: Select all

	'AUTHOR'						=> 'Author',
and in the English translation for digests in /ext/phpbbservices/digests/language/en/common.php there is also:

Code: Select all

	'DIGESTS_AUTHOR'					=> 'Author',
So my addition to /ext/phpbbservices/digests/language/en/common.php is actually redundant. I should remove this language string in future versions and change templates like the one you noticed to use the common language variable.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA