Digests

Digests 3.3.1 released, fixes issue with intermittent digest - Digests

Digests 3.3.1 released, fixes issue with intermittent digest

by MarkDHamill » Sun Apr 05, 2020 1:31 am

Thanks to those who noticed the issue where digests stopped going out, or the time going out was offset by an hour, after 24 hours. It was hard to figure out what was going on.

The general solution was to remove some code from the mailer that checked for duplicate digests going out for an hour. It should not happen because phpBB cron process should not allow the mailer to run unless an hour has elapsed. (Exception: when running digests manually.) It took a lot of testing and help from users to figure out what was going on. This new release should address it.

A full list of changes since version 3.3.0 can be seen here:

https://github.com/MarkDHamill/digests/ ... .0...3.3.1

The release can be download from my digests extension page or from the GitHub branch. If downloading from GitHub, place the files in the /ext/phpbbservices/digests directory.

Changes in this release:
  • Digests sent from a cron (either phpBB or system) no longer will stop sending digests or offset the hour of their arrival by one hour after 24 hours have elapsed since the digests mailer was reset.
  • If a digest cannot be mailed because phpBB detects a mailing error, a log entry is added to phpBB's error log (on the ACP Maintenance tab) to record the event. The date and hour is recorded. So you should check this log periodically. Note that most digest log entries are written to the admin log, but not this one.
  • A line that replaced the & in a post text with its entity & was removed, as & was showing in the digests.
  • This metatag was removed from the email template because it is no longer valid HTML 5: <meta http-equiv="X-UA-Compatible" content="IE=9; IE=8; IE=7; IE=edge">
All language translations have been updated too, so thanks to the translators for accommodating these changes.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Kindle and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4268
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by hlfritz » Wed May 06, 2020 8:27 pm

Hello,
Running 3.3.1 on phpBB 3.2.9. This is an awesome extension! I have an issue though, and it has to do with a style and the styl'ed email that gets sent. I see that the digest email sends it with the style, but not completely. The fonts contained in the email are not styled, and since it is a dark theme the letters are not visible in much of the digest email. Is there a solution to this?

Thx!
Attachments
styled-email.jpg
example forum and email
Helmut
hlfritz
Registered User
Posts: 49
Joined: Sat Jun 29, 2002 7:59 pm
Location: San Diego
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by MarkDHamill » Wed May 06, 2020 9:57 pm

If you want, you can set the email template default styles, but they will get overwritten when the extension is updated. You can see them here:

https://github.com/MarkDHamill/digests/ ... e/en/email

The first one is probably the only one you want to edit. A plain HTML digest is supposed to look plain, sans background colors and such.

You can use the manual mailer feature to save these to files, then look at them with a browser. They will be in the /store/phpbbservices/digests folder.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Kindle and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4268
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by hlfritz » Wed May 06, 2020 10:10 pm

Thx! I was thinking that selecting plain might be the way to go because I do not have the time to customise the template. I was hoping it would use the user style as is, but it does not seem to do so (i.e. the fonts do not take the coloring, etc. from the user style). Is that correct?
Helmut
hlfritz
Registered User
Posts: 49
Joined: Sat Jun 29, 2002 7:59 pm
Location: San Diego
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by MarkDHamill » Wed May 06, 2020 10:13 pm

The problem is lots of email clients will substitute their own colors and styling, overriding what you specify. Gmail, for instance, will do this. So that's why I do things like specify the <body> tag should have a white background. Removing that line may make the issue go away.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Kindle and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4268
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by hlfritz » Wed May 06, 2020 10:15 pm

ah - that might be easy enough. thanks!
Helmut
hlfritz
Registered User
Posts: 49
Joined: Sat Jun 29, 2002 7:59 pm
Location: San Diego
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by MarkDHamill » Wed May 06, 2020 10:18 pm

Just be aware that email client vary, so there's no guarantee what you see in pure HTML will be what is rendered by the email client.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Kindle and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4268
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by hlfritz » Wed May 06, 2020 10:25 pm

got it, my guess is we will end up just doing plain. can that be forced instead of allowing users to select? i see custom stylesheet, can i put the path to the plain style sheet to force it to be used?
Helmut
hlfritz
Registered User
Posts: 49
Joined: Sat Jun 29, 2002 7:59 pm
Location: San Diego
Contact:

Re: Digests 3.3.1 released, fixes issue with intermittent di

by MarkDHamill » Wed May 06, 2020 10:51 pm

If you specify a custom stylesheet, the email template may still override certain styles because they are applied last.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Kindle and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4268
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact: