Digests

acp/common.php - Digests

acp/common.php

by pg143 » Sat Oct 29, 2022 3:32 pm

Good morning,
French translation team here at www.phpbb-fr.com
In acp/common.php line 101 'DIGESTS_FROM_EMAIL_NAME_EXPLAIN' it says This is the plain text FROM name, whereas it looks like it is the forum contact email address that is retrieved by the extension, not the name.
Should we modify the (translated) explanation or is it a bug?
Cheers
pg143
Registered User
Posts: 8
Joined: Sun Nov 10, 2019 6:12 pm

Re: acp/common.php

by MarkDHamill » Sat Oct 29, 2022 3:51 pm

This is a feature requested by a translator. If enabled this information will appears in the footer of digests.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: acp/common.php

by pg143 » Sat Oct 29, 2022 4:15 pm

Thank you for your reply.
When users receive a digest, this email address will appear in the FROM field does not really refer to the footer, does it?
pg143
Registered User
Posts: 8
Joined: Sun Nov 10, 2019 6:12 pm

Re: acp/common.php

by MarkDHamill » Sat Oct 29, 2022 4:41 pm

My mistake. If this information is present, it shows in the digests user control panel interface at the bottom:
Powered by phpBB Services, translated by Mark D. Hamill
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: acp/common.php

by pg143 » Sat Oct 29, 2022 4:51 pm

Sorry, I don't see how it relates to 'DIGESTS_FROM_EMAIL_NAME_EXPLAIN'.

Our point is that this item mentions the plain text FROM name but the code uses the email address, not the name.
pg143
Registered User
Posts: 8
Joined: Sun Nov 10, 2019 6:12 pm

Re: acp/common.php

by MarkDHamill » Sat Oct 29, 2022 7:00 pm

The contact field can contain either an email address or a URL to the translator's website. If using an email address prefix with mailto:.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: acp/common.php

by Skouat » Sun Oct 30, 2022 11:53 am

Hi Mark,

I'm working with pg143 on this translation.

There is an issue in your code.
On line 292 in core/common.php you pickup the config board_contact instead of board_contact_name

board_contact is the contact email address not the Board Contact Name.

Then in the lang key description you speak about "robot"

Code: Select all

	'DIGESTS_FROM_EMAIL_NAME_EXPLAIN'						=> 'This is the plain text FROM name that will appear in the email client. If left blank it will identify itself as a digests robot for your board.',
Please, can you provide more details about this "digests robot"?
Because, by checking your code, if left blank it use the Board Contact Name (when it will be fixed). Why speaking about Robot?

Thanks,
Skouat
Skouat
Code Contributor
Posts: 1058
Joined: Mon Mar 10, 2008 5:30 pm
Location: France

Re: acp/common.php

by Skouat » Sun Oct 30, 2022 12:27 pm

I spotted another issue (linked to my previous message)

On line 301

Code: Select all

					$messenger->from($from_addr . ' <' . $from_name . '>');
With your current code, this returns [email protected] <[email protected]>
With the change I suggest in my previous message, this returns [email protected] <Board Contact Name>

You have to replace with

Code: Select all

					$messenger->from($from_name . ' <' . $from_addr . '>');
And this will return Board Contact Name <[email protected]>
Skouat
Code Contributor
Posts: 1058
Joined: Mon Mar 10, 2008 5:30 pm
Location: France

Re: acp/common.php

by MarkDHamill » Sun Oct 30, 2022 12:43 pm

Thanks for your research into this. A sender name of "<board name> Robot" appears by default. You can see it on line 733 of /cron/task/digests.php:

Code: Select all

				$from_field_name = (isset($this->config['phpbbservices_digests_from_email_name']) && (strlen($this->config['phpbbservices_digests_from_email_name']) > 0)) ? $this->config['phpbbservices_digests_from_email_name'] : $this->config['sitename'] . ' ' . $this->language->lang('DIGESTS_ROBOT');
Your code changes will be applied to a future version of the extension.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: acp/common.php

by Skouat » Sun Oct 30, 2022 4:10 pm

MarkDHamill wrote: A sender name of "<board name> Robot" appears by default. You can see it on line 733 of /cron/task/digests.php:
Now it's more understandable.
Thanks :)
Skouat
Code Contributor
Posts: 1058
Joined: Mon Mar 10, 2008 5:30 pm
Location: France