Digests

Digests 3.3.17 Writing to Admin log when set to 'No' - Digests

Digests 3.3.17 Writing to Admin log when set to 'No'

by genshijin » Fri Dec 23, 2022 1:02 pm

This only happened after I upgraded and it is annoying to see pages of Digest reports in the Admin log every day that I do not want to sift through for other things in the log.

I cannot see any setting in the extension page for digests that say 'Yes' write actions to Admin log. Any ideas where this action is coming from?

Database server: MySQL(i) 5.7.23-23
PHP version: 7.4.33
Board version: 3.3.9

"Emailed digests for date 2022-12-23 hour 1 UTC. Execution time: 0.00 of 30 allowed seconds. 2.58 MB of memory was used. A total of 0 digests were emailed, 0 digests were skipped and 36 hours were processed."

Screenshot of Digests general settings attached.
Attachments
Screenshot 2022-12-23 at 13-00-11 General settings.png
genshijin
Registered User
Posts: 128
Joined: Fri Nov 09, 2018 2:03 pm
Location: Uk and sometimes Japan
Name: andy duggan

Re: Digests 3.3.17 Writing to Admin log when set to 'No'

by MarkDHamill » Fri Dec 23, 2022 2:39 pm

Currently there is no way to not write the summary line to the admin log. This will show up in a future version of digests. However, editing /cron/task/digests.php as follows:

Change line 334:

Code: Select all

					$this->phpbb_log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_CONFIG_DIGESTS_EMAILING_SUCCESS', false, array(date('Y-m-d', $utc_time), date('H', $utc_time), $execution_time, $max_execution_time, $memory_used_mb, $hourly_report['digests_mailed'], $hourly_report['digests_skipped'], $hours_to_do));

to:

Code: Select all

					if ($this->config['phpbbservices_digests_enable_log'])
					{
						$this->phpbb_log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_CONFIG_DIGESTS_EMAILING_SUCCESS', false, array(date('Y-m-d', $utc_time), date('H', $utc_time), $execution_time, $max_execution_time, $memory_used_mb, $hourly_report['digests_mailed'], $hourly_report['digests_skipped'], $hours_to_do));
					}
should work if the logging feature of digests is turned off.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: Digests 3.3.17 Writing to Admin log when set to 'No'

by genshijin » Fri Dec 23, 2022 2:58 pm

I can't remember noticing as many before... thanks for the quick reply though and fix.
genshijin
Registered User
Posts: 128
Joined: Fri Nov 09, 2018 2:03 pm
Location: Uk and sometimes Japan
Name: andy duggan