Digests

Use of entities in certain fields - Digests

Use of entities in certain fields

by MarkDHamill » Thu Mar 02, 2023 10:47 pm

A sharp eyed user noticed that HTML entities like apostrophes weren't showing up on the Digests General setting page if they were entered in the form. After a lot of analysis, it turns out certain HTML input fields had value attributes that were not surrounded by quotes.

This will get fixed in the next edition. The file adm/style/acp_digests.html can be fixed if desired. Replace lines as shown in this file as follows:

Line 194:

Code: Select all

				<label><input id="phpbbservices_digests_custom_stylesheet_path" name="phpbbservices_digests_custom_stylesheet_path" type="text" size="40" maxlength="255" value="{{ CUSTOM_STYLESHEET_PATH }}"></label>
Line 200:

Code: Select all

				<label><input id="phpbbservices_digests_from_email_address" name="phpbbservices_digests_from_email_address" type="email" size="40" maxlength="255" value="{{ FROM_EMAIL_ADDRESS }}"></label>
Line 206:

Code: Select all

				<label><input id="phpbbservices_digests_from_email_name" name="phpbbservices_digests_from_email_name" type="text" size="40" maxlength="255" value="{{ FROM_EMAIL_NAME }}"></label>
Line 212:

Code: Select all

				<label><input id="phpbbservices_digests_reply_to_email_address" name="phpbbservices_digests_reply_to_email_address" type="email" size="40" maxlength="255" value="{{ REPLY_TO_EMAIL_ADDRESS }}"></label>
Line 224:

Code: Select all

				<label><input id="phpbbservices_digests_include_forums" name="phpbbservices_digests_include_forums" type="text" size="15" maxlength="255" value="{{ INCLUDE_FORUMS }}"></label>
Line 230:

Code: Select all

				<label><input id="phpbbservices_digests_exclude_forums" name="phpbbservices_digests_exclude_forums" type="text" size="15" maxlength="255" value="{{ EXCLUDE_FORUMS }}"></label>
Line 263:

Code: Select all

				<label><input id="phpbbservices_digests_saluation_fields" name="phpbbservices_digests_saluation_fields" type="text" size="40" maxlength="255" value="{{ SALUTATION_FIELDS }}"></label>
Afterward, purge the cache.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: Use of entities in certain fields

by eludlow » Fri Mar 03, 2023 8:58 am

Huge thanks to Mark for the speedy resolution of this issue.
eludlow
Registered User
Posts: 84
Joined: Sun Jan 18, 2004 11:58 am