Digests

Do not send if no new posts? - Digests

Do not send if no new posts?

by benwall » Tue Sep 05, 2023 4:19 pm

Hi,

In both the ACP and UCP I have set "Send a digest if there are no new posts:" to "No"

When manually running the mailer, it is still creating a digest email with no new posts.
Are those settings bypassed when run manually?

Thanks
benwall
Registered User
Posts: 5
Joined: Fri Aug 12, 2022 8:48 am

Re: Do not send if no new posts?

by MarkDHamill » Tue Sep 05, 2023 5:10 pm

Well, let's see. In /cron/task/digests.php, line 1010 shows:

Code: Select all

                                        $okay_to_send = $row['user_digest_send_on_no_posts'] || $this->posts_in_digest > 0 || (is_array($pm_rowset) && count($pm_rowset) > 0) && $row['user_digest_show_pms'];
It looks like it will send a digest if there are private messages in the digest that have not been viewed. The logic here could be improved and will be reviewed in the next version of the extension.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
MarkDHamill
Registered User
Posts: 4933
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA

Re: Do not send if no new posts?

by benwall » Thu Sep 07, 2023 8:11 am

Thanks!
benwall
Registered User
Posts: 5
Joined: Fri Aug 12, 2022 8:48 am