Imgur

Can this be made to work with mChat? - Imgur

Can this be made to work with mChat?

by nou nou » Thu Apr 19, 2018 7:56 pm

Great extension, works a treat!

It would be especially useful for something like mChat, the button appears in the mChat bbcode lists but doesn't do anything - it does not bring up the file browser.

Any chance this can be made to work?

Thanks!
nou nou
Registered User
Posts: 193
Joined: Sat Oct 29, 2016 8:08 pm
Contact:

Re: Can this be made to work with mChat?

by AbaddonOrmuz » Thu Apr 19, 2018 11:19 pm

Hi,

I've added support for mChat in the development branch (reference) and I'll quote myself:
AbaddonOrmuz wrote:There's a development version (do not use it in a live forum) if anyone is interested in testing what might be included in the next version.

[...]

It includes a experimental HTML5 progress bar (at the bottom) and improvements to show PHP ($_FILES) errors.

[...]
https://www.dropbox.com/s/ex61sr4h9skax ... 9.zip?dl=1
A proudly user of Arch Linux :: /r/sddm_themes
User avatar
AbaddonOrmuz
Registered User
Posts: 315
Joined: Wed Dec 25, 2013 9:06 pm
Location: /dev/null
Name: Alfredo Ramos
Contact:

Re: Can this be made to work with mChat?

by nou nou » Sat Apr 21, 2018 5:17 am

Thanks! Will test soon (on a test board...)

If it works, how likely is it too break a live board? :)

(not a terribly serious question...)
nou nou
Registered User
Posts: 193
Joined: Sat Oct 29, 2016 8:08 pm
Contact:

Re: Can this be made to work with mChat?

by AbaddonOrmuz » Sat Apr 21, 2018 5:32 pm

The changes can't break the board, however it hasn't been refined and tested deep enough to find bugs.

The new progress bar is still experimental, it needs visual adjustments.

The security in my extensions is a serious concern, so they have measures to avoid security breaches, if that's what you're worrying about.
A proudly user of Arch Linux :: /r/sddm_themes
User avatar
AbaddonOrmuz
Registered User
Posts: 315
Joined: Wed Dec 25, 2013 9:06 pm
Location: /dev/null
Name: Alfredo Ramos
Contact:

Re: Can this be made to work with mChat?

by nou nou » Mon Apr 23, 2018 6:32 pm

Thanks!

The mChat functionality works great!

I have an issue with this latest version and the full editor. Every time I upload one or more images at a time, every image is embedded into the post twice. In mChat it works great however.

To be totally honest I preferred the previous progress feedback. It was just a rotating icon showing up as it was busy, and as the icon disappeared, the embed tags appeared in the post. Now it seem that the progress is shown while uploading, but then any conversions and embedding comes after. So it looks like the extension is done, and then nothing happens which looks as if something is wrong.
nou nou
Registered User
Posts: 193
Joined: Sat Oct 29, 2016 8:08 pm
Contact:

Re: Can this be made to work with mChat?

by nou nou » Mon Apr 23, 2018 6:58 pm

Oh, one small request - do you think you could make this (optionally) work with the QuickReply extension as well?

Or maybe I could just add that imgur button in there myself somehow?
nou nou
Registered User
Posts: 193
Joined: Sat Oct 29, 2016 8:08 pm
Contact:

Re: Can this be made to work with mChat?

by AbaddonOrmuz » Tue Apr 24, 2018 6:03 pm

nou nou wrote: I have an issue with this latest version and the full editor. Every time I upload one or more images at a time, every image is embedded into the post twice. In mChat it works great however.
I'll take a look.
nou nou wrote: To be totally honest I preferred the previous progress feedback. It was just a rotating icon showing up as it was busy, and as the icon disappeared, the embed tags appeared in the post. Now it seem that the progress is shown while uploading, but then any conversions and embedding comes after. So it looks like the extension is done, and then nothing happens which looks as if something is wrong.
Thanks for the feedback.

Mmm... I could add the previous loading indicator but only when the script processing the images, so it would have a progress bar and a loading indicator.
nou nou wrote: Oh, one small request - do you think you could make this (optionally) work with the QuickReply extension as well?
It should work with the QuickReply extension, I added support for it some time ago. Does not work?

https://www.phpbb.com/customise/db/exte ... pic/181991
A proudly user of Arch Linux :: /r/sddm_themes
User avatar
AbaddonOrmuz
Registered User
Posts: 315
Joined: Wed Dec 25, 2013 9:06 pm
Location: /dev/null
Name: Alfredo Ramos
Contact:

Re: Can this be made to work with mChat?

by nou nou » Tue Apr 24, 2018 9:45 pm

AbaddonOrmuz wrote: Mmm... I could add the previous loading indicator but only when the script processing the images, so it would have a progress bar and a loading indicator.
Sounds like a cool idea :)
AbaddonOrmuz wrote: It should work with the QuickReply extension, I added support for it some time ago. Does not work?
Ohh - my bad - I meant the default Quick Reply functionality. But I'll check out the reloaded one - that looks neat!
nou nou
Registered User
Posts: 193
Joined: Sat Oct 29, 2016 8:08 pm
Contact:

Re: Can this be made to work with mChat?

by nou nou » Tue Apr 24, 2018 10:00 pm

Update - installed the QR Reloaded beta 2, and the Imgur icon did not show among the BBCodes.

(apart from that, I don't much like that extension, it's a bit much - so I'll see if I could just add the Imgur button to the default QuickReply...)
nou nou
Registered User
Posts: 193
Joined: Sat Oct 29, 2016 8:08 pm
Contact:

Re: Can this be made to work with mChat?

by AbaddonOrmuz » Tue May 01, 2018 8:48 pm

Sorry for the late reply.
nou nou wrote:Ohh - my bad - I meant the default Quick Reply functionality. But I'll check out the reloaded one - that looks neat!
The problem is that the default quick reply option does not show any BBCode buttons and I'm using an event to show a custom button there. Adding an icon at the bottom or before the text box looks ugly and is unintuitive.
nou nou wrote: Update - installed the QR Reloaded beta 2, and the Imgur icon did not show among the BBCodes.

(apart from that, I don't much like that extension, it's a bit much - so I'll see if I could just add the Imgur button to the default QuickReply...)
Fixed. In case you want to continue using it, it should work.

v1.2.0-dev (2018-05-01): https://www.dropbox.com/s/o64s0qtvvam5c ... 1.zip?dl=1
A proudly user of Arch Linux :: /r/sddm_themes
User avatar
AbaddonOrmuz
Registered User
Posts: 315
Joined: Wed Dec 25, 2013 9:06 pm
Location: /dev/null
Name: Alfredo Ramos
Contact: