phpBB • Free and Open Source Forum Software

AlfredoRamos · by **AlfredoRamos** » Sat Nov 17, 2018 10:20 pm

This topic is meant to be for people who would like to test development or beta versions. You can also suggest new features or modifications here.

Download: alfredoramos_imgur_1.7.2.zip

Configuration: https://www.phpbb.com/customise/db/exte ... r/faq/2376
Translations: https://www.phpbb.com/customise/db/exte ... r/faq/3281

Changelog:

1.7.2 - 2021-12-13
- Add support for PHP 8+
- Fix Imgur upload to album
- Minor improvements in template files
- Update assets
1.7.2-beta - 2021-12-02
- Add support for PHP 8+
- Update assets
- Fix bug that ignored album setting when uploading images
1.7.1 - 2021-01-29
- Fix issues with phpBB 3.3.3+ (Composer 2)
- Improve Imgur API upload
1.7.0 - 2020-11-06
- Minor fixes and improvements
1.7.0-beta - 2020-11-04
- Add album ID validation in the ACP
- Improve image validation
- Fix route URLs
- Fix URL for version verification
- Small fixes in the ACP
- Small improvements for ABBC3
- Update Spanish, Polish and French translations
- Code cleanup
1.6.0 - 2020-07-10
- Hardening of upload controller
- Reduce data size in sessionStorage
- Improvements in output field filling
1.6.0-beta3 - 2020-06-30
- Add Drag and Drop upload support
- Minor improvements in minified files
1.6.0-beta2 - 2020-06-12
- Minor improvement in ACP validation error messages
1.6.0-beta - 2020-06-03
- Use minified assets (CSS and JS)
- Fix small bug in image validation error message
- Fix Spanish translations
1.5.1 - 2020-04-18
- Fix template events inclusions
- Show warning if the server throws an invalid response
- Small JavaScript fixes
- Small improvements in external links in the ACP
1.5.0 - 2020-02-28
- Code cleanup
1.5.0-beta - 2020-02-12
- Fix JavaScript issues for IE11+
- Small upload panel for mobile
- Code refactoring and cleanup
1.5.0-dev - 2020-02-07
- Add image MIME type check before start uploading
- Show error message when getting empty response from server
- Load assets (JS, CSS) and configuration only when needed, to reduce page load time
- Use a more reliable CDN for FormData polyfill
- JavaScript rewrite (plain JS, no jQuery)
1.4.0 - 2020-01-06
- Update minimum phpBB version dependency to 3.3.0
- Drop support for custom output types
- Small fix in Spanish translations
1.3.1-beta2 - 2019-11-14
- Template improvements (ACP)
- Automatically resize output fields in posting editor panel
- Small fixes in JavaScript code
- Small improvements in CSS (for phpBB 3.3.x)
1.3.1-beta - 2019-11-10
- Add ability to enable/disable output types
- Add all thumbnail sizes provided by Imgur
- Change Output options in the ACP
- Load assets only when needed
- Small fixes in template files to be fully HTML5 compliant
- Small improvements and fixes in JavaScript files to use core functions
- Fix JavaScript support for IE11
1.3.0-beta - 2019-06-14
- Fix bug that made the album ID was required in the ACP settings page.
- Add new image upload tab in the posting box options panel with formats to choose from. [screenshot]
- Add drop-down menu to select the output type. You need to right click the button in the posting box. The value you select will be preserved until you clear your browser local storage. [screenshot]
- Fix compatibility issues with PHP 7.3 (for phpBB 3.3 or greater).
- For developers, add alfredoramos.imgur.allowed_values_append PHP event.

minholi · by **minholi** » Tue Dec 11, 2018 8:57 pm

Already using it. Thanks for the update.

olalavui · by **olalavui** » Thu Jan 03, 2019 1:40 am

Thanks you, working on v3.2.4 / 3.2.5

Binano · by **Binano** » Sat Jan 05, 2019 6:17 pm

Perfect !

Gubkin · by **Gubkin** » Fri Jan 18, 2019 5:27 am

1.2.3-dev

ACP imgur - setting

Fatal error: Uncaught Error: Class 'Imgur\Client' not found in /home/oilchoice/oilchoice.ru/docs/cache/production/container_dbdbe80dc7030ae9bd39ee30cca82130.php:494 Stack trace: #0 /home/oilchoice/oilchoice.ru/docs/vendor/symfony/dependency-injection/Container.php(295): phpbb_cache_container->getAlfredoramos_Imgur_J0k3r_Imgur_ClientService() #1 /home/oilchoice/oilchoice.ru/docs/vendor/symfony/dependency-injection/ContainerBuilder.php(446): Symfony\Component\DependencyInjection\Container->get('alfredoramos.im...', 2) #2 /home/oilchoice/oilchoice.ru/docs/cache/production/container_dbdbe80dc7030ae9bd39ee30cca82130.php(464): Symfony\Component\DependencyInjection\ContainerBuilder->get('alfredoramos.im...') #3 /home/oilchoice/oilchoice.ru/docs/vendor/symfony/dependency-injection/Container.php(295): phpbb_cache_container->getAlfredoramos_Imgur_Acp_ControllerService() #4 /home/oilchoice/oilchoice.ru/docs/vendor/symfony/dependency-injection/ContainerBuilder.php(446): Symfony\Component\DependencyInjection\Container->get('alfredoram in /home/oilchoice/oilchoice.ru/docs/cache/production/container_dbdbe80dc7030ae9bd39ee30cca82130.php on line 494

AlfredoRamos · by **AlfredoRamos** » Fri Jan 18, 2019 6:05 am

Gubkin wrote:1.2.3-dev

ACP imgur - setting
Code: Select all
Fatal error: Uncaught Error: Class 'Imgur\Client' not found 

That version hasn't been released so please do not download the extension from GitHub, it's for development only. If I didn't update the link was because those versions are not ready for live boards.

This extension requires external dependencies, so that error is because the vendor directory is missing, which is generated by Composer.

If you have composer installed on your server, you can run the following commands:

Code: Select all

cd ext/alfredoramos/imgur
composer install --prefer-dist --no-dev

If you don't have composer, revert back to the old version you were using.

Ahri89 · by **Ahri89** » Tue Jan 29, 2019 11:14 pm

Hello, i have this error with beta, i installed the beta because with the estable version i had problems too (internal server errors)

Code: Select all

Error

JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
Internal Server Error

The progress bar works fine uploading a lot of images, but i have this error with one image too

AlfredoRamos · by **AlfredoRamos** » Thu Jan 31, 2019 3:14 am

Ahri89 wrote:Hello, i have this error with beta, i installed the beta because with the estable version i had problems too (internal server errors)
Code: Select all
Error

JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
Internal Server Error
The progress bar works fine uploading a lot of images, but i have this error with one image too

Please try with a more up to date development version:

alfredoramos_imgur_1.2.3-dev.zip

It that doesn't fix the problem, it might be Imgur itself.

Ahri89 · by **Ahri89** » Sat Feb 02, 2019 9:47 pm

Code: Select all

Error

Request to: /3/image failed with: "Array"
Internal Server Error

I have this error with dev version too.

I like the spanish translation included

AlfredoRamos · by **AlfredoRamos** » Wed Feb 06, 2019 8:16 pm

Ahri89 wrote:
Code: Select all
Error

Request to: /3/image failed with: "Array"
Internal Server Error
I have this error with dev version too.

I like the spanish translation included

Sorry for the late reply, I've been busy lately.

I'll investigate as soon as I have the time to do so.

P.S.: Spanish is my mother language, so all my extension are translated into Spanish

Ahri89 · by **Ahri89** » Thu Feb 07, 2019 5:48 pm

Thanks for the reply

the extension looks nice <3

Gubkin · by **Gubkin** » Tue Feb 12, 2019 5:44 pm

Perfect!!
Thank you for Quick Reply support!
Too much numbers after point i think )))

nou nou · by **nou nou** » Wed Feb 13, 2019 8:01 pm

Finally tested this. Disabled version 1.1.1, deleted files, uploaded 1.2.3-dev and enabled - everything works perfectly.

Agreed with Gubkin that the numbers after the decimal are a little much.

I still personally prefer the progress icon from 1.1.1 - it just looks nicer to me. Any chance to either revert to that one or offer it as a choice? I wouldn't even mind adjusting the code myself if you could tell me where to do that...

Great work though, I've tested and see no issues - would you say it's production ready?

AlfredoRamos · by **AlfredoRamos** » Wed Feb 13, 2019 8:45 pm

Ahri89 wrote:
Code: Select all
Error

Request to: /3/image failed with: "Array"
Internal Server Error
I have this error with dev version too.

I couldn't reproduce the error, do you still have that problem?

Error 500 (internal server error) comes from Imgur servers, and in fact that was one of the reasons v1.2.x version was denied, Imgur was having problems when it was being tested for validation.

Gubkin wrote: Perfect!!
Thank you for Quick Reply support!
Too much numbers after point i think )))

Glad to hear is working well with that extension, please let me know if you find any issue.

nou nou wrote: Agreed with Gubkin that the numbers after the decimal are a little much.

I'll change that, v1.2.2 has been in the validation queue for more than a month, so It won't be fixed until v1.2.3 or greater.

nou nou wrote: I still personally prefer the progress icon from 1.1.1 - it just looks nicer to me. Any chance to either revert to that one or offer it as a choice? I wouldn't even mind adjusting the code myself if you could tell me where to do that...

It wasn't removed, just replaced for the progress bar when uploading, it still shows the loading indicator but when adding the BBCode to the message. That was for two reasons:

Users requested a progress bar
The previous loading indicator only waits for 100 seconds, if it does not get any response it throws a timeout error which abort the upload process, which is problematic for slow servers or large images. That time can't be changed without modifying core values, and that could break some internal functions, which is not correct nor ideal.

It won't be added back nor included as an option, and I wouldn't recommend add it back either, specially for the second reason above.

nou nou wrote: Great work though, I've tested and see no issues - would you say it's production ready?

I would say it is, v1.2.2 has been in validation for some time.

Besides, my extensions although are mainly for personal use, I know for a fact that are used in live boards (not just mine) so I try to not push changes that would break a board or represent a security threat, in case someone downloads my extensions from GitHub, which by the way I do not recommend doing with this one since it needs to run composer to get external dependencies.

AlfredoRamos · by **AlfredoRamos** » Sun Feb 24, 2019 2:46 pm

Gubkin wrote:Perfect!!
Too much numbers after point i think )))

nou nou wrote: Agreed with Gubkin that the numbers after the decimal are a little much.

I've fixed that in v1.2.3-RC1, it will show up to 3 digits (hard-coded) after the decimal separator.

First post updated with changelog and download link.

Imgur

[RC] Version 1.7.2 - Imgur