Moon Phase

div element in <head> - Moon Phase

div element in <head>

by janus_zonstraal » Thu Oct 31, 2019 12:16 pm

This extension places a div element in the <head>, what is not allowed I think?
Is there no other way to insert it?

Code: Select all

<div id="moon">
</div>
Edit: Sorry, it is only in the latest version , not the one from here .
Sorry! My English is bat ;) !!!
User avatar
janus_zonstraal
Registered User
Posts: 3791
Joined: Sat Aug 30, 2014 1:30 pm
Contact:

Re: div element in <head>

by HiFiKabin » Thu Oct 31, 2019 1:08 pm

The versions available from here (including the most recent 1.0.7) have always been written this way and have been approved to the CDB; but you can change it to

Code: Select all

<li id="moon">
</li>
if you prefer which works in my local testing.
User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4105
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: div element in <head>

by janus_zonstraal » Thu Oct 31, 2019 1:25 pm

The 1.0.7 version from the overall_header_head_append.html was like this

Code: Select all

{% INCLUDECSS '@hifikabin_moonphase/moonphase.css' %}
{% INCLUDEJS '@hifikabin_moonphase/moonphase.js' %}
{% if S_USER_MOON %}
{% INCLUDECSS '@hifikabin_moonphase/moonphase_south.css' %}
{% endif %}
The one from 1.0.8RC1 is like this

Code: Select all

<div id="moon">
	{% INCLUDECSS '@hifikabin_moonphase/moonphase.css' %}
	{% INCLUDEJS '@hifikabin_moonphase/moonphase.js' %}
	{% if S_USER_MOON %}
	{% INCLUDECSS '@hifikabin_moonphase/moonphase_south.css' %}
	{% endif %}
</div>
Changing that in <li> make no different, <li> is also not allowed in the <head>
Sorry! My English is bat ;) !!!
User avatar
janus_zonstraal
Registered User
Posts: 3791
Joined: Sat Aug 30, 2014 1:30 pm
Contact:

Re: div element in <head>

by HiFiKabin » Thu Oct 31, 2019 4:27 pm

:oops: Apologies, blame a tired head for not reading your post properly. Of course you are correct, that div should not be there (and I have no idea why of how it appeared) I will release a new RC very shortly. Thanks for letting me know.
User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4105
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: div element in <head>

by janus_zonstraal » Thu Oct 31, 2019 4:42 pm

De nada
Sorry! My English is bat ;) !!!
User avatar
janus_zonstraal
Registered User
Posts: 3791
Joined: Sat Aug 30, 2014 1:30 pm
Contact: