National Flags

Style changes to account for phpBB 3.2.2 - National Flags

Style changes to account for phpBB 3.2.2

by EA117 » Wed Oct 24, 2018 12:26 pm

Don't know if this is somehow unique to me, but I had to introduce the use of <div class="list-inner"> to get correct / expected padding in the nationalflags-related rendering when using the 2.1.6 extension on phpBB 3.2.2. This appeared to match what 3.2.2 itself was doing in proSilver for the forum list blocks and other "header" block areas.

I expect my proSilver-inherited style was just magnifying the effect of this omission, which might be less noticable with proSilver directly. But this does appear to be a div that proSilver is intentionally using in these cases on 3.2.x.

Code: Select all

--- E:\nationalflags-2.1.6-from-phpBB\rmcgirr83\nationalflags\styles\prosilver\template\flag_users.html	2018-03-06 11:08:14.000000000 -0500
+++ E:\nationalflags-2.1.6-modified for phpbb 3.2.20180817\nationalflags\styles\prosilver\template\flag_users.html	2018-08-17 10:10:30.000000000 -0500
@@ -15,13 +15,13 @@
 		
 		<div class="forabg">
 			<div class="inner">
 			<ul class="topiclist">
 				<li class="header">
 					<dl class="<!-- IF PHPBB_IS_32 -->row-item<!-- ELSE -->icon<!-- ENDIF -->">
-						<dt>{L_USERNAME}</dt>
+						<dt><!-- IF PHPBB_IS_32 --><div class="list-inner"><!-- ENDIF -->{L_USERNAME}<!-- IF PHPBB_IS_32 --></div><!-- ENDIF --></dt>
 						<dd class="topics">{L_POSTS}</dd>
 						<dd class="lastpost"><span>{L_JOINED}</span></dd>
 					</dl>
 				</li>
 			</ul>
 			<ul class="topiclist topics">


--- E:\nationalflags-2.1.6-from-phpBB\rmcgirr83\nationalflags\styles\prosilver\template\flags_list.html	2018-03-06 11:08:14.000000000 -0500
+++ E:\nationalflags-2.1.6-modified for phpbb 3.2.20180817\nationalflags\styles\prosilver\template\flags_list.html	2018-08-17 10:11:07.000000000 -0500
@@ -1,15 +1,13 @@
 <!-- INCLUDE overall_header.html -->
 <div class="forabg">
 	<div class="inner" id="flagusers">
 		<ul class="topiclist">
 			<li class="header">
 				<dl class="<!-- IF PHPBB_IS_32 -->row-item<!-- ELSE -->icon<!-- ENDIF -->">
-					<dt>
-							{L_FLAGS}
-					</dt>
+					<dt><!-- IF PHPBB_IS_32 --><div class="list-inner"><!-- ENDIF -->{L_FLAGS}<!-- IF PHPBB_IS_32 --></div><!-- ENDIF --></dt>
 					<dd></dd>
 				</dl>
 			</li>
 		</ul>
 		<ul class="forums flags">
 		<!-- BEGIN flag -->


--- E:\nationalflags-2.1.6-from-phpBB\rmcgirr83\nationalflags\styles\prosilver\template\index_flags.html	2018-03-06 11:08:14.000000000 -0500
+++ E:\nationalflags-2.1.6-modified for phpbb 3.2.20180817\nationalflags\styles\prosilver\template\index_flags.html	2018-08-17 10:12:22.000000000 -0500
@@ -1,13 +1,13 @@
 <a class="category<!-- IF S_NATIONALFLAGS_HIDDEN --> hidden-category<!-- ENDIF -->" style="display: none; height: 0"></a>
 <div class="forabg" id="flags">
 	<div class="inner">
 	<ul class="topiclist">
 		<li class="header">
 			<dl class="<!-- IF PHPBB_IS_32 -->row-item<!-- ELSE -->icon<!-- ENDIF -->">
-				<dt><!-- IF U_FLAGS --><a href="{U_FLAGS}"><!-- ENDIF -->{L_NATIONAL_FLAGS}<!-- IF U_FLAGS --></a><!-- ENDIF --></dt>
+				<dt><!-- IF PHPBB_IS_32 --><div class="list-inner"><!-- ENDIF --><!-- IF U_FLAGS --><a href="{U_FLAGS}"><!-- ENDIF -->{L_NATIONAL_FLAGS}<!-- IF U_FLAGS --></a><!-- ENDIF --><!-- IF PHPBB_IS_32 --></div><!-- ENDIF --></dt>
 				<dd></dd>
 			</dl>
 			<!-- IF U_NATIONALFLAGS_COLLAPSE_URL --><a href="{U_NATIONALFLAGS_COLLAPSE_URL}" class="collapse-btn collapse-<!-- IF S_NATIONALFLAGS_HIDDEN -->show<!-- ELSE -->hide<!-- ENDIF -->" data-hidden="{S_NATIONALFLAGS_HIDDEN}" data-ajax="phpbb_collapse" data-overlay="true" title="{L_COLLAPSIBLE_CATEGORIES_TITLE}" style="display: none; line-height: 0;"></a><!-- ENDIF -->
 		</li>
 	</ul>
 	<ul class="forums flags collapsible">
User avatar
EA117
Registered User
Posts: 2176
Joined: Wed Aug 15, 2018 3:23 am