phpBB • Free and Open Source Forum Software

Satanasov · by **Satanasov** » Fri Aug 11, 2017 12:12 pm

I'll wait for DavidIQ to propose a fix and patch it.

Did I tell you this is not extension issue?

kasimi · by **kasimi** » Fri Aug 11, 2017 12:25 pm

As far as I can see the event that's causing the problems that Galixte linked to isn't used in this extension. Either there's another event that has the same problem, or it's an entirely different issue here.

Satanasov · by **Satanasov** » Fri Aug 11, 2017 12:52 pm

I'm using 'core.user_setup' as event.

Galixte de EzCom · by **Galixte de EzCom** » Fri Aug 11, 2017 12:54 pm

Satanasov wrote:I'll wait for DavidIQ to propose a fix and patch it.

Did I tell you this is not extension issue?

Never.

Galixte de EzCom · by **Galixte de EzCom** » Fri Aug 11, 2017 12:56 pm

kasimi: https://github.com/satanasov/phpbbgalle ... etup&type=

kasimi · by **kasimi** » Fri Aug 11, 2017 4:56 pm

Galixte, can you link your French translation?

Galixte de EzCom · by **Galixte de EzCom** » Fri Aug 11, 2017 5:35 pm

French language pack : http://www.phpbb-fr.com/telechargements ... -3.2.1.zip but for my tests i use QuickInstall with the FULL FRENCH package of phpBB 3.2.1: http://www.phpbb-fr.com/telechargements ... 2.1_FR.zip.

I'm not sure you're talking about phpBB, so the French language pack from phpBB Gallery extension is already in his GitHub repository and about Topic Title Color: http://www.ezcom-fr.com/viewtopic.php?f=25&t=748.

kasimi · by **kasimi** » Fri Aug 11, 2017 6:40 pm

Oh, I did check the GitHub repo but was on the wrong branch.

Turns out it's the same issue: loading language before the user is set up. You're subscribing to the core.user_setup event which is triggered inside the user's setup() method but before the board's default language is loaded, which happens just a few lines later. Inside the event you're using the language service to load your extension's language files, which are later overwritten by the core when it sets up the language for the user.

Long story short, instead of doing this, use the event's lang_set_ext array:

Code: Select all

$lang_set_ext = $event['lang_set_ext'];
$lang_set_ext[] = array(
	'ext_name'	=> 'phpbbgallery/core',
	'lang_set'	=> array('info_acp_gallery', 'gallery', 'gallery_notifications', 'permissions_gallery'),
);
$event['lang_set_ext'] = $lang_set_ext;

Satanasov, please keep this in mind:

For performance reasons, only load translations that are absolutely needed globally using this event. Use local events otherwise.

Galixte de EzCom · by **Galixte de EzCom** » Fri Aug 11, 2017 7:29 pm

So, after your investigations when i asked if it’s an issue about PHP template use or a bug in phpBB core: viewtopic.php?p=14801616#p14801616 what’s the answer?

Satanasov · by **Satanasov** » Fri Aug 11, 2017 8:37 pm

It's not bug ... more like a fluke ...

kasimi · by **kasimi** » Fri Aug 11, 2017 9:14 pm

Galixte, I'm not sure what you mean. The answer was already given in the topic you linked.

Galixte de EzCom · by **Galixte de EzCom** » Fri Aug 11, 2017 10:35 pm

Sorry, i tried to make a joke for Sanatanov but i’m really bad to do that.

Satanasov · by **Satanasov** » Mon Aug 14, 2017 11:43 pm

Grenh wrote:PhpBB recommends using php 7.1. The gallery can not run on such system, the server stops and nothing is displayed, everything does not work.
You have to remove everything manually - giant work.

I'm running it under 7.1.7 - no issue.

Grenh · by **Grenh** » Sun Aug 20, 2017 2:57 pm

By PHP 7.1
You can not add permissions to new installs, just a blank screen. Line 1240 error in permissions_module.php.
There is also an error in this line, does not indicate the number value
$ Images_per_day = sprintf ('% .2f', $ config ['num_images'] / $ boarddays);

Grenh · by **Grenh** » Sun Aug 20, 2017 5:47 pm

HERE ARE ERROR LOG

#5 {main}
#4 /home/r/c/ftp_xxxxx/adm/index.php(82): p_master->load_active()
#3 /home/r/c/ftp_xxxxx/includes/functions_module.php(676): phpbbgallery\core\acp\permissions_module->main('\\phpbbgallery\\c...', 'manage')
#2 /home/r/c/ftp_xxxxx/ext/phpbbgallery/core/acp/permissions_module.php(101): phpbbgallery\core\acp\permissions_module->permissions_p_mask()
#1 /home/r/c/ftp_xxxxx/ext/phpbbgallery/core/acp/permissions_module.php(609): phpbbgallery\core\acp\permissions_module->p_system_inherit_victims(-3, Array, '2')
#0 /home/r/c/ftp_xxxxx/ext/phpbbgallery/core/acp/permissions_module.php(1246): phpbbgallery\core\cache->__construct(Object(phpbb\cache\service), Object(phpbb\db\driver\factory))
Stack trace:
[20-Aug-2017 19:38:04 Europe/Copenhagen] PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function phpbbgallery\core\cache::__construct(), 2 passed in /home/r/c/ftp_xxxxxx/ext/phpbbgallery/core/acp/permissions_module.php on line 1246 and exactly 4 expected in /home/r/c/ftp_xxxxx/ext/phpbbgallery/core/cache.php:26
thrown in /home/r/c/ftp_xxxxx/ext/phpbbgallery/core/cache.php on line 26

phpBB Gallery

phpBB Gallery 1.2.1 - phpBB Gallery