phpBB Gallery

phpBB Gallery 1.2.1 - phpBB Gallery

Re: phpBB Gallery 1.2.1

by Galixte de EzCom » Thu Aug 03, 2017 10:47 am

Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.

Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 945
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: phpBB Gallery 1.2.1

by Satanasov » Mon Aug 07, 2017 3:36 am

Style fixed ... most of it ... I have to fix upload screen.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.
Satanasov
Registered User
Posts: 1133
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: phpBB Gallery 1.2.1

by Galixte de EzCom » Mon Aug 07, 2017 7:48 am

Thanks! I will check this ^_^

EDIT: i have tested yes it’s better, like link list menu where the fa icons are nice. Maybe you can use the same eye fa icon in the navbar. ;)

Moreover there are a lot of pages which you should test these.For example:
  • the edit comment page where the image isn’t resized,
  • the edit photo page where the “photo name” tag isn’t displayed at the correct location and the rotation buttons aren’t displayed too at the correct location,
  • in UCP, the album subscriptions page (./ucp.php?i=-phpbbgallery-core-ucp-main_module&mode=manage_subscriptions) has 3 columns but for images which has received some comments the comment link isn’t displayed and the text “by …” isn’t displayed at the correct location.


Futhermore, why i can’t note my own photos, while the permissions are correct?
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.

Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 945
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: phpBB Gallery 1.2.1

by Satanasov » Mon Aug 07, 2017 9:44 am

Galixte de EzCom wrote:Thanks! I will check this ^_^
  • in UCP, the album subscriptions page (./ucp.php?i=-phpbbgallery-core-ucp-main_module&mode=manage_subscriptions) has 3 columns but for images which has received some comments the comment link isn’t displayed and the text “by …” isn’t displayed at the correct location.

I'm sure I fixed this - please provide screenshot
Galixte de EzCom wrote:Thanks! I will check this ^_^
Futhermore, why i can’t note my own photos, while the permissions are correct?
Note?
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.
Satanasov
Registered User
Posts: 1133
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: phpBB Gallery 1.2.1

by Galixte de EzCom » Mon Aug 07, 2017 11:07 am

  1. the edit comment page where the image isn’t resized:
    If i go on a photo view page, like this:
    photo_view_page_with_one_comment.png
    below there is a comment, if i want to edit the comment from the photo, on the edit comment page the photo isn’t resized:
    photo_comment_page_image_not_resized.jpg
  2. the edit photo page where the “photo name” tag isn’t displayed at the correct location and the rotation buttons aren’t displayed too at the correct location:
    photo_edit_page.jpg
  3. in UCP, the album subscriptions page has 3 columns but for images which has received some comments the comment link isn’t displayed and the text “by …” isn’t displayed at the correct location:
    UCP_manage_subscriptions_page.jpg
    Same page zoomed to see the problem:
    UCP_manage_subscriptions_page_zoomed.jpg
  4. By doing some screenshots, i had set my user settings to english and prosilver to show you the problems with original conditions like a vanilla phpBB, and i discovered a new problem with language!

    The phpBB Gallery extension doesn’t take in consideration the USER language if it’s not the same as default board language, explanations:
    • If i set the default board language to FRENCH, and i set my UCP language setting to FRENCH => Ok, the board and the phpBB Gallery pages are displayed in FRENCH,
    • if i set the default board language to FRENCH, and i set my UCP language setting to ENGLISH => NOT Ok, the board and the phpBB Gallery pages are displayed in mixed languages FRENCH and ENGLISH. FRENCH is still displayed on: index, navbar, quick links, viewforum, viewtopic while UCP, MCP, ACP, contact page, are displayed in ENGLISH,
    • by inverting language in two previous tests (english to french and french to english) it’s the same situation, same issue.
    Very strange issue. I have tested on phpBB 3.2.0 and 3.2.1 original versions with prosilver. The phpBB Gallery CORE extension is the problem not addons.

    Examples, in RED for FRENCH and in GREEN for ENGLISH:
    gallery_page_LI.jpg
    ucp_manage_personal_albums_page_LI.jpg
    ucp_manage_subscriptions_page_LI.jpg
    ucp_personal_settings_page_LI.jpg
    Satanasov wrote:
    Galixte de EzCom wrote:Thanks! I will check this ^_^
    Futhermore, why i can’t note my own photos, while the permissions are correct?
    Note?
    Yes, i wanted to test the rating for my own photos but i can’t. I can rate the photos from other users but not mine while the permissions are set correctly. Maybe it’s stupid to rate my own photos but why to propose the permission for rating if i can’t?
Last edited by Galixte de EzCom on Fri Aug 11, 2017 7:39 am
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.

Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 945
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: phpBB Gallery 1.2.1

by Satanasov » Mon Aug 07, 2017 5:22 pm

Fixed:

Edit comment image resize
Image upload/edit style

Can't reproduce:

Image subscription page (I see the comments in the appropriate field)

Can't/won't/don't know how to fix:

Language. The loading of language is handled by phpbb language class. I don't know why it loads the wrong one.

About rating - it is hard coded that the user can't rate his own images.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.
Satanasov
Registered User
Posts: 1133
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: phpBB Gallery 1.2.1

by archivar » Mon Aug 07, 2017 5:48 pm

Thank you for the style adjustment.
Sorry, the user's signature, under the comment, is not displayed correctly.
Best regards, Archivar
Sorry for my English Google Translation.
User avatar
archivar
Registered User
Posts: 209
Joined: Sun Sep 13, 2009 1:00 pm
Location: Deutschland

Re: phpBB Gallery 1.2.1

by Satanasov » Mon Aug 07, 2017 6:43 pm

archivar wrote:Thank you for the style adjustment.
Sorry, the user's signature, under the comment, is not displayed correctly.
The user profiles have to be rewritten.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.
Satanasov
Registered User
Posts: 1133
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: phpBB Gallery 1.2.1

by Kaffe » Tue Aug 08, 2017 8:59 am

Either I am blind, or I can't seem to find the place for this field in the language files:

Image

Any idea?

[edit] nevermind, it was located in info_acp_gallery.php [/edit]
Kaffe
Registered User
Posts: 64
Joined: Tue Nov 01, 2016 6:18 pm

Re: phpBB Gallery 1.2.1

by archivar » Tue Aug 08, 2017 11:52 am

Satanasov wrote:
archivar wrote:Thank you for the style adjustment.
Sorry, the user's signature, under the comment, is not displayed correctly.
The user profiles have to be rewritten.
The signature is not accepted by the gallery in the BBCODE.
Best regards, Archivar
Sorry for my English Google Translation.
User avatar
archivar
Registered User
Posts: 209
Joined: Sun Sep 13, 2009 1:00 pm
Location: Deutschland

Re: phpBB Gallery 1.2.1

by Grenh » Tue Aug 08, 2017 12:22 pm

PhpBB recommends using php 7.1. The gallery can not run on such system, the server stops and nothing is displayed, everything does not work.
You have to remove everything manually - giant work. :(
Grenh
Registered User
Posts: 8
Joined: Tue Aug 08, 2017 12:14 pm
Contact:

Re: phpBB Gallery 1.2.1

by Satanasov » Tue Aug 08, 2017 5:59 pm

Grenh wrote:PhpBB recommends using php 7.1. The gallery can not run on such system, the server stops and nothing is displayed, everything does not work.
You have to remove everything manually - giant work. :(
I think I'm working on 7.1 but I will check tomorrow on my dev machine ... if not I will update and push a fix.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.
Satanasov
Registered User
Posts: 1133
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: phpBB Gallery 1.2.1

by Galixte de EzCom » Wed Aug 09, 2017 9:59 am

  1. This is my configuration about sizes of thumbnails, i’m sure it will help you to resolve the issues reported:

    Gallery Configuration_album_settings.png
    recent_comments_page_image_is_out_of_area

    Gallery Configuration_thumbnails_settings.png
    image_edit_page_image_hidden_fiels_appear
    Gallery Configuration_thumbnails_settings.png (6.91 KiB) Viewed 388 times
  2. Satanasov wrote:Fixed:

    Edit comment image resize
    Comment page issue it’s solved, thanks! But in Recent comments page the image is displayed out of the area:

    recent_comments_page_image_is_out_of_area.png
    Gallery Configuration_album_settings
    If you cannot reproduce try to test with my thumbnails configuration above. ;)
  3. Satanasov wrote:Fixed:

    …Image upload/edit style
    On image edit pages there is a problem, now the name fields what i talked about before are displayed in background of thumbnails image:
    image_edit_page.png
    image_edit_page_devloper_tool_window_view_image_link_removed
    i activate developer tool on the thumbnail image:
    image_edit_page_devloper_tool_window_view_image_link.png
    image_edit_page_devloper_tool_window_view_image_link
    i remove the link of image:
    image_edit_page_devloper_tool_window_view_image_link_removed.png
    image_edit_page
    now i can see the names of fields :mrgreen:
    image_edit_page_image_hidden_fiels_appear.png
    Gallery Configuration_thumbnails_setting
    You’ll agree that it’s problematic. Maybe it’s because my thumbnails size is over the default size, but the script should consider of different thumbnail sizes.
  4. Satanasov wrote:Can't reproduce:

    Image subscription page (I see the comments in the appropriate field)
    Try to test with my thumbnails configuration above. ;)
  5. Satanasov wrote:Can't/won't/don't know how to fix:

    Language. The loading of language is handled by phpbb language class. I don't know why it loads the wrong one.
    Please, by not resolving this issue user can’t use correctly your tool on a multi-languages board. Ask to the phpBB Extension Team. ;)
  6. Satanasov wrote:About rating - it is hard coded that the user can't rate his own images.
    Thanks for information.
  7. archivar wrote:
    The signature is not accepted by the gallery in the BBCODE.
    phpBB Gallery doesn’t take in consideration BBCode and Smilies in signature displayed on comment pages.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.

Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 945
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: phpBB Gallery 1.2.1

by Satanasov » Wed Aug 09, 2017 11:41 am

The thumbnail issue ... this is due to a fixed width of the phpBB dl/dt/dd tags. I have an idea how to fix it ...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.
Satanasov
Registered User
Posts: 1133
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: phpBB Gallery 1.2.1

by Galixte de EzCom » Fri Aug 11, 2017 12:06 pm

@Satanasov, take a look at: viewtopic.php?p=14801546#p14801546.

It’s about number 4 from my post, here: https://www.phpbb.com/customise/db/exte ... 51#p579651 (language issue).

If you have some informations to help DavidIQ you’re welcome. ;)
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.

Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 945
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact: