Post Numbers

Doesn't compatible with Quickedit - Post Numbers

Doesn't compatible with Quickedit

by mykee » Sat Jan 20, 2018 11:04 am

Hello,

I installed this extension and I need this great features, but incompatible with Quickedit. When I edit post, then edit window will duplicate. Before install this extension, Quickedit worked correctly under 3.2.2 version too...

How can I fix this? :roll:
mykee
Registered User
Posts: 271
Joined: Thu Jun 07, 2007 9:46 pm

Re: Doesn't compatible with Quickedit

by kasimi » Sat Jan 20, 2018 11:49 am

Post Numbers 1.1.2 and Quickedit 1.0.1 work fine on my phpBB 3.2.1 board. Make sure you use the latest versions and test with prosilver.
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: Doesn't compatible with Quickedit

by mykee » Sat Jan 20, 2018 2:01 pm

Yes, I use latest version from both plugin, and phpBB 3.2.2 version. My template is prosilver base. Hmmm...
mykee
Registered User
Posts: 271
Joined: Thu Jun 07, 2007 9:46 pm

Re: Doesn't compatible with Quickedit

by kasimi » Sat Jan 20, 2018 2:54 pm

I assume you did these manual changes to Quickedit 1.0.1? https://github.com/marc1706/phpbb3-ext- ... l/84/files

Send me a link to your board and I'll have a look.
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: Doesn't compatible with Quickedit

by mykee » Sat Jan 20, 2018 3:45 pm

Yes, I made this modifications before installed this plugin. I sent a PM with more info.
mykee
Registered User
Posts: 271
Joined: Thu Jun 07, 2007 9:46 pm

Re: Doesn't compatible with Quickedit

by kasimi » Sat Jan 20, 2018 4:09 pm

Temporary workaround: enable Copy post link to clipboard when clicking on post number in the ACP.

Permanent solution: https://github.com/kasimi/phpbb-ext-pos ... 6717e5d3a7
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: Doesn't compatible with Quickedit

by mykee » Sat Jan 20, 2018 4:26 pm

Great, this is my solution! Thanks for quick help!
mykee
Registered User
Posts: 271
Joined: Thu Jun 07, 2007 9:46 pm

Re: Doesn't compatible with Quickedit

by Mornagest » Mon Aug 09, 2021 5:43 pm

Hi Kasimi,

I'm using phpBB 3.3.4, QuickEdit 1.0.1 and Post Numbers 1.1.3 and I also have this double edit window.

I tried QuickEdit before installing Post Numbers and it was working correctly so I suppose it also comes from Post Numbers but who knows?

Do you have any idea?

Thank you in advance!
Mornagest
Registered User
Posts: 66
Joined: Thu Jul 08, 2021 8:06 pm
Location: Belgian in France

Re: Doesn't compatible with Quickedit

by Mornagest » Wed Aug 18, 2021 10:49 am

Anyone has an idea? :)
Mornagest
Registered User
Posts: 66
Joined: Thu Jul 08, 2021 8:06 pm
Location: Belgian in France

Re: Doesn't compatible with Quickedit

by kasimi » Sat Sep 11, 2021 3:48 pm

Not sure what's causing your issues. The combination of Quickedit 1.0.1 and Post Numbers 1.1.3 works fine on my board.
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: Doesn't compatible with Quickedit

by yogzi » Thu May 16, 2024 12:20 am

To fix the compatibility issue between Post Numbers 1.1.3 and Quickedit 1.1.0 that keeps making two quickedit windows instead of one in phpbb 3.3.11, you can find a line in the quickedit.js code that adds the window after an author class:

Code: Select all

$(res.MESSAGE).insertAfter($post.find('.author'));
Then change it to:

Code: Select all

$(res.MESSAGE).insertAfter($post.find('.author').not('.post-number'));
So it will not insert it after a class named "post-number". The <p> that shows post numbers uses both author and post-number classes, that's why it's inserted after the post number first and then again after <p> with only author class

quickedit.js is located in /styles/prosilver/template/ folder of quickedit extension v1.1.0 that can be found here: https://github.com/marc1706/phpbb3-ext-quickedit
yogzi
Registered User
Posts: 2
Joined: Thu May 16, 2024 12:02 am