Notification - Posts merging
Notification
I haven't notification if a user is quoted or mentioned... There is a fix?
-
- Registered User
- Posts: 94
- Joined: Fri Feb 10, 2017 8:16 am
Re: Notification
What is the use scenario?
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation
Re: Notification
Standard scenario...
I reply ... After, i quote a user's message and re-reply, the plugin merge my 2 messages but the user don't receive the notification of quoted message
I reply ... After, i quote a user's message and re-reply, the plugin merge my 2 messages but the user don't receive the notification of quoted message
-
- Registered User
- Posts: 94
- Joined: Fri Feb 10, 2017 8:16 am
Re: Notification
That is a bug indeed, thanks for reporting. You could try the following fix:
https://github.com/rxu/posts_merging/co ... 89de97e98a
https://github.com/rxu/posts_merging/co ... 89de97e98a
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation
Re: Notification
Perfect, works 
-
- Registered User
- Posts: 94
- Joined: Fri Feb 10, 2017 8:16 am
Re: Notification
Does not work for me. 

-
- Registered User
- Posts: 229
- Joined: Mon Jun 01, 2009 7:48 pm
Re: Notification
Too few information. What exactly are you doing and what doesn't work?
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation
Re: Notification
Well, I've updated to the latest version from GitHub, but there is no notification for being quoted in a merged post, as described above by scheccia. So the bug is not resolved in my case.
-
- Registered User
- Posts: 229
- Joined: Mon Jun 01, 2009 7:48 pm
Re: Notification
The fix is here https://github.com/rxu/posts_merging/co ... 89de97e98a and you need to apply it by hands to make it work, or copy the file contents from the source to the server.
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation
Re: Notification
That's exactly what I did. But it is not working.
Here's a screen of the file from my server:
https://i.imgur.com/qfuFbjy.png
Here's a screen of the file from my server:
https://i.imgur.com/qfuFbjy.png
-
- Registered User
- Posts: 229
- Joined: Mon Jun 01, 2009 7:48 pm
Re: Notification
How did you test it exactly? Does the 1st part already have the user quoted already?
Again, you're giving too few information. It's impossible for me to guess what happens on your side.
Again, you're giving too few information. It's impossible for me to guess what happens on your side.
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation
Re: Notification
I wrote a post. No quote, nothing. Just text. Then I wrote a second post shortly after. The second one included a quote. The posts were merged together. I logged out and logged in as the quoted user. But I had no notification.
-
- Registered User
- Posts: 229
- Joined: Mon Jun 01, 2009 7:48 pm
Re: Notification
Tested again right now and it worked for me.
Are you sure the user quoted has the quote notifications enabled in UCP?
Are you sure the user quoted has the quote notifications enabled in UCP?
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation
Re: Notification
Okay, I now got it working. I disabled the extension, deleted all data and re-enabled it. But that's what I did yesterday as well.
Thanks for the help!
Another quick question regarding the notifications: Can you add support for Paul's SimpleMentions Ext?
I've seen this part of the code:
Simply adding the notification type:
Results in this:
Thanks for the help!
Another quick question regarding the notifications: Can you add support for Paul's SimpleMentions Ext?
I've seen this part of the code:
Code: Select all
$this->notification_manager->add_notifications(array(
'notification.type.quote',
'notification.type.bookmark',
'notification.type.post',
), $notification_data);
Code: Select all
paul999.mention.notification.type.mention
Code: Select all
[phpBB Debug] PHP Warning: in file [ROOT]/ext/paul999/mention/notification/type/mention.php on line 115: Invalid argument supplied for foreach()
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 1836: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3268)
-
- Registered User
- Posts: 229
- Joined: Mon Jun 01, 2009 7:48 pm
Re: Notification
How did you add it exactly?it should be like that
Code: Select all
$this->notification_manager->add_notifications(array(
'notification.type.quote',
'notification.type.bookmark',
'notification.type.post',
'paul999.mention.notification.type.mention',
), $notification_data);
-
- Extensions Development Team
- Posts: 4018
- Joined: Wed Oct 25, 2006 12:46 pm
- Location: Siberia, Russian Federation