Posts merging

Notification - Posts merging

Notification

by scheccia » Sat Jan 27, 2018 5:37 pm

I haven't notification if a user is quoted or mentioned... There is a fix?
scheccia
Registered User
Posts: 35
Joined: Fri Feb 10, 2017 8:16 am
Contact:

Re: Notification

by rxu » Sat Jan 27, 2018 5:41 pm

What is the use scenario?
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Notification

by scheccia » Sat Jan 27, 2018 6:57 pm

Standard scenario...
I reply ... After, i quote a user's message and re-reply, the plugin merge my 2 messages but the user don't receive the notification of quoted message
scheccia
Registered User
Posts: 35
Joined: Fri Feb 10, 2017 8:16 am
Contact:

Re: Notification

by rxu » Sun Jan 28, 2018 6:11 am

That is a bug indeed, thanks for reporting. You could try the following fix:
https://github.com/rxu/posts_merging/co ... 89de97e98a
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Notification

by scheccia » Sun Jan 28, 2018 9:04 am

Perfect, works 👍
scheccia
Registered User
Posts: 35
Joined: Fri Feb 10, 2017 8:16 am
Contact:

Re: Notification

by jackennils » Sat Aug 18, 2018 8:10 pm

Does not work for me. :(
User avatar
jackennils
Registered User
Posts: 201
Joined: Mon Jun 01, 2009 7:48 pm
Contact:

Re: Notification

by rxu » Sun Aug 19, 2018 4:24 am

Too few information. What exactly are you doing and what doesn't work?
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Notification

by jackennils » Sun Aug 19, 2018 10:42 am

Well, I've updated to the latest version from GitHub, but there is no notification for being quoted in a merged post, as described above by scheccia. So the bug is not resolved in my case.
User avatar
jackennils
Registered User
Posts: 201
Joined: Mon Jun 01, 2009 7:48 pm
Contact:

Re: Notification

by rxu » Sun Aug 19, 2018 1:07 pm

The fix is here https://github.com/rxu/posts_merging/co ... 89de97e98a and you need to apply it by hands to make it work, or copy the file contents from the source to the server.
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Notification

by jackennils » Sun Aug 19, 2018 1:39 pm

That's exactly what I did. But it is not working.

Here's a screen of the file from my server:
https://i.imgur.com/qfuFbjy.png
User avatar
jackennils
Registered User
Posts: 201
Joined: Mon Jun 01, 2009 7:48 pm
Contact:

Re: Notification

by rxu » Sun Aug 19, 2018 2:14 pm

How did you test it exactly? Does the 1st part already have the user quoted already?
Again, you're giving too few information. It's impossible for me to guess what happens on your side.
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Notification

by jackennils » Sun Aug 19, 2018 5:48 pm

I wrote a post. No quote, nothing. Just text. Then I wrote a second post shortly after. The second one included a quote. The posts were merged together. I logged out and logged in as the quoted user. But I had no notification.
User avatar
jackennils
Registered User
Posts: 201
Joined: Mon Jun 01, 2009 7:48 pm
Contact:

Re: Notification

by rxu » Sun Aug 19, 2018 6:11 pm

Tested again right now and it worked for me.
Are you sure the user quoted has the quote notifications enabled in UCP?
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: Notification

by jackennils » Sun Aug 19, 2018 6:32 pm

Okay, I now got it working. I disabled the extension, deleted all data and re-enabled it. But that's what I did yesterday as well.
Thanks for the help!

Another quick question regarding the notifications: Can you add support for Paul's SimpleMentions Ext?

I've seen this part of the code:

Code: Select all

			$this->notification_manager->add_notifications(array(
				'notification.type.quote',
				'notification.type.bookmark',
				'notification.type.post',
			), $notification_data);
Simply adding the notification type:

Code: Select all

paul999.mention.notification.type.mention
Results in this:

Code: Select all

[phpBB Debug] PHP Warning: in file [ROOT]/ext/paul999/mention/notification/type/mention.php on line 115: Invalid argument supplied for foreach()
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 1836: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3268)
User avatar
jackennils
Registered User
Posts: 201
Joined: Mon Jun 01, 2009 7:48 pm
Contact:

Re: Notification

by rxu » Mon Aug 20, 2018 4:45 pm

How did you add it exactly?it should be like that

Code: Select all

			$this->notification_manager->add_notifications(array(
				'notification.type.quote',
				'notification.type.bookmark',
				'notification.type.post',
				'paul999.mention.notification.type.mention',
			), $notification_data);
rxu
Extensions Development Team
Posts: 2924
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact: