QuickReply Reloaded

Quickreply Reloaded compatibility fix (with ThanksForPosts) - QuickReply Reloaded

Quickreply Reloaded compatibility fix (with ThanksForPosts)

by BioLogIn » Sun Sep 25, 2016 11:42 am

Hey

The 1.1.0-b1 version has a small issue. If there is a ThanksForPosts extension (viewtopic.php?f=456&t=2259046) also installed, the QR script also adds popup menu to all usernames that are listed in the thanks for the post list.

I felt that only the name of the post author should have this popup menu, so I have fixed this by adding more specific condition to profile link selector description in quickreply_init.html:

Code: Select all

   profileLinkSelector: 'dl.postprofile dt a.username, dl.postprofile dt a.username-coloured',
BioLogIn
Registered User
Posts: 172
Joined: Sun Jan 06, 2008 10:51 am
Contact:

Re: Quickreply Reloaded compatibility fix (with ThanksForPos

by LavIgor » Sun Sep 25, 2016 11:54 am

BioLogIn, thank you for your response.
I also have that extension installed, but I consider the described behaviour a bonus feature, not a bug.
Thanks For Posts is not the only extension with such behaviour BTW.

You can always disable that dropdown in the ACP settings and use a separate QuickNick link instead.
LavIgor
Registered User
Posts: 541
Joined: Mon Apr 28, 2014 1:47 pm

Re: Quickreply Reloaded compatibility fix (with ThanksForPos

by BioLogIn » Sat Nov 04, 2017 4:38 pm

LavIgor, thank you for working on the extension, really it is a very nice one.

For the record, on phpbb 3.2.1 with quickreply reloaded 2.0.0-beta the situation is a bit worse - not only there is a popup on users who gave their their thanks (this can be considered a feature, as LavIgor mentioned), but also in the popup links "view profile" and "send PM" lead to the post owner, not to the user who thanked for the post.

The fix from my post above still works, though.
BioLogIn
Registered User
Posts: 172
Joined: Sun Jan 06, 2008 10:51 am
Contact:

Re: Quickreply Reloaded compatibility fix (with ThanksForPos

by LavIgor » Tue Nov 07, 2017 6:52 am

BioLogIn wrote:but also in the popup links "view profile" and "send PM" lead to the post owner, not to the user who thanked for the post.
Hmm... "View profile" link works OK for me and leads to thanker's profile.
However, "Reply in PM" works for post author and that is a bug indeed.
Thank you.
LavIgor
Registered User
Posts: 541
Joined: Mon Apr 28, 2014 1:47 pm