Simple mentions

Mention doesn't render in message - Simple mentions

Mention doesn't render in message

by koraldon » Wed Apr 18, 2018 12:48 pm

I see the mentioned users on the topic preview prior to sending, but once I send I just get

Code: Select all

[mention]The oldman[/mention]
and it doesn't render, nor does it send a notificatoin. Using 3.2.3.RC1 with latte style
Cache has been cleared.

Edit: found problem, conflict with the dice roller extension viewtopic.php?f=496&t=2419181
koraldon
Registered User
Posts: 483
Joined: Sat Jun 30, 2007 12:42 pm
Contact:

Re: Mention doesn't render in message

by Paul » Fri Apr 20, 2018 7:33 am

Please provide your board URL + test account.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development
User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24715
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Mention doesn't render in message

by Paul » Fri Apr 20, 2018 8:06 am

Can you provide the download of the dice extension you are using?
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development
User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24715
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Mention doesn't render in message

by koraldon » Fri Apr 20, 2018 4:25 pm

koraldon
Registered User
Posts: 483
Joined: Sat Jun 30, 2007 12:42 pm
Contact:

Re: Mention doesn't render in message

by koraldon » Wed Apr 25, 2018 6:12 pm

Hi Paul,
Did you have a chance to look into it?
Thanks.
koraldon
Registered User
Posts: 483
Joined: Sat Jun 30, 2007 12:42 pm
Contact:

Re: Mention doesn't render in message

by Paul » Wed Apr 25, 2018 6:16 pm

No, not yet.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development
User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24715
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Mention doesn't render in message

by koraldon » Thu May 03, 2018 6:01 pm

One of of my users who is a programmer suggested the following fix, which seems to be working.
File: /events/main_listener.php
Line 269
Modify to
if ($this->user->page['page_name'] != 'posting.' . $this->php_ext && $this->user->page['page_name'] != 'viewtopic.' . $this->php_ext)

Seemed to solve the issue. We didn't see any adverse impact. Would be great to hear your thoughts on this fix.
koraldon
Registered User
Posts: 483
Joined: Sat Jun 30, 2007 12:42 pm
Contact:

Re: Mention doesn't render in message

by koraldon » Fri May 11, 2018 6:34 pm

In addition, line 264 was changed to
if (!$this->auth->acl_get('u_can_mention') && $this->user->page['page_name'] != 'viewtopic.' . $this->php_ext)
due to an issue with guests
Also, there seems to be a spelling mistake at line 885, that shows $bbode_uid instead of $bbcode_uid
koraldon
Registered User
Posts: 483
Joined: Sat Jun 30, 2007 12:42 pm
Contact: