Simple mentions

thank you - Simple mentions

Re: thank you

by php_BB_Lover » Tue Jul 07, 2020 9:23 am

klingklang wrote:Ok, I've found a better way (or, at least, I think it is: maybe Paul could comment on this), which fixes the security breach and kind of mitigates the nickname change issue. Here's the fix:
thank you very much. it worked perfectly!
i dont know why i lost notification. now i dont get notification from mentioning.
would you please test yours and see if notification works
thanks
Version: phpBB 3.3.0
Theme: default
Regards
php_BB_Lover
I've Been Banned!
Posts: 352
Joined: Tue Jun 23, 2020 5:18 am
Contact:

Re: thank you

by klingklang » Tue Jul 07, 2020 9:55 am

php_BB_Lover wrote: i dont know why i lost notification. now i dont get notification from mentioning.
I hadn't noticed :? This is most probably because the syntax of the BBCode has changed, and doesn't trigger the notification anymore. I'll try to play a little more with this, but don't hold your breath since I'm no coder at all... :roll:
klingklang
Registered User
Posts: 12
Joined: Wed Jul 01, 2020 8:45 am
Contact:

Re: thank you

by klingklang » Tue Jul 07, 2020 10:03 am

Well, it could be worse... but watch out for the next bug! :lol:

In /ext/paul999/mention/event/main_listener.php, line 34, you have:

Code: Select all

private $regex = '#\[mention\]<\/s>(.*?)<e>\[\/mention\]#';
try and replace it with

Code: Select all

private $regex = '#\[mention=\d*\]<\/s>(.*?)<e>\[\/mention\]#';
klingklang
Registered User
Posts: 12
Joined: Wed Jul 01, 2020 8:45 am
Contact:

Re: thank you

by php_BB_Lover » Wed Jul 08, 2020 12:17 am

klingklang wrote: I hadn't noticed :? This is most probably because the syntax of the BBCode has changed, and doesn't trigger the notification anymore. I'll try to play a little more with this, but don't hold your breath since I'm no coder at all... :roll:
you are the best coder! thank you very much
Last edited by php_BB_Lover on Wed Jul 08, 2020 4:13 am
Version: phpBB 3.3.0
Theme: default
Regards
php_BB_Lover
I've Been Banned!
Posts: 352
Joined: Tue Jun 23, 2020 5:18 am
Contact:

Re: thank you

by php_BB_Lover » Wed Jul 08, 2020 12:22 am

klingklang wrote:Well, it could be worse... but watch out for the next bug! :lol:

Code: Select all

private $regex = '#\[mention=\d*\]<\/s>(.*?)<e>\[\/mention\]#';
thank you very much. it worked.
please reply to this post if you get any other errors or other info! and i will do the same.
and also if you get answer to this question please reply too: [how to fix this to send mention notification when editing posts too.]
thank you,
Version: phpBB 3.3.0
Theme: default
Regards
php_BB_Lover
I've Been Banned!
Posts: 352
Joined: Tue Jun 23, 2020 5:18 am
Contact:

Re: thank you

by klingklang » Wed Aug 26, 2020 8:39 am

My "hack" has worked fine so far. After updating the board to 3.3.1, though, all my mentions were broken and needed reparsing (and since I don't have SSH access i have to edit/submit each message :? ). I know I can't ask for support on a self-made modification, but if you just had a quick advice on how to avoid this I'd be really grateful :)
klingklang
Registered User
Posts: 12
Joined: Wed Jul 01, 2020 8:45 am
Contact:

Re: thank you

by papclems » Sat Dec 05, 2020 9:48 am

I would thank you for this extension.
Fantastic.
It works fine also with the last upgrade.

I've a question, it seems that some categories of users cannot use the mention.
it depends on a permission i've set in the user permission?
papclems
Registered User
Posts: 28
Joined: Tue Sep 12, 2017 2:07 pm
Contact: