Topic Preview

problem when no avatar - Topic Preview

problem when no avatar

by yasser33311 » Fri Jan 30, 2015 7:28 pm

PhpBB Services - install, update, upgrade, customize: PM
User avatar
yasser33311
Registered User
Posts: 277
Joined: Sat Jul 27, 2013 1:27 pm
Location: algeria
Name: yasser ghe

Re: problem when no avatar

by MattF » Fri Jan 30, 2015 8:54 pm

That problem is with your style. It is missing the default no avatar image that comes with phpBB. Your style needs to be updated to include all the images that prosilver ships with to be compatible with extensions.

As you can see, your board in prosilver does not have this issue:
http://tajribaty.com/bem/viewforum.php?f=8&style=1

You should let the author of that style know they are not releasing a compatible style there.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: problem when no avatar

by MattF » Fri Jan 30, 2015 9:05 pm

See post here: viewtopic.php?f=476&t=2269886&p=13924526#p13924526

Note: Also that style is currently un-validated, and should not be used on a live board anyways.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: problem when no avatar

by yasser33311 » Fri Jan 30, 2015 9:37 pm

ok, thank you
PhpBB Services - install, update, upgrade, customize: PM
User avatar
yasser33311
Registered User
Posts: 277
Joined: Sat Jul 27, 2013 1:27 pm
Location: algeria
Name: yasser ghe

Default avatar missing

by aduh » Wed Apr 22, 2015 12:30 pm

Default avatar is not working on Topic Preview:
Image
User avatar
aduh
Registered User
Posts: 215
Joined: Thu Jul 05, 2012 7:29 pm
Location: Poland
Name: Hans'

Re: Default avatar missing

by MattF » Wed Apr 22, 2015 3:01 pm

That's a user with a broken avatar link. Default avatars are for users with no avatars.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: Default avatar missing

by aduh » Wed Apr 22, 2015 3:24 pm

Image
Its default avatar - same for every new member on forum.
This avatar just dont work on Topc Preview :(
User avatar
aduh
Registered User
Posts: 215
Joined: Thu Jul 05, 2012 7:29 pm
Location: Poland
Name: Hans'

Re: Default avatar missing

by MattF » Wed Apr 22, 2015 3:35 pm

You can clearly see in that picture that the user has a broken image. I do not know what that question mark image is in your picture. That is not phpBB's standard no avatar image. You are using a custom style that has some sort of its own no avatar image and your style has broken it.

You need to add phpBB's default no avatar image to that style you are using, in the images folder.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: Default avatar missing

by aduh » Wed Apr 22, 2015 3:47 pm

OK Iv got it. Style is using no_avatar.png Just converted it to .gif, upload and now its ok :)
http://www.2012apocalypse.pl/viewforum.php?f=7
Thank you for help.
User avatar
aduh
Registered User
Posts: 215
Joined: Thu Jul 05, 2012 7:29 pm
Location: Poland
Name: Hans'

Re: Default avatar missing

by MattF » Wed Apr 22, 2015 3:50 pm

aduh wrote:OK Iv got it. Style is using no_avatar.png Just converted it to .gif, upload and now its ok :)
http://www.2012apocalypse.pl/viewforum.php?f=7
Thank you for help.


You should notify the style author that they should be keeping prosilver image content, because replacing stuff as they did by switching from gif to png as they did here leads to these kinds of problems.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: Default avatar missing

by aduh » Wed Apr 22, 2015 3:54 pm

OK I will let him know on his style thread. Thanks
User avatar
aduh
Registered User
Posts: 215
Joined: Thu Jul 05, 2012 7:29 pm
Location: Poland
Name: Hans'

Re: problem when no avatar

by Arty » Tue Aug 04, 2015 2:32 pm

I've been directed to this topic because same issue happens with other styles as well. This extension's approach doesn't work with any style that isn't basic modification of prosilver.
VSE wrote:Your style needs to be updated to include all the images that prosilver ships with to be compatible with extensions.

It doesn't. Extension should not assume that specific image exists in style, it should supply its own images for its code or rely on css from style.

Since no_avatar.gif is not in prosilver's css (might be a good idea to move it to css in phpbb-dev to make extension writer's life easier?), you should supply your own image.
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework
User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin

Re: problem when no avatar

by MattF » Tue Aug 04, 2015 3:05 pm

Arty wrote:I've been directed to this topic because same issue happens with other styles as well. This extension's approach doesn't work with any style that isn't basic modification of prosilver.
VSE wrote:Your style needs to be updated to include all the images that prosilver ships with to be compatible with extensions.

It doesn't. Extension should not assume that specific image exists in style, it should supply its own images for its code or rely on css from style.

Since no_avatar.gif is not in prosilver's css (might be a good idea to move it to css in phpbb-dev to make extension writer's life easier?), you should supply your own image.

As you know, though, extensions are only required to work with Prosilver.

So, as I further mentioned above, the user just needs to add the no_avatar.gif to a style that has omitted it. Some have omitted it for reasons I can not comprehend, and in your styles you (rightfully) switched to PNG.

FWIW, I have made a purely CSS no avatar to hopefully one day use instead. http://codepen.io/anon/pen/ZGQzKM
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: problem when no avatar

by Arty » Tue Aug 04, 2015 3:26 pm

That's brilliant! Add it to 3.2 :)
Vjacheslav Trushkin / Arty.
Free phpBB 3.1 styles | New project: Iconify - modern SVG framework
User avatar
Arty
Former Team Member
Posts: 16654
Joined: Wed Mar 06, 2002 2:36 pm
Name: Vjacheslav Trushkin

Re: problem when no avatar

by MattF » Tue Aug 04, 2015 3:36 pm

Arty wrote:That's brilliant! Add it to 3.2 :)

I am planning to.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 6037
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman