Upload Extensions

Working on 3.3.x - Upload Extensions

Working on 3.3.x

by dmzx » Fri Jan 10, 2025 12:14 pm

Contact me on dmzx-web.net
User avatar
dmzx
Registered User
Posts: 858
Joined: Fri Sep 05, 2014 6:48 am
Location: The Netherlands

Re: Working on 3.3.x

by RMcGirr83 » Sat Jan 11, 2025 2:58 am

:roll:

Most of the commits are nothing more than spacing changes.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22092
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Working on 3.3.x

by dmzx » Sat Jan 11, 2025 9:36 am

Look closer ;)
Contact me on dmzx-web.net
User avatar
dmzx
Registered User
Posts: 858
Joined: Fri Sep 05, 2014 6:48 am
Location: The Netherlands

Re: Working on 3.3.x

by RMcGirr83 » Sat Jan 11, 2025 11:32 am

I said "Most" not all
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22092
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Working on 3.3.x

by RMcGirr83 » Sat Jan 11, 2025 11:10 pm

This

https://github.com/BoardTools/upload/pu ... b8d672R218

Is a definite no no and are you really asking users of this extension to complete all the commits you made in order to use cURL instead of providing a zip download within your fork? LOL good luck with that.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22092
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Working on 3.3.x

by dmzx » Sun Jan 12, 2025 6:42 am

RMcGirr83 wrote: Is a definite no no and are you really asking users of this extension to complete all the commits you made in order to use cURL instead of providing a zip download within your fork? LOL good luck with that.
If 2 simple clicks are to much to get to the download here is 1 for you Download
I ask nothing from users just provide a solution, instead of moaning about commits...
Last edited by dmzx on Mon Jan 13, 2025 10:02 am
Contact me on dmzx-web.net
User avatar
dmzx
Registered User
Posts: 858
Joined: Fri Sep 05, 2014 6:48 am
Location: The Netherlands

Re: Working on 3.3.x

by RMcGirr83 » Sun Jan 12, 2025 11:51 am

At least you removed the security issue. Good luck!
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22092
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Working on 3.3.x

by dmzx » Sun Jan 12, 2025 6:25 pm

RMcGirr83 wrote:
At least you removed the security issue. Good luck!
At least I contributed something, what did you do?
If you have the solution provide it.... 👌
Contact me on dmzx-web.net
User avatar
dmzx
Registered User
Posts: 858
Joined: Fri Sep 05, 2014 6:48 am
Location: The Netherlands

Re: Working on 3.3.x

by Tread » Mon Jan 13, 2025 1:49 am

:lol:
Tread
Registered User
Posts: 108
Joined: Thu Nov 14, 2019 9:52 pm

Re: Working on 3.3.x

by RMcGirr83 » Mon Jan 13, 2025 10:36 am

dmzx wrote: At least I contributed something, what did you do?
Not much at all :roll:
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22092
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Working on 3.3.x

by dmzx » Mon Jan 13, 2025 7:05 pm

RMcGirr83 wrote:
dmzx wrote: At least I contributed something, what did you do?
Not much at all :roll:

Don't see Upload Extension there
Contact me on dmzx-web.net
User avatar
dmzx
Registered User
Posts: 858
Joined: Fri Sep 05, 2014 6:48 am
Location: The Netherlands

Re: Working on 3.3.x

by Steve » Mon Jan 13, 2025 7:36 pm

RMcGirr83 wrote:
At least you removed the security issue. Good luck!
If the extension is subject to exploit, can it be reported to phpbb? To be removed?
@ The Chief Medical Officers guideline for men is that: You are safest not to drink regularly more than 14 units per week.
- I drank that today++ :lol: 🍺
User avatar
Steve
Registered User
Posts: 1598
Joined: Tue Apr 07, 2009 7:48 pm
Location: Co. Durham, England
Name: Steven Clark

Re: Working on 3.3.x

by RMcGirr83 » Tue Jan 14, 2025 11:56 am

dmzx introduced the security issue with the commits he made in his push. To answer your question yes, the team will remove the download link if an extension has a security exploit. Doubt they would for a push commit on a github repo. That repo, and this extension, is probably dead in the water. Last commit was 5 years ago.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
User avatar
RMcGirr83
Former Team Member
Posts: 22092
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr