Warning: The author of this contribution does not provide support for it anymore.

Advanced Double Activation Pack

Incorrect Auto-Pruning of Users? - Advanced Double Activation Pack

Incorrect Auto-Pruning of Users?

by Cory Ander » Wed Sep 18, 2013 1:15 am

Hi Martin,

I've been using your MOD, for several months now. Generally, it is working well and I am happy with it (thanks for your efforts :) )

However, I am a little concerned that it seems to be auto-pruning users when, it seems, to me, that it shouldn't. Unless I'm missing something or am doing something stupid!? :P

I have set "prune lost users" to "user hasn't logged on for 1 month" and "exclude users who have at least 1 post"

Similarly, I have set "prune users which are lazy posters" to "user hasn't posted for 2 months" and "exclude users who have at least 1 post"

If my understanding it correct, it seems to me that any user who has made 1 post (or more) should be excluded from auto-pruning? This doesn't seem to be the case. Users who have made 1 post are being auto-pruned.

Is this a bug? Or is my understanding incorrect?

If my understanding is incorrect, what should the settings be to ensure than anyone who has made 1 post (or more) is not auto-pruned?

Thanks for you assistance 8-)
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Wed Sep 18, 2013 6:48 pm

Hello Croy Ander,
have the pruned user accounts been fully and well activated?
If not, other settings have pruned them.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Thu Sep 19, 2013 2:03 am

Hi Martin,

Thanks for your swift reply.

As far as I am aware, all these pruned users (i.e. the users with 1 post or less) are fully activated. They are not "inactive users". They are members of the "Newly Registered Users" group (until they have made 2 or more posts). How do I otherwise check that they are "fully and well activated" please?

As far as I'm aware, there is nothing else enabled on the board which automatically deletes user accounts. I cannot think of anything else that would be deleting them? The Admin log also says "deleted user by auto user pruning".

To ask a silly question, does "have at least 1 post" actually mean "have more than 1 post? I presume that it means "have one or more post"?

Thanks for your help.
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Thu Sep 19, 2013 10:18 am

Hello Cory Ander,
activated/deactivated means the user account has not been activated: e-mail address has not been confirmed, user admins haven't actvated the user account or user admins deactivated the account
On ACP User verify page ypu will see "User is active" for activated user accounts.
It's the prune setting "Prune deactivated users".

Active/Inactive has several meanings:
1. User never has been logged in. Prune setting: "Prune users which never have been active"
2. User haven't been logged in for a long time. Prune setting: "Prune lost users"

"Prune users which are lazy posters" is a hard core setting for very hard and strong webmasters. I've added it just to a complete solution.

IMO "Newly Registered Users" group is a nonsense feature. I never tested it together with ADAP.

At least means at least.

IMO ADAP comes with very usefull default settings for Auto user pruning.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Thu Sep 19, 2013 12:37 pm

Hi Martin,

Thanks for your quick response again 8-)

As far as I'm a aware, all members have been appropriately activated (either by email address and/or by admin).

I'm not sure what you mean by "On ACP User verify page ypu will see "User is active" for activated user accounts. It's the prune setting "Prune deactivated users"."

I see nothing, anywhere, that tells me whether or not a user account is "activated" or not? I can only see something that tells me that a user is inactive (i.e. on the Admin "General" or "Inactive Users" tab). And there are none.

Either way, it seems that something is not quite working, as it should work, because it is deleting accounts of users who have made 1 post (and I have set it to exclude users who have made at least 1 post)?

So, unless you're able to help me further, I'm not too sure how to reconcile the problem? :?
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Thu Sep 19, 2013 1:29 pm

Hello Cory Ander,
go to ACP -> Select one user for user management -> Go to User verify page -> look for "User is active". If it's displayed then the user account is fully activated.

If done a look to the code. You're right the one post thing is not working like explained. Set the value to 0 insteat of 1 for a workaround.
Or for fixing it really open cron.php
[FIND]

Code: Select all

            $sql_posts = ' AND user_posts <= ' . (intval($config['user_prune_lost_posts']));

Replcae <= with <
The same for the line

Code: Select all

            $sql_posts = ' AND user_posts <= ' . (intval($config['user_prune_zero_posts']));


The bug full be fixed in the next release of the MOD.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Fri Sep 20, 2013 12:21 am

Ah, thanks for looking into it Martin.

I'll change the code to be "less than" rather than "less than or equal to"

Thanks for your help, I appreciate it 8-)

PS: If I do that, I presume that you are confident that it will work (without it creating other problems)?
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Fri Sep 20, 2013 11:00 pm

Hi Martin,

I've got a serious problem with auto-pruning now :(

I set the value to "0" instead of "1" as you suggested (I haven't changed the code).

However, last night, it auto-pruned a number of members who have made quite a number of posts (i.e. 1 and more) but who otherwise have not posted for a while.

I've disabled auto-pruning until I can get to the bottom of it.

Please help! :shock:

PS: To recover those members, do I just restore the database backup that I made in the ACP?
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Sat Sep 21, 2013 12:19 am

Hello,
it seems that you have enabled pruning for lazy posters, too? It's not the default setting.

Restoreing the database replaces all data at the database. Newer Topics and posts will be lost.

I gave two alternative ways:
One was a workaround.
The other one was a fix.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Sat Sep 21, 2013 12:34 am

Hi Martin,

Yes, I have enabled pruning for lazy posters too. I presumed it was safe to do so. It is (supposedly) set to exclude members who have made 1 or more posts.

I have implemented your "work around" (as discussed above - setting "0" instead of "1") and it clearly doesn't work. It is deleting members who have made 1 or more posts (in some case, significantly more than 1 post). So something is seriously wrong.

I would like to resolve the issue because I like what your MOD is supposed to do.
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Sat Sep 21, 2013 12:39 am

Hello Cory Ander,
please post a screenshot of your prune settings.

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Sat Sep 21, 2013 2:59 am

Hi Martin,

These were the most recent settings (after implementing your "work around") when members with significantly more than 1 post were deleted (apart from "Time period for auto user pruning" which I have since set to zero to disable it):

Autoprune.jpg
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Sat Sep 21, 2013 9:29 am

Hi Cory Ander,
deactivate lazy Posters and give much more months for lost users. IMO 12 or 24 months are usefull values.
Don't forget that a lot of people don't log in every time they visit a forum. Not all user's are using a the cookie based auto-login.

I think you've got the problems by changing the default values.

The one post issue is not really the problem.

Bye Martin
Last edited by Martin Truckenbrodt on Sat Sep 21, 2013 9:52 am
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: Incorrect Auto-Pruning of Users?

by Cory Ander » Sat Sep 21, 2013 9:41 am

Hi Martin,

Surely that's just saying that the MOD doesn't work for values other than the default values (which I find hard to understand since surely it just runs on logic statements?) and that pruning of "lazy posters" doesn't actually work?

There must be reasons for it not working correctly? Either with the logic statements, with some inconsistency with the various features of the MOD, or with a conflict between the MOD and the basic features of phpbb3 (I thought it was an officially approved MOD)?

I guess that, if we can't reconcile the problems, then I need to deactivate it or uninstall it. As it stands, I can't trust it to work properly, which is a shame. I'm very disappointed with that :(
Cory Ander
Registered User
Posts: 65
Joined: Thu Mar 21, 2013 1:31 am
Contact:

Re: Incorrect Auto-Pruning of Users?

by Martin Truckenbrodt » Sat Sep 21, 2013 9:51 am

Hello Cory Ander,
why you have changed the default values?
On the header of the ACP page there is a red marked advice to be very carefully.

The MOD is running well. The one post issue you've found is just a small issue.
The included features are working well together.
ADAP is a very old MOD with a lot of downloads. I don't know any other issues.

Maybe there is a compatibility issue with other MODs?

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact: