Warning: The author of this contribution does not provide support for it anymore.

Moderator Needed

Incorrectly calculated posts on approval in PHPBB 3.0.9 - Moderator Needed

Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Tue Jul 12, 2011 1:55 pm

today noticed a bug (after upgrading to 3.0.9??)

If the moderation have been reports from users of the "New Members" and their messages in a queue for moderation are not counted.

observed when the two messages waiting for approval (by the group "New Members") - did not notice.

tried to create a message from the user group "Registered Users" in a moderated forum - will receive the notification that a message in the queue for approval.

tried to create a new user complaints, posts, topics.

complaint and the topics is calculated correctly (as if).

Post moderation is calculated not correctly:

Image

the picture shows that you are notified about 3 messages, pending approval
in fact, in a queue for approval are 4 posts.

please help. very good and useful mod.

sorry for my english
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by Oyabun1 » Tue Jul 12, 2011 2:14 pm

Wait a while and see if the numbers are different. From memory the results are cached, I think for 5 minutes, to reduce load on the board.
                      Support Request Template
3.0.x: Knowledge Base Styles Support MOD Requests
3.1.x: Knowledge BaseStyles SupportExtension Requests
User avatar
Oyabun1
Former Team Member
Posts: 23162
Joined: Sun May 17, 2009 1:05 pm
Location: Australia
Name: Bill

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Tue Jul 12, 2011 2:17 pm

I noticed it.
waited for about 20-30 minutes.

before that, in moderation were two messages from the new user (about 15-20 minutes) - no notice.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by RMcGirr83 » Tue Jul 12, 2011 2:47 pm

Results of new/reported topics/posts is not cached, PM's are.

I can not reproduce this error on a 3.0.9 forum.
Appreciate the extensions/mods/support then buy me a beerImage
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21292
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Tue Jul 12, 2011 3:21 pm

just tried - I do the same thing, a notice appears at once.
I do not understand!

3.0.9 set only yesterday - look for a few days.

Perhaps the problem will not recur.
It may be possible to detect the sequence of actions to repeat it.

Thank you for your prompt response.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 12:57 am

The same problem.

1 message expects moderated.

Image

Image

Post created yesterday at 21:40 by new user:
He is in the group NEW MEMBERS, it is his default group.
and a group of authorized users.
He wrote only two messages.

Viewed today at 3:50 - no notification.
was more than 5 hours
so the problem is not in cache.

All problems were fixed by the same users:
group NEW MEMBERS - default group
and a group of AUTHORIZED USERS.
They wrote 3 or less messages.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 1:30 am

Able to reproduce the bug!

With all of the above conditions, if the message is placed in the forum topic - everything is OK.

but if the new user writes in a theme, raised above the forums as IMPORTANT NOTICE - no notification.
stickies - not tested.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by RMcGirr83 » Wed Jul 13, 2011 2:35 am

What is a "theme"..do you mean global announcement?
Appreciate the extensions/mods/support then buy me a beerImage
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21292
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 2:45 am

YES, global announcement
it's my error of translation from Russian into English
VIEW_TOPIC_GLOBAL in Language fle
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 3:08 am

just in case I will specify:
NEW USERS group has no rights to post messages directly to topics.
all their messages are first checked by a moderator.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by RMcGirr83 » Wed Jul 13, 2011 3:43 am

The making of a post within a global announcement was handled in a previous version. As I said I can't reproduce what it is you are experiencing. Please ensure you have the latest files and edits to your files per the mod download instructions.

Also, I am not sure what this means

NEW USERS group has no rights to post messages directly to topics.


Any time a new user makes a post into a topic, it is still placed in the topic just normal users can't see it until it is approved by a moderator.

Feel free to test it on my forum if you like http://www.rmcgirr83.org
Appreciate the extensions/mods/support then buy me a beerImage
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21292
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 3:56 am

installed Moderator needed version 1.0.4 from here viewtopic.php?f=69&t=1214805&start=0

after updating the forum from 3.0.8 to 3.0.9 checked and rechecked installation of mod several times - no errors.
maybe I'm not using the latest versions?

(((((((((((((
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 4:18 am

looked at how a SQL-query moderator_needed.php

always (?) message is chosen for the forum.

in the new versions phpbb3 (can not remember for what, may be from 3.0.7) newly registered users by default are in the groups NEW MEMBERS and REGISTERED USERS.

Group NEW MEMBERS has a restrictions on rights: ALL posts are published after being moderated.

After writing a certain number of posts a user is automatically excluded from the group of new users.

I think the problem might be that global announcements not posted in any forum, messages are simply not chosen by the SQL-query.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact:

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by RMcGirr83 » Wed Jul 13, 2011 10:26 am

Do me a favor and try this one there are instructions in the contrib folder to replace 1.0.4 with 1.0.5 which is going to be the latest version.
Appreciate the extensions/mods/support then buy me a beerImage
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21292
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Incorrectly calculated posts on approval in PHPBB 3.0.9

by FomenkoAndrey » Wed Jul 13, 2011 10:44 am

checked 1.0.5 - works fine.
Thank you very much for this wonderful mod!
I watched a few more days to finally confirm the lack of bugs.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am
Contact: