phpBB • Free and Open Source Forum Software

Hi Mark,

It took me a little while to believe this report from my client but having thoroughly tested it this morning, they are right.

For some reason, when the Digest is going out it's not including all of the posts that it should.

I have a copy of the Digest for a particular user, which clearly has posts missing from it - ie. Digest was sent at 4pm and is missing a number of posts from during the day that have been made well before 4pm.

These posts have also not turned up in the next day's Digest.

I've obtained their user details and logged in as them and verified that their Digests setting are correct - set to receive all posts from all forums, including their own... and I've also verified that they have permission to view these forums/posts.

So do you have any ideas why it might be skipping some posts?

Would updating to 2.2.7 help with this in any way?

Regards

Nathan

There are a lot of filters built into the digests software. The most likely cause is that the user visited the forum and this reset the last visit date. Digests can be configured to ignore posts before the last visit date. This feature can be turned off in the digests UCP interface, under post filters by setting "Show new posts only" to No.

Hi Mark,

Unfortunately in this case "Show new posts only" is already set to No and "Reset my last visit date when I am sent a digest" under Additional Criteria is also set to No.

This isn't just being reported by one user but a number who rely on the Digest daily and additionally, as I noted in another post, the Digests weren't working at all for quite some time until I updated to 2.2.26 and this problem wasn't happening before... we've been running the Digests for about 5 years.

I'd be happy to email you the user account and an example Digest with an explanation of what's missing via email so you can log in and have a look? Also happy to pay you for your time if required - client is driving me mad with it.

Thanks

Nathan

What digest settings show in the footer of the digests that the user receives?

There are lots of ways posts can be filtered out.

- New posts only (note: this didn't work in 2.2.26 but was fixed in 2.2.27 if you upgraded)
- User subscribed to only certain forums
- User selected bookmarked posts only
- User selected first posts of new topics only
- Maximum number of posts in a digest is set (note: this didn't work in 2.2.26 but was fixed in 2.2.27 if you upgraded)
- Minimum number of words for a post to appear in a digest is set
- You ask to remove your own posts
- You ask to remove your foes posts
- You ask that a digest not be sent if there are no new posts

I'm pretty familiar with the array of filters - the client has in the past had me set everyone's filters to certain defaults by running a query through phpMyAdmin and the vast majority of users have the same settings.

The one's at the bottom of the Digest for this user are:

coastcelebrant's digest options:
Basics Options:

Digest Frequency: Daily
Digest Format: HTML
Hour sent: 4 pm
Forums Selection Options:

Types of posts in digest: All posts
Post Filters Options:

Maximum number of posts in the digest: No limit
Minimum words required in post for the post to appear in a digest: No constraint
Show new posts only: No
Remove my posts: No
Remove posts from my foes: No
Show my private messages: Yes
Additional Criteria Options:

Post sort order: Traditional Order
Maximum words to display in a post: Show no post text at all
Send digest if no new messages: No
Reset my last visit date when I am sent a digest: No
Show attachments: Yes
Block images: No
Table of contents: No

The only thing that looks odd is the show no post text at all. But this is not a filtering criteria, simply changes the form of the output.

One other point: users should only see posts in forums for which they have read and list privileges. If the user sees the post when they go to the board then this is not the issue.

Otherwise posts should include all posts from 24 hours before when the digest is sent, at 4 PM based on the time zone in the user's profile.

That's about all the advice I can give. Anything further would require me to do debugging on your server, something I'd be willing to do for a troubleshooting fee. You can contact me if that's an option. Should I discover a bug I'll post it here.

One other possibility. Check your ACP Digest settings. Make sure Maximum posts allowed in any digest is set to zero. In version 2.2.26 this was ignored in constraining the number of digests, now it is enforced.

Before it was:



now it is:



and the $max_posts variable is passed to the create_content function which assembles the bulk of the digest. When this limit is hit, the digest will include no further posts.

In addition in the ACP digest setting make sure you are not excluding any forums from appearing in digests.

I do see a bug in the above code. Line 488 in mail_digests.php, version 2.2.27 is:



and should be:

Just to be clear, administrators can force posts to be removed from digests too in the ACP interface by:

- Setting a limit on the maximum number of posts in a digest
- Excluding certain forums from all digests

These are all features that were requested over the years.

Just to address your suggestions...

1. I haven't as yet updated to 2.2.7.

2. Yes the person I am using as an example has the correct permissions for read and list privileges, they are able to view the forum posts normally.

2. In the ACP Digests settings I haven't changed the "Maximum posts allowed in any digest" so it is set to zero.

3. No forums have been excluded from the Digest.

As I said I'm happy to pay for you to troubleshoot it as it's doing my head in and I have run out of things to check.

But should I first update to 2.2.7 and apply that fix you've outlined or is that only relevant to the "Maximum posts allowed in any digest" setting?

The poster and I are handling this offline. If there is a bug I will post the fix here.

I think I fixed this problem, but yours many be a different bug. Please try this bug fix:

https://www.phpbb.com/customise/db/mod/ ... pic/157111