Warning: The author of this contribution does not provide support for it anymore.

PM Search

After Install Cannot Delete PM - PM Search

Re: After Install Cannot Delete PM

by sparkzter » Mon Jan 09, 2012 1:33 pm

geolim4 wrote:No trouble for me... Work perfect.. read attentively all the instruction !!!


im happy i followed all the instructions...i installed with AutoMod therefore there wasnt a lot for me to do - can i assume from your comments that you didnt use AutoMod and installed manually?

to clarify, i have found if a PM is viewed and the [x] in the top corner of the message is clicked..it deletes no problem...however if a user attempts to delete from the inbox (by ticking one or more messages and selecting 'delete marked' from the drop down box at the bottom of the page it doesnt work - the page refreshes and im directed to .../ucp.php?i=pm&mode=view&action=view_folder&f=0 (the confirmation screen where the user should confirm they wanna delete their message or not)

however they do not see the PM delete confirmation they see this! (oh my inbox has about 900 msgs in currently not none!)

Image

im sure this is a really silly thing thats causing this...and hoping this additional information/investigation will help the mod author identify and solve.
User avatar
sparkzter
Registered User
Posts: 31
Joined: Sat Feb 09, 2008 7:13 pm

Re: After Install Cannot Delete PM

by sparkzter » Mon Jan 09, 2012 9:40 pm

more on this....

i found if i comment out the red bit in ucp_pm_search.html

<fieldset>
<input class="inputbox search tiny" type="text" name="keywords" id="search_keywords" size="20" value="{SEARCH_KEYWORDS}" onclick="if (this.value == '{LA_SEARCH_PM_FOLDERS}') this.value = '';" onblur="if (this.value == '') this.value = '{LA_SEARCH_PM_FOLDERS}';" />
<input type="hidden" name="mode" value="search" />
<input type="hidden" name="start" value="0" />
<input class="button2" type="submit" value="{L_SEARCH}" />
 <a href="{S_PM_SEARCH_ADVANCED}" onclick="if(document.getElementById('pm-search-advanced').style.display == 'none') {document.getElementById('pm-search-advanced').style.display = 'block';} else {document.getElementById('pm-search-advanced').style.display = 'none';} return false;">{L_SEARCH_ADV}</a><br />
</fieldset>

the ability to delete PMs returns....furthermore i figure if i type something in the search box then click the [GO] button by the drop down box mentioned previously (delete marked messages) then it conducts the search...and doesnt delete any selected messages...

therefore the problem must be a conflict between those 2 buttons operations?...
User avatar
sparkzter
Registered User
Posts: 31
Joined: Sat Feb 09, 2008 7:13 pm

Re: After Install Cannot Delete PM

by Joshua203 » Sun Jun 24, 2012 11:44 pm

My quick guess is that you guys have added after a double FIND twice instead of only after the first find?

in functions_privmsgs.php

Code: Select all

   if (!sizeof($msg_ids))
   {
      return false;
   }
Image
http://DutchaGoGo.com (development/under construction ..forever?¿?) ;)
User avatar
Joshua203
Registered User
Posts: 227
Joined: Tue Jul 21, 2009 7:01 pm
Location: Rotterdam, Netherlands, Europe, Earth.
Name: Joshua 203

Re: After Install Cannot Delete PM

by Mickroz » Mon Sep 03, 2012 2:15 pm

same here, cannot delete pm's anymore.
checked the edits and they are fine.
I don't need to "get a life." I'm a Gamer, I have lots of lives!
Q: Whats a hash and a root password?
A: hash gets you high, root password gives you god powers, combine the 2 and you are invincible.
User avatar
Mickroz
Registered User
Posts: 661
Joined: Thu Mar 06, 2003 11:20 pm
Location: Netherlands

Re: After Install Cannot Delete PM

by Joshua203 » Mon Sep 03, 2012 3:00 pm

I think you have a bigger problem ;)
avg.jpg


about checking edits ...did you check my previous post?
Image
http://DutchaGoGo.com (development/under construction ..forever?¿?) ;)
User avatar
Joshua203
Registered User
Posts: 227
Joined: Tue Jul 21, 2009 7:01 pm
Location: Rotterdam, Netherlands, Europe, Earth.
Name: Joshua 203

Re: After Install Cannot Delete PM

by Mickroz » Mon Sep 03, 2012 9:10 pm

Thanks, contacted my host.
But yes, i checked that edit, dunnow if this existed before, but we encoutered it after upgrading to 3.0.11.
Disabling this mod enables deleting again, seems that the buttons clash as stated before.
I don't need to "get a life." I'm a Gamer, I have lots of lives!
Q: Whats a hash and a root password?
A: hash gets you high, root password gives you god powers, combine the 2 and you are invincible.
User avatar
Mickroz
Registered User
Posts: 661
Joined: Thu Mar 06, 2003 11:20 pm
Location: Netherlands

Re: After Install Cannot Delete PM

by Joshua203 » Mon Sep 03, 2012 9:39 pm

Well I 've just now tested one of my own boards and it still aint happening eventhough it's updated to 3.0.11.
Could you post the content of functions_privmsgs.php so I can take a look myself?
Image
http://DutchaGoGo.com (development/under construction ..forever?¿?) ;)
User avatar
Joshua203
Registered User
Posts: 227
Joined: Tue Jul 21, 2009 7:01 pm
Location: Rotterdam, Netherlands, Europe, Earth.
Name: Joshua 203

Re: After Install Cannot Delete PM

by Mickroz » Mon Sep 03, 2012 9:54 pm

Will post it tomorrow, im at work now
Ok, seems that an opened pm cannot be deleted either, you get to the confirmation page, and after clicking yes, you get redirected to the message you wanted to delete.
I don't need to "get a life." I'm a Gamer, I have lots of lives!
Q: Whats a hash and a root password?
A: hash gets you high, root password gives you god powers, combine the 2 and you are invincible.
User avatar
Mickroz
Registered User
Posts: 661
Joined: Thu Mar 06, 2003 11:20 pm
Location: Netherlands

Re: After Install Cannot Delete PM

by Mickroz » Tue Sep 04, 2012 2:19 pm

Code: Select all

<?php
/**
*
* @package phpBB3
* @version $Id$
* @copyright (c) 2005 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
*/
if (!defined('IN_PHPBB'))
{
   exit;
}

/*
   Ability to simply add own rules by doing three things:
      1) Add an appropriate constant
      2) Add a new check array to the global_privmsgs_rules variable and the condition array (if one is required)
      3) Add a new language variable to ucp.php

      The user is then able to select the new rule. It will be checked against and handled as specified.
      To add new actions (yes, checks can be added here too) to the rule management, the core code has to be modified.
*/

define('RULE_IS_LIKE', 1);      // Is Like
define('RULE_IS_NOT_LIKE', 2);   // Is Not Like
define('RULE_IS', 3);         // Is
define('RULE_IS_NOT', 4);      // Is Not
define('RULE_BEGINS_WITH', 5);   // Begins with
define('RULE_ENDS_WITH', 6);   // Ends with
define('RULE_IS_FRIEND', 7);   // Is Friend
define('RULE_IS_FOE', 8);      // Is Foe
define('RULE_IS_USER', 9);      // Is User
define('RULE_IS_GROUP', 10);   // Is In Usergroup
define('RULE_ANSWERED', 11);   // Answered
define('RULE_FORWARDED', 12);   // Forwarded
define('RULE_TO_GROUP', 14);   // Usergroup
define('RULE_TO_ME', 15);      // Me

define('ACTION_PLACE_INTO_FOLDER', 1);
define('ACTION_MARK_AS_READ', 2);
define('ACTION_MARK_AS_IMPORTANT', 3);
define('ACTION_DELETE_MESSAGE', 4);

define('CHECK_SUBJECT', 1);
define('CHECK_SENDER', 2);
define('CHECK_MESSAGE', 3);
define('CHECK_STATUS', 4);
define('CHECK_TO', 5);

/**
* Global private message rules
* These rules define what to do if a rule is hit
*/
$global_privmsgs_rules = array(
   CHECK_SUBJECT   => array(
      RULE_IS_LIKE      => array('check0' => 'message_subject', 'function' => 'preg_match("/" . preg_quote({STRING}, "/") . "/i", {CHECK0})'),
      RULE_IS_NOT_LIKE   => array('check0' => 'message_subject', 'function' => '!(preg_match("/" . preg_quote({STRING}, "/") . "/i", {CHECK0}))'),
      RULE_IS            => array('check0' => 'message_subject', 'function' => '{CHECK0} == {STRING}'),
      RULE_IS_NOT         => array('check0' => 'message_subject', 'function' => '{CHECK0} != {STRING}'),
      RULE_BEGINS_WITH   => array('check0' => 'message_subject', 'function' => 'preg_match("/^" . preg_quote({STRING}, "/") . "/i", {CHECK0})'),
      RULE_ENDS_WITH      => array('check0' => 'message_subject', 'function' => 'preg_match("/" . preg_quote({STRING}, "/") . "$/i", {CHECK0})'),
   ),

   CHECK_SENDER   => array(
      RULE_IS_LIKE      => array('check0' => 'username', 'function' => 'preg_match("/" . preg_quote({STRING}, "/") . "/i", {CHECK0})'),
      RULE_IS_NOT_LIKE   => array('check0' => 'username', 'function' => '!(preg_match("/" . preg_quote({STRING}, "/") . "/i", {CHECK0}))'),
      RULE_IS            => array('check0' => 'username', 'function' => '{CHECK0} == {STRING}'),
      RULE_IS_NOT         => array('check0' => 'username', 'function' => '{CHECK0} != {STRING}'),
      RULE_BEGINS_WITH   => array('check0' => 'username', 'function' => 'preg_match("/^" . preg_quote({STRING}, "/") . "/i", {CHECK0})'),
      RULE_ENDS_WITH      => array('check0' => 'username', 'function' => 'preg_match("/" . preg_quote({STRING}, "/") . "$/i", {CHECK0})'),
      RULE_IS_FRIEND      => array('check0' => 'friend', 'function' => '{CHECK0} == 1'),
      RULE_IS_FOE         => array('check0' => 'foe', 'function' => '{CHECK0} == 1'),
      RULE_IS_USER      => array('check0' => 'author_id', 'function' => '{CHECK0} == {USER_ID}'),
      RULE_IS_GROUP      => array('check0' => 'author_in_group', 'function' => 'in_array({GROUP_ID}, {CHECK0})'),
   ),

   CHECK_MESSAGE   => array(
      RULE_IS_LIKE      => array('check0' => 'message_text', 'function' => 'preg_match("/" . preg_quote({STRING}, "/") . "/i", {CHECK0})'),
      RULE_IS_NOT_LIKE   => array('check0' => 'message_text', 'function' => '!(preg_match("/" . preg_quote({STRING}, "/") . "/i", {CHECK0}))'),
      RULE_IS            => array('check0' => 'message_text', 'function' => '{CHECK0} == {STRING}'),
      RULE_IS_NOT         => array('check0' => 'message_text', 'function' => '{CHECK0} != {STRING}'),
   ),

   CHECK_STATUS   => array(
      RULE_ANSWERED      => array('check0' => 'pm_replied', 'function' => '{CHECK0} == 1'),
      RULE_FORWARDED      => array('check0' => 'pm_forwarded', 'function' => '{CHECK0} == 1'),
   ),

   CHECK_TO      => array(
      RULE_TO_GROUP      => array('check0' => 'to', 'check1' => 'bcc', 'check2' => 'user_in_group', 'function' => 'in_array("g_" . {CHECK2}, {CHECK0}) || in_array("g_" . {CHECK2}, {CHECK1})'),
      RULE_TO_ME         => array('check0' => 'to', 'check1' => 'bcc', 'function' => 'in_array("u_" . $user_id, {CHECK0}) || in_array("u_" . $user_id, {CHECK1})'),
   )
);

/**
* This is for defining which condition fields to show for which Rule
*/
$global_rule_conditions = array(
   RULE_IS_LIKE      => 'text',
   RULE_IS_NOT_LIKE   => 'text',
   RULE_IS            => 'text',
   RULE_IS_NOT         => 'text',
   RULE_BEGINS_WITH   => 'text',
   RULE_ENDS_WITH      => 'text',
   RULE_IS_USER      => 'user',
   RULE_IS_GROUP      => 'group'
);

/**
* Get all folder
*/
function get_folder($user_id, $folder_id = false)
{
   global $db, $user, $template;
   global $phpbb_root_path, $phpEx;

   $folder = array();

   // Get folder information
   $sql = 'SELECT folder_id, COUNT(msg_id) as num_messages, SUM(pm_unread) as num_unread
      FROM ' . PRIVMSGS_TO_TABLE . "
      WHERE user_id = $user_id
         AND folder_id <> " . PRIVMSGS_NO_BOX . '
      GROUP BY folder_id';
   $result = $db->sql_query($sql);

   $num_messages = $num_unread = array();
   while ($row = $db->sql_fetchrow($result))
   {
      $num_messages[(int) $row['folder_id']] = $row['num_messages'];
      $num_unread[(int) $row['folder_id']] = $row['num_unread'];
   }
   $db->sql_freeresult($result);

   // Make sure the default boxes are defined
   $available_folder = array(PRIVMSGS_INBOX, PRIVMSGS_OUTBOX, PRIVMSGS_SENTBOX);

   foreach ($available_folder as $default_folder)
   {
      if (!isset($num_messages[$default_folder]))
      {
         $num_messages[$default_folder] = 0;
      }

      if (!isset($num_unread[$default_folder]))
      {
         $num_unread[$default_folder] = 0;
      }
   }

   // Adjust unread status for outbox
   $num_unread[PRIVMSGS_OUTBOX] = $num_messages[PRIVMSGS_OUTBOX];

   $folder[PRIVMSGS_INBOX] = array(
      'folder_name'      => $user->lang['PM_INBOX'],
      'num_messages'      => $num_messages[PRIVMSGS_INBOX],
      'unread_messages'   => $num_unread[PRIVMSGS_INBOX]
   );

   // Custom Folder
   $sql = 'SELECT folder_id, folder_name, pm_count
      FROM ' . PRIVMSGS_FOLDER_TABLE . "
         WHERE user_id = $user_id";
   $result = $db->sql_query($sql);

   while ($row = $db->sql_fetchrow($result))
   {
      $folder[$row['folder_id']] = array(
         'folder_name'      => $row['folder_name'],
         'num_messages'      => $row['pm_count'],
         'unread_messages'   => ((isset($num_unread[$row['folder_id']])) ? $num_unread[$row['folder_id']] : 0)
      );
   }
   $db->sql_freeresult($result);

   $folder[PRIVMSGS_OUTBOX] = array(
      'folder_name'      => $user->lang['PM_OUTBOX'],
      'num_messages'      => $num_messages[PRIVMSGS_OUTBOX],
      'unread_messages'   => $num_unread[PRIVMSGS_OUTBOX]
   );

   $folder[PRIVMSGS_SENTBOX] = array(
      'folder_name'      => $user->lang['PM_SENTBOX'],
      'num_messages'      => $num_messages[PRIVMSGS_SENTBOX],
      'unread_messages'   => $num_unread[PRIVMSGS_SENTBOX]
   );

   // Define Folder Array for template designers (and for making custom folders usable by the template too)
   foreach ($folder as $f_id => $folder_ary)
   {
      $folder_id_name = ($f_id == PRIVMSGS_INBOX) ? 'inbox' : (($f_id == PRIVMSGS_OUTBOX) ? 'outbox' : 'sentbox');

      $template->assign_block_vars('folder', array(
         'FOLDER_ID'         => $f_id,
         'FOLDER_NAME'      => $folder_ary['folder_name'],
         'NUM_MESSAGES'      => $folder_ary['num_messages'],
         'UNREAD_MESSAGES'   => $folder_ary['unread_messages'],

         'U_FOLDER'         => ($f_id > 0) ? append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&amp;folder=' . $f_id) : append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&amp;folder=' . $folder_id_name),

         'S_CUR_FOLDER'      => ($f_id === $folder_id) ? true : false,
         'S_UNREAD_MESSAGES'   => ($folder_ary['unread_messages']) ? true : false,
         'S_CUSTOM_FOLDER'   => ($f_id > 0) ? true : false)
      );
   }

   if ($folder_id !== false && !isset($folder[$folder_id]))
   {
      trigger_error('UNKNOWN_FOLDER');
   }

   return $folder;
}

/**
* Delete Messages From Sentbox
* we are doing this here because this saves us a bunch of checks and queries
*/
function clean_sentbox($num_sentbox_messages)
{
   global $db, $user, $config;

   // Check Message Limit
   if ($user->data['message_limit'] && $num_sentbox_messages > $user->data['message_limit'])
   {
      // Delete old messages
      $sql = 'SELECT t.msg_id
         FROM ' . PRIVMSGS_TO_TABLE . ' t, ' . PRIVMSGS_TABLE . ' p
         WHERE t.msg_id = p.msg_id
            AND t.user_id = ' . $user->data['user_id'] . '
            AND t.folder_id = ' . PRIVMSGS_SENTBOX . '
         ORDER BY p.message_time ASC';
      $result = $db->sql_query_limit($sql, ($num_sentbox_messages - $user->data['message_limit']));

      $delete_ids = array();
      while ($row = $db->sql_fetchrow($result))
      {
         $delete_ids[] = $row['msg_id'];
      }
      $db->sql_freeresult($result);
      delete_pm($user->data['user_id'], $delete_ids, PRIVMSGS_SENTBOX);
   }
}

/**
* Check Rule against Message Information
*/
function check_rule(&$rules, &$rule_row, &$message_row, $user_id)
{
   global $user, $config;

   if (!isset($rules[$rule_row['rule_check']][$rule_row['rule_connection']]))
   {
      return false;
   }

   $check_ary = $rules[$rule_row['rule_check']][$rule_row['rule_connection']];

   // Replace Check Literals
   $evaluate = $check_ary['function'];
   $evaluate = preg_replace('/{(CHECK[0-9])}/', '$message_row[$check_ary[strtolower("\1")]]', $evaluate);

   // Replace Rule Literals
   $evaluate = preg_replace('/{(STRING|USER_ID|GROUP_ID)}/', '$rule_row["rule_" . strtolower("\1")]', $evaluate);

   // Evil Statement
   $result = false;
   eval('$result = (' . $evaluate . ') ? true : false;');

   if (!$result)
   {
      return false;
   }

   switch ($rule_row['rule_action'])
   {
      case ACTION_PLACE_INTO_FOLDER:
         return array('action' => $rule_row['rule_action'], 'folder_id' => $rule_row['rule_folder_id']);
      break;

      case ACTION_MARK_AS_READ:
      case ACTION_MARK_AS_IMPORTANT:
         return array('action' => $rule_row['rule_action'], 'pm_unread' => $message_row['pm_unread'], 'pm_marked' => $message_row['pm_marked']);
      break;

      case ACTION_DELETE_MESSAGE:
         global $db, $auth;

         // Check for admins/mods - users are not allowed to remove those messages...
         // We do the check here to make sure the data we use is consistent
         $sql = 'SELECT user_id, user_type, user_permissions
            FROM ' . USERS_TABLE . '
            WHERE user_id = ' . (int) $message_row['author_id'];
         $result = $db->sql_query($sql);
         $userdata = $db->sql_fetchrow($result);
         $db->sql_freeresult($result);

         $auth2 = new auth();
         $auth2->acl($userdata);

         if (!$auth2->acl_get('a_') && !$auth2->acl_get('m_') && !$auth2->acl_getf_global('m_'))
         {
            return array('action' => $rule_row['rule_action'], 'pm_unread' => $message_row['pm_unread'], 'pm_marked' => $message_row['pm_marked']);
         }

         return false;
      break;

      default:
         return false;
   }

   return false;
}

/**
* Update user PM count
*/
function update_pm_counts()
{
   global $user, $db;

   // Update unread count
   $sql = 'SELECT COUNT(msg_id) as num_messages
      FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE pm_unread = 1
         AND folder_id <> ' . PRIVMSGS_OUTBOX . '
         AND user_id = ' . $user->data['user_id'];
   $result = $db->sql_query($sql);
   $user->data['user_unread_privmsg'] = (int) $db->sql_fetchfield('num_messages');
   $db->sql_freeresult($result);

   // Update new pm count
   $sql = 'SELECT COUNT(msg_id) as num_messages
      FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE pm_new = 1
         AND folder_id IN (' . PRIVMSGS_NO_BOX . ', ' . PRIVMSGS_HOLD_BOX . ')
         AND user_id = ' . $user->data['user_id'];
   $result = $db->sql_query($sql);
   $user->data['user_new_privmsg'] = (int) $db->sql_fetchfield('num_messages');
   $db->sql_freeresult($result);

   $db->sql_query('UPDATE ' . USERS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', array(
      'user_unread_privmsg'   => (int) $user->data['user_unread_privmsg'],
      'user_new_privmsg'      => (int) $user->data['user_new_privmsg'],
   )) . ' WHERE user_id = ' . $user->data['user_id']);

   // Ok, here we need to repair something, other boxes than privmsgs_no_box and privmsgs_hold_box should not carry the pm_new flag.
   if (!$user->data['user_new_privmsg'])
   {
      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
         SET pm_new = 0
         WHERE pm_new = 1
            AND folder_id NOT IN (' . PRIVMSGS_NO_BOX . ', ' . PRIVMSGS_HOLD_BOX . ')
            AND user_id = ' . $user->data['user_id'];
      $db->sql_query($sql);
   }
}

/**
* Place new messages into appropriate folder
*/
function place_pm_into_folder(&$global_privmsgs_rules, $release = false)
{
   global $db, $user, $config;

   if (!$user->data['user_new_privmsg'])
   {
      return array('not_moved' => 0, 'removed' => 0);
   }

   $user_message_rules = (int) $user->data['user_message_rules'];
   $user_id = (int) $user->data['user_id'];

   $action_ary = $move_into_folder = array();
   $num_removed = 0;

   // Newly processing on-hold messages
   if ($release)
   {
      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
         SET folder_id = ' . PRIVMSGS_NO_BOX . '
         WHERE folder_id = ' . PRIVMSGS_HOLD_BOX . "
            AND user_id = $user_id";
      $db->sql_query($sql);
   }

   // Get those messages not yet placed into any box
   $retrieve_sql = 'SELECT t.*, p.*, u.username, u.user_id, u.group_id
      FROM ' . PRIVMSGS_TO_TABLE . ' t, ' . PRIVMSGS_TABLE . ' p, ' . USERS_TABLE . " u
      WHERE t.user_id = $user_id
         AND p.author_id = u.user_id
         AND t.folder_id = " . PRIVMSGS_NO_BOX . '
         AND t.msg_id = p.msg_id';

   // Just place into the appropriate arrays if no rules need to be checked
   if (!$user_message_rules)
   {
      $result = $db->sql_query($retrieve_sql);

      while ($row = $db->sql_fetchrow($result))
      {
         $action_ary[$row['msg_id']][] = array('action' => false);
      }
      $db->sql_freeresult($result);
   }
   else
   {
      $user_rules = $zebra = $check_rows = array();
      $user_ids = $memberships = array();

      // First of all, grab all rules and retrieve friends/foes
      $sql = 'SELECT *
         FROM ' . PRIVMSGS_RULES_TABLE . "
         WHERE user_id = $user_id";
      $result = $db->sql_query($sql);
      $user_rules = $db->sql_fetchrowset($result);
      $db->sql_freeresult($result);

      if (sizeof($user_rules))
      {
         $sql = 'SELECT zebra_id, friend, foe
            FROM ' . ZEBRA_TABLE . "
            WHERE user_id = $user_id";
         $result = $db->sql_query($sql);

         while ($row = $db->sql_fetchrow($result))
         {
            $zebra[$row['zebra_id']] = $row;
         }
         $db->sql_freeresult($result);
      }

      // Now build a bare-bone check_row array
      $result = $db->sql_query($retrieve_sql);

      while ($row = $db->sql_fetchrow($result))
      {
         $check_rows[] = array_merge($row, array(
            'to'            => explode(':', $row['to_address']),
            'bcc'            => explode(':', $row['bcc_address']),
            'friend'         => (isset($zebra[$row['author_id']])) ? $zebra[$row['author_id']]['friend'] : 0,
            'foe'            => (isset($zebra[$row['author_id']])) ? $zebra[$row['author_id']]['foe'] : 0,
            'user_in_group'      => array($user->data['group_id']),
            'author_in_group'   => array())
         );

         $user_ids[] = $row['user_id'];
      }
      $db->sql_freeresult($result);

      // Retrieve user memberships
      if (sizeof($user_ids))
      {
         $sql = 'SELECT *
            FROM ' . USER_GROUP_TABLE . '
            WHERE ' . $db->sql_in_set('user_id', $user_ids) . '
               AND user_pending = 0';
         $result = $db->sql_query($sql);

         while ($row = $db->sql_fetchrow($result))
         {
            $memberships[$row['user_id']][] = $row['group_id'];
         }
         $db->sql_freeresult($result);
      }

      // Now place into the appropriate folder
      foreach ($check_rows as $row)
      {
         // Add membership if set
         if (isset($memberships[$row['author_id']]))
         {
            $row['author_in_group'] = $memberships[$row['user_id']];
         }

         // Check Rule - this should be very quick since we have all information we need
         $is_match = false;
         foreach ($user_rules as $rule_row)
         {
            if (($action = check_rule($global_privmsgs_rules, $rule_row, $row, $user_id)) !== false)
            {
               $is_match = true;
               $action_ary[$row['msg_id']][] = $action;
            }
         }

         if (!$is_match)
         {
            $action_ary[$row['msg_id']][] = array('action' => false);
         }
      }

      unset($user_rules, $zebra, $check_rows, $user_ids, $memberships);
   }

   // We place actions into arrays, to save queries.
   $sql = $unread_ids = $delete_ids = $important_ids = array();

   foreach ($action_ary as $msg_id => $msg_ary)
   {
      // It is allowed to execute actions more than once, except placing messages into folder
      $folder_action = $message_removed = false;

      foreach ($msg_ary as $pos => $rule_ary)
      {
         if ($folder_action && $rule_ary['action'] == ACTION_PLACE_INTO_FOLDER)
         {
            continue;
         }

         switch ($rule_ary['action'])
         {
            case ACTION_PLACE_INTO_FOLDER:
               // Folder actions have precedence, so we will remove any other ones
               $folder_action = true;
               $move_into_folder[(int) $rule_ary['folder_id']][] = $msg_id;
            break;

            case ACTION_MARK_AS_READ:
               if ($rule_ary['pm_unread'])
               {
                  $unread_ids[] = $msg_id;
               }
            break;

            case ACTION_DELETE_MESSAGE:
               $delete_ids[] = $msg_id;
               $message_removed = true;
            break;

            case ACTION_MARK_AS_IMPORTANT:
               if (!$rule_ary['pm_marked'])
               {
                  $important_ids[] = $msg_id;
               }
            break;
         }
      }

      // We place this here because it could happen that the messages are doubled if a rule marks a message and then moves it into a specific
      // folder. Here we simply move the message into the INBOX if it gets not removed and also not put into a custom folder.
      if (!$folder_action && !$message_removed)
      {
         $move_into_folder[PRIVMSGS_INBOX][] = $msg_id;
      }
   }

   // Do not change the order of processing
   // The number of queries needed to be executed here highly depends on the defined rules and are
   // only gone through if new messages arrive.

   // Delete messages
   if (sizeof($delete_ids))
   {
      $num_removed += sizeof($delete_ids);
      delete_pm($user_id, $delete_ids, PRIVMSGS_NO_BOX);
   }

   // Set messages to Unread
   if (sizeof($unread_ids))
   {
      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
         SET pm_unread = 0
         WHERE ' . $db->sql_in_set('msg_id', $unread_ids) . "
            AND user_id = $user_id
            AND folder_id = " . PRIVMSGS_NO_BOX;
      $db->sql_query($sql);
   }

   // mark messages as important
   if (sizeof($important_ids))
   {
      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
         SET pm_marked = 1 - pm_marked
         WHERE folder_id = ' . PRIVMSGS_NO_BOX . "
            AND user_id = $user_id
            AND " . $db->sql_in_set('msg_id', $important_ids);
      $db->sql_query($sql);
   }

   // Move into folder
   $folder = array();

   if (sizeof($move_into_folder))
   {
      // Determine Full Folder Action - we need the move to folder id later eventually
      $full_folder_action = ($user->data['user_full_folder'] == FULL_FOLDER_NONE) ? ($config['full_folder_action'] - (FULL_FOLDER_NONE*(-1))) : $user->data['user_full_folder'];

      $sql_folder = array_keys($move_into_folder);
      if ($full_folder_action >= 0)
      {
         $sql_folder[] = $full_folder_action;
      }

      $sql = 'SELECT folder_id, pm_count
         FROM ' . PRIVMSGS_FOLDER_TABLE . '
         WHERE ' . $db->sql_in_set('folder_id', $sql_folder) . "
            AND user_id = $user_id";
      $result = $db->sql_query($sql);

      while ($row = $db->sql_fetchrow($result))
      {
         $folder[(int) $row['folder_id']] = (int) $row['pm_count'];
      }
      $db->sql_freeresult($result);

      unset($sql_folder);

      if (isset($move_into_folder[PRIVMSGS_INBOX]))
      {
         $sql = 'SELECT COUNT(msg_id) as num_messages
            FROM ' . PRIVMSGS_TO_TABLE . "
            WHERE user_id = $user_id
               AND folder_id = " . PRIVMSGS_INBOX;
         $result = $db->sql_query($sql);
         $folder[PRIVMSGS_INBOX] = (int) $db->sql_fetchfield('num_messages');
         $db->sql_freeresult($result);
      }
   }

   // Here we have ideally only one folder to move into
   foreach ($move_into_folder as $folder_id => $msg_ary)
   {
      $dest_folder = $folder_id;
      $full_folder_action = FULL_FOLDER_NONE;

      // Check Message Limit - we calculate with the complete array, most of the time it is one message
      // But we are making sure that the other way around works too (more messages in queue than allowed to be stored)
      if ($user->data['message_limit'] && $folder[$folder_id] && ($folder[$folder_id] + sizeof($msg_ary)) > $user->data['message_limit'])
      {
         $full_folder_action = ($user->data['user_full_folder'] == FULL_FOLDER_NONE) ? ($config['full_folder_action'] - (FULL_FOLDER_NONE*(-1))) : $user->data['user_full_folder'];

         // If destination folder itself is full...
         if ($full_folder_action >= 0 && ($folder[$full_folder_action] + sizeof($msg_ary)) > $user->data['message_limit'])
         {
            $full_folder_action = $config['full_folder_action'] - (FULL_FOLDER_NONE*(-1));
         }

         // If Full Folder Action is to move to another folder, we simply adjust the destination folder
         if ($full_folder_action >= 0)
         {
            $dest_folder = $full_folder_action;
         }
         else if ($full_folder_action == FULL_FOLDER_DELETE)
         {
            // Delete some messages. NOTE: Ordered by msg_id here instead of message_time!
            $sql = 'SELECT msg_id
               FROM ' . PRIVMSGS_TO_TABLE . "
               WHERE user_id = $user_id
                  AND folder_id = $dest_folder
               ORDER BY msg_id ASC";
            $result = $db->sql_query_limit($sql, (($folder[$dest_folder] + sizeof($msg_ary)) - $user->data['message_limit']));

            $delete_ids = array();
            while ($row = $db->sql_fetchrow($result))
            {
               $delete_ids[] = $row['msg_id'];
            }
            $db->sql_freeresult($result);

            $num_removed += sizeof($delete_ids);
            delete_pm($user_id, $delete_ids, $dest_folder);
         }
      }

      //
      if ($full_folder_action == FULL_FOLDER_HOLD)
      {
         $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
            SET folder_id = ' . PRIVMSGS_HOLD_BOX . '
            WHERE folder_id = ' . PRIVMSGS_NO_BOX . "
               AND user_id = $user_id
               AND " . $db->sql_in_set('msg_id', $msg_ary);
         $db->sql_query($sql);
      }
      else
      {
         $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . "
            SET folder_id = $dest_folder, pm_new = 0
            WHERE folder_id = " . PRIVMSGS_NO_BOX . "
               AND user_id = $user_id
               AND pm_new = 1
               AND " . $db->sql_in_set('msg_id', $msg_ary);
         $db->sql_query($sql);

         if ($dest_folder != PRIVMSGS_INBOX)
         {
            $sql = 'UPDATE ' . PRIVMSGS_FOLDER_TABLE . '
               SET pm_count = pm_count + ' . (int) $db->sql_affectedrows() . "
               WHERE folder_id = $dest_folder
                  AND user_id = $user_id";
            $db->sql_query($sql);
         }
      }
   }

   if (sizeof($action_ary))
   {
      // Move from OUTBOX to SENTBOX
      // We are not checking any full folder status here... SENTBOX is a special treatment (old messages get deleted)
      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
         SET folder_id = ' . PRIVMSGS_SENTBOX . '
         WHERE folder_id = ' . PRIVMSGS_OUTBOX . '
            AND ' . $db->sql_in_set('msg_id', array_keys($action_ary));
      $db->sql_query($sql);
   }

   // Update new/unread count
   update_pm_counts();

   // Now check how many messages got not moved...
   $sql = 'SELECT COUNT(msg_id) as num_messages
      FROM ' . PRIVMSGS_TO_TABLE . "
      WHERE user_id = $user_id
         AND folder_id = " . PRIVMSGS_HOLD_BOX;
   $result = $db->sql_query($sql);
   $num_not_moved = (int) $db->sql_fetchfield('num_messages');
   $db->sql_freeresult($result);

   return array('not_moved' => $num_not_moved, 'removed' => $num_removed);
}

/**
* Move PM from one to another folder
*/
function move_pm($user_id, $message_limit, $move_msg_ids, $dest_folder, $cur_folder_id)
{
   global $db, $user;
   global $phpbb_root_path, $phpEx;

   $num_moved = 0;

   if (!is_array($move_msg_ids))
   {
      $move_msg_ids = array($move_msg_ids);
   }

   if (sizeof($move_msg_ids) && !in_array($dest_folder, array(PRIVMSGS_NO_BOX, PRIVMSGS_OUTBOX, PRIVMSGS_SENTBOX)) &&
      !in_array($cur_folder_id, array(PRIVMSGS_NO_BOX, PRIVMSGS_OUTBOX)) && $cur_folder_id != $dest_folder)
   {
      // We have to check the destination folder ;)
      if ($dest_folder != PRIVMSGS_INBOX)
      {
         $sql = 'SELECT folder_id, folder_name, pm_count
            FROM ' . PRIVMSGS_FOLDER_TABLE . "
            WHERE folder_id = $dest_folder
               AND user_id = $user_id";
         $result = $db->sql_query($sql);
         $row = $db->sql_fetchrow($result);
         $db->sql_freeresult($result);

         if (!$row)
         {
            trigger_error('NOT_AUTHORISED');
         }

         if ($message_limit && $row['pm_count'] + sizeof($move_msg_ids) > $message_limit)
         {
            $message = sprintf($user->lang['NOT_ENOUGH_SPACE_FOLDER'], $row['folder_name']) . '<br /><br />';
            $message .= sprintf($user->lang['CLICK_RETURN_FOLDER'], '<a href="' . append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&amp;folder=' . $row['folder_id']) . '">', '</a>', $row['folder_name']);
            trigger_error($message);
         }
      }
      else
      {
         $sql = 'SELECT COUNT(msg_id) as num_messages
            FROM ' . PRIVMSGS_TO_TABLE . '
            WHERE folder_id = ' . PRIVMSGS_INBOX . "
               AND user_id = $user_id";
         $result = $db->sql_query($sql);
         $num_messages = (int) $db->sql_fetchfield('num_messages');
         $db->sql_freeresult($result);

         if ($message_limit && $num_messages + sizeof($move_msg_ids) > $message_limit)
         {
            $message = sprintf($user->lang['NOT_ENOUGH_SPACE_FOLDER'], $user->lang['PM_INBOX']) . '<br /><br />';
            $message .= sprintf($user->lang['CLICK_RETURN_FOLDER'], '<a href="' . append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&amp;folder=inbox') . '">', '</a>', $user->lang['PM_INBOX']);
            trigger_error($message);
         }
      }

      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . "
         SET folder_id = $dest_folder
         WHERE folder_id = $cur_folder_id
            AND user_id = $user_id
            AND " . $db->sql_in_set('msg_id', $move_msg_ids);
      $db->sql_query($sql);
      $num_moved = $db->sql_affectedrows();

      // Update pm counts
      if ($num_moved)
      {
         if (!in_array($cur_folder_id, array(PRIVMSGS_INBOX, PRIVMSGS_OUTBOX, PRIVMSGS_SENTBOX)))
         {
            $sql = 'UPDATE ' . PRIVMSGS_FOLDER_TABLE . "
               SET pm_count = pm_count - $num_moved
               WHERE folder_id = $cur_folder_id
                  AND user_id = $user_id";
            $db->sql_query($sql);
         }

         if ($dest_folder != PRIVMSGS_INBOX)
         {
            $sql = 'UPDATE ' . PRIVMSGS_FOLDER_TABLE . "
               SET pm_count = pm_count + $num_moved
               WHERE folder_id = $dest_folder
                  AND user_id = $user_id";
            $db->sql_query($sql);
         }
      }
   }
   else if (in_array($cur_folder_id, array(PRIVMSGS_NO_BOX, PRIVMSGS_OUTBOX)))
   {
      trigger_error('CANNOT_MOVE_SPECIAL');
   }

   return $num_moved;
}

/**
* Update unread message status
*/
function update_unread_status($unread, $msg_id, $user_id, $folder_id)
{
   if (!$unread)
   {
      return;
   }

   global $db, $user;

   $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . "
      SET pm_unread = 0
      WHERE msg_id = $msg_id
         AND user_id = $user_id
         AND folder_id = $folder_id";
   $db->sql_query($sql);

   $sql = 'UPDATE ' . USERS_TABLE . "
      SET user_unread_privmsg = user_unread_privmsg - 1
      WHERE user_id = $user_id";
   $db->sql_query($sql);

   if ($user->data['user_id'] == $user_id)
   {
      $user->data['user_unread_privmsg']--;

      // Try to cope with previous wrong conversions...
      if ($user->data['user_unread_privmsg'] < 0)
      {
         $sql = 'UPDATE ' . USERS_TABLE . "
            SET user_unread_privmsg = 0
            WHERE user_id = $user_id";
         $db->sql_query($sql);

         $user->data['user_unread_privmsg'] = 0;
      }
   }
}

/**
* Handle all actions possible with marked messages
*/
function handle_mark_actions($user_id, $mark_action)
{
   global $db, $user, $phpbb_root_path, $phpEx;

   $msg_ids      = request_var('marked_msg_id', array(0));
   $cur_folder_id   = request_var('cur_folder_id', PRIVMSGS_NO_BOX);
   $confirm      = (isset($_POST['confirm'])) ? true : false;

   if (!sizeof($msg_ids))
   {
      return false;
   }

   // PM Search
   if(isset($_POST['in_pm_search']))
   {
      return(handle_pm_search_actions($mark_action, $msg_ids));
   }

   switch ($mark_action)
   {
      case 'mark_important':

         $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . "
            SET pm_marked = 1 - pm_marked
            WHERE folder_id = $cur_folder_id
               AND user_id = $user_id
               AND " . $db->sql_in_set('msg_id', $msg_ids);
         $db->sql_query($sql);

      break;

      case 'delete_marked':

         global $auth;

         if (!$auth->acl_get('u_pm_delete'))
         {
            trigger_error('NO_AUTH_DELETE_MESSAGE');
         }

         if (confirm_box(true))
         {
            delete_pm($user_id, $msg_ids, $cur_folder_id);

            $success_msg = (sizeof($msg_ids) == 1) ? 'MESSAGE_DELETED' : 'MESSAGES_DELETED';
            $redirect = append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm&amp;folder=' . $cur_folder_id);

            meta_refresh(3, $redirect);
            trigger_error($user->lang[$success_msg] . '<br /><br />' . sprintf($user->lang['RETURN_FOLDER'], '<a href="' . $redirect . '">', '</a>'));
         }
         else
         {
            $s_hidden_fields = array(
               'cur_folder_id'   => $cur_folder_id,
               'mark_option'   => 'delete_marked',
               'submit_mark'   => true,
               'marked_msg_id'   => $msg_ids
            );

            confirm_box(false, 'DELETE_MARKED_PM', build_hidden_fields($s_hidden_fields));
         }

      break;

      default:
         return false;
   }

   return true;
}

/**
* Delete PM(s)
*/
function delete_pm($user_id, $msg_ids, $folder_id)
{
   global $db, $user, $phpbb_root_path, $phpEx;

   $user_id   = (int) $user_id;
   $folder_id   = (int) $folder_id;

   if (!$user_id)
   {
      return false;
   }

   if (!is_array($msg_ids))
   {
      if (!$msg_ids)
      {
         return false;
      }
      $msg_ids = array($msg_ids);
   }

   if (!sizeof($msg_ids))
   {
      return false;
   }

   // Get PM Information for later deleting
   $sql = 'SELECT msg_id, pm_unread, pm_new
      FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE ' . $db->sql_in_set('msg_id', array_map('intval', $msg_ids)) . "
         AND folder_id = $folder_id
         AND user_id = $user_id";
   $result = $db->sql_query($sql);

   $delete_rows = array();
   $num_unread = $num_new = $num_deleted = 0;
   while ($row = $db->sql_fetchrow($result))
   {
      $num_unread += (int) $row['pm_unread'];
      $num_new += (int) $row['pm_new'];

      $delete_rows[$row['msg_id']] = 1;
   }
   $db->sql_freeresult($result);
   unset($msg_ids);

   if (!sizeof($delete_rows))
   {
      return false;
   }

   $db->sql_transaction('begin');

   // if no one has read the message yet (meaning it is in users outbox)
   // then mark the message as deleted...
   if ($folder_id == PRIVMSGS_OUTBOX)
   {
      // Remove PM from Outbox
      $sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . "
         WHERE user_id = $user_id AND folder_id = " . PRIVMSGS_OUTBOX . '
            AND ' . $db->sql_in_set('msg_id', array_keys($delete_rows));
      $db->sql_query($sql);

      // Update PM Information for safety
      $sql = 'UPDATE ' . PRIVMSGS_TABLE . " SET message_text = ''
         WHERE " . $db->sql_in_set('msg_id', array_keys($delete_rows));
      $db->sql_query($sql);

      // Set delete flag for those intended to receive the PM
      // We do not remove the message actually, to retain some basic information (sent time for example)
      $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
         SET pm_deleted = 1
         WHERE ' . $db->sql_in_set('msg_id', array_keys($delete_rows));
      $db->sql_query($sql);

      $num_deleted = $db->sql_affectedrows();
   }
   else
   {
      // Delete private message data
      $sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . "
         WHERE user_id = $user_id
            AND folder_id = $folder_id
            AND " . $db->sql_in_set('msg_id', array_keys($delete_rows));
      $db->sql_query($sql);
      $num_deleted = $db->sql_affectedrows();
   }

   // if folder id is user defined folder then decrease pm_count
   if (!in_array($folder_id, array(PRIVMSGS_INBOX, PRIVMSGS_OUTBOX, PRIVMSGS_SENTBOX, PRIVMSGS_NO_BOX)))
   {
      $sql = 'UPDATE ' . PRIVMSGS_FOLDER_TABLE . "
         SET pm_count = pm_count - $num_deleted
         WHERE folder_id = $folder_id";
      $db->sql_query($sql);
   }

   // Update unread and new status field
   if ($num_unread || $num_new)
   {
      $set_sql = ($num_unread) ? 'user_unread_privmsg = user_unread_privmsg - ' . $num_unread : '';

      if ($num_new)
      {
         $set_sql .= ($set_sql != '') ? ', ' : '';
         $set_sql .= 'user_new_privmsg = user_new_privmsg - ' . $num_new;
      }

      $db->sql_query('UPDATE ' . USERS_TABLE . " SET $set_sql WHERE user_id = $user_id");

      $user->data['user_new_privmsg'] -= $num_new;
      $user->data['user_unread_privmsg'] -= $num_unread;
   }

   // Now we have to check which messages we can delete completely
   $sql = 'SELECT msg_id
      FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE ' . $db->sql_in_set('msg_id', array_keys($delete_rows));
   $result = $db->sql_query($sql);

   while ($row = $db->sql_fetchrow($result))
   {
      unset($delete_rows[$row['msg_id']]);
   }
   $db->sql_freeresult($result);

   $delete_ids = array_keys($delete_rows);

   if (sizeof($delete_ids))
   {
      // Check if there are any attachments we need to remove
      if (!function_exists('delete_attachments'))
      {
         include($phpbb_root_path . 'includes/functions_admin.' . $phpEx);
      }

      delete_attachments('message', $delete_ids, false);

      $sql = 'DELETE FROM ' . PRIVMSGS_TABLE . '
         WHERE ' . $db->sql_in_set('msg_id', $delete_ids);
      $db->sql_query($sql);
   }

   $db->sql_transaction('commit');

   return true;
}

/**
* Delete all PM(s) for a given user and delete the ones without references
*
* @param   int      $user_id   ID of the user whose private messages we want to delete
*
* @return   boolean      False if there were no pms found, true otherwise.
*/
function phpbb_delete_user_pms($user_id)
{
   global $db, $user, $phpbb_root_path, $phpEx;

   $user_id = (int) $user_id;

   if (!$user_id)
   {
      return false;
   }

   // Get PM Information for later deleting
   // The two queries where split, so we can use our indexes
   $undelivered_msg = $delete_ids = array();

   // Part 1: get PMs the user received
   $sql = 'SELECT msg_id
      FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE user_id = ' . $user_id;
   $result = $db->sql_query($sql);

   while ($row = $db->sql_fetchrow($result))
   {
      $msg_id = (int) $row['msg_id'];
      $delete_ids[$msg_id] = $msg_id;
   }
   $db->sql_freeresult($result);

   // Part 2: get PMs the user sent, but have yet to be received
   // We cannot simply delete them. First we have to check,
   // whether another user already received and read the message.
   $sql = 'SELECT msg_id
      FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE author_id = ' . $user_id . '
         AND folder_id = ' . PRIVMSGS_NO_BOX;
   $result = $db->sql_query($sql);

   while ($row = $db->sql_fetchrow($result))
   {
      $msg_id = (int) $row['msg_id'];
      $undelivered_msg[$msg_id] = $msg_id;
   }
   $db->sql_freeresult($result);

   if (empty($delete_ids) && empty($undelivered_msg))
   {
      return false;
   }

   $db->sql_transaction('begin');

   if (!empty($undelivered_msg))
   {
      // A pm is delivered, if for any recipient the message was moved
      // from their NO_BOX to another folder. We do not delete such
      // messages, but only delete them for users, who have not yet
      // received them.
      $sql = 'SELECT msg_id
         FROM ' . PRIVMSGS_TO_TABLE . '
         WHERE author_id = ' . $user_id . '
            AND folder_id <> ' . PRIVMSGS_NO_BOX . '
            AND folder_id <> ' . PRIVMSGS_OUTBOX . '
            AND folder_id <> ' . PRIVMSGS_SENTBOX;
      $result = $db->sql_query($sql);

      $delivered_msg = array();
      while ($row = $db->sql_fetchrow($result))
      {
         $msg_id = (int) $row['msg_id'];
         $delivered_msg[$msg_id] = $msg_id;
         unset($undelivered_msg[$msg_id]);
      }
      $db->sql_freeresult($result);

      $undelivered_user = array();

      // Count the messages we delete, so we can correct the user pm data
      $sql = 'SELECT user_id, COUNT(msg_id) as num_undelivered_privmsgs
         FROM ' . PRIVMSGS_TO_TABLE . '
         WHERE author_id = ' . $user_id . '
            AND folder_id = ' . PRIVMSGS_NO_BOX . '
               AND ' . $db->sql_in_set('msg_id', array_merge($undelivered_msg, $delivered_msg)) . '
         GROUP BY user_id';
      $result = $db->sql_query($sql);

      while ($row = $db->sql_fetchrow($result))
      {
         $num_pms = (int) $row['num_undelivered_privmsgs'];
         $undelivered_user[$num_pms][] = (int) $row['user_id'];

         if (sizeof($undelivered_user[$num_pms]) > 50)
         {
            // If there are too many users affected the query might get
            // too long, so we update the value for the first bunch here.
            $sql = 'UPDATE ' . USERS_TABLE . '
               SET user_new_privmsg = user_new_privmsg - ' . $num_pms . ',
                  user_unread_privmsg = user_unread_privmsg - ' . $num_pms . '
               WHERE ' . $db->sql_in_set('user_id', $undelivered_user[$num_pms]);
            $db->sql_query($sql);
            unset($undelivered_user[$num_pms]);
         }
      }
      $db->sql_freeresult($result);

      foreach ($undelivered_user as $num_pms => $undelivered_user_set)
      {
         $sql = 'UPDATE ' . USERS_TABLE . '
            SET user_new_privmsg = user_new_privmsg - ' . $num_pms . ',
               user_unread_privmsg = user_unread_privmsg - ' . $num_pms . '
            WHERE ' . $db->sql_in_set('user_id', $undelivered_user_set);
         $db->sql_query($sql);
      }

      if (!empty($delivered_msg))
      {
         $sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . '
            WHERE folder_id = ' . PRIVMSGS_NO_BOX . '
               AND ' . $db->sql_in_set('msg_id', $delivered_msg);
         $db->sql_query($sql);
      }

      if (!empty($undelivered_msg))
      {
         $sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . '
            WHERE ' . $db->sql_in_set('msg_id', $undelivered_msg);
         $db->sql_query($sql);

         $sql = 'DELETE FROM ' . PRIVMSGS_TABLE . '
            WHERE ' . $db->sql_in_set('msg_id', $undelivered_msg);
         $db->sql_query($sql);
      }
   }

   // Reset the user's pm count to 0
   $sql = 'UPDATE ' . USERS_TABLE . '
      SET user_new_privmsg = 0,
         user_unread_privmsg = 0
      WHERE user_id = ' . $user_id;
   $db->sql_query($sql);

   // Delete private message data of the user
   $sql = 'DELETE FROM ' . PRIVMSGS_TO_TABLE . '
      WHERE user_id = ' . (int) $user_id;
   $db->sql_query($sql);

   if (!empty($delete_ids))
   {
      // Now we have to check which messages we can delete completely
      $sql = 'SELECT msg_id
         FROM ' . PRIVMSGS_TO_TABLE . '
         WHERE ' . $db->sql_in_set('msg_id', $delete_ids);
      $result = $db->sql_query($sql);

      while ($row = $db->sql_fetchrow($result))
      {
         unset($delete_ids[$row['msg_id']]);
      }
      $db->sql_freeresult($result);

      if (!empty($delete_ids))
      {
         // Check if there are any attachments we need to remove
         if (!function_exists('delete_attachments'))
         {
            include($phpbb_root_path . 'includes/functions_admin.' . $phpEx);
         }

         delete_attachments('message', $delete_ids, false);

         $sql = 'DELETE FROM ' . PRIVMSGS_TABLE . '
            WHERE ' . $db->sql_in_set('msg_id', $delete_ids);
         $db->sql_query($sql);
      }
   }

   // Set the remaining author id to anonymous
   // This way users are still able to read messages from users being removed
   $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
      SET author_id = ' . ANONYMOUS . '
      WHERE author_id = ' . $user_id;
   $db->sql_query($sql);

   $sql = 'UPDATE ' . PRIVMSGS_TABLE . '
      SET author_id = ' . ANONYMOUS . '
      WHERE author_id = ' . $user_id;
   $db->sql_query($sql);

   $db->sql_transaction('commit');

   return true;
}

/**
* Rebuild message header
*/
function rebuild_header($check_ary)
{
   global $db;

   $address = array();

   foreach ($check_ary as $check_type => $address_field)
   {
      // Split Addresses into users and groups
      preg_match_all('/:?(u|g)_([0-9]+):?/', $address_field, $match);

      $u = $g = array();
      foreach ($match[1] as $id => $type)
      {
         ${$type}[] = (int) $match[2][$id];
      }

      $_types = array('u', 'g');
      foreach ($_types as $type)
      {
         if (sizeof($$type))
         {
            foreach ($$type as $id)
            {
               $address[$type][$id] = $check_type;
            }
         }
      }
   }

   return $address;
}

/**
* Print out/assign recipient information
*/
function write_pm_addresses($check_ary, $author_id, $plaintext = false)
{
   global $db, $user, $template, $phpbb_root_path, $phpEx;

   $addresses = array();

   foreach ($check_ary as $check_type => $address_field)
   {
      if (!is_array($address_field))
      {
         // Split Addresses into users and groups
         preg_match_all('/:?(u|g)_([0-9]+):?/', $address_field, $match);

         $u = $g = array();
         foreach ($match[1] as $id => $type)
         {
            ${$type}[] = (int) $match[2][$id];
         }
      }
      else
      {
         $u = $address_field['u'];
         $g = $address_field['g'];
      }

      $address = array();
      if (sizeof($u))
      {
         $sql = 'SELECT user_id, username, user_colour
            FROM ' . USERS_TABLE . '
            WHERE ' . $db->sql_in_set('user_id', $u);
         $result = $db->sql_query($sql);

         while ($row = $db->sql_fetchrow($result))
         {
            if ($check_type == 'to' || $author_id == $user->data['user_id'] || $row['user_id'] == $user->data['user_id'])
            {
               if ($plaintext)
               {
                  $address[] = $row['username'];
               }
               else
               {
                  $address['user'][$row['user_id']] = array('name' => $row['username'], 'colour' => $row['user_colour']);
               }
            }
         }
         $db->sql_freeresult($result);
      }

      if (sizeof($g))
      {
         if ($plaintext)
         {
            $sql = 'SELECT group_name, group_type
               FROM ' . GROUPS_TABLE . '
                  WHERE ' . $db->sql_in_set('group_id', $g);
            $result = $db->sql_query($sql);

            while ($row = $db->sql_fetchrow($result))
            {
               if ($check_type == 'to' || $author_id == $user->data['user_id'] || $row['user_id'] == $user->data['user_id'])
               {
                  $address[] = ($row['group_type'] == GROUP_SPECIAL) ? $user->lang['G_' . $row['group_name']] : $row['group_name'];
               }
            }
            $db->sql_freeresult($result);
         }
         else
         {
            $sql = 'SELECT g.group_id, g.group_name, g.group_colour, g.group_type, ug.user_id
               FROM ' . GROUPS_TABLE . ' g, ' . USER_GROUP_TABLE . ' ug
                  WHERE ' . $db->sql_in_set('g.group_id', $g) . '
                  AND g.group_id = ug.group_id
                  AND ug.user_pending = 0';
            $result = $db->sql_query($sql);

            while ($row = $db->sql_fetchrow($result))
            {
               if (!isset($address['group'][$row['group_id']]))
               {
                  if ($check_type == 'to' || $author_id == $user->data['user_id'] || $row['user_id'] == $user->data['user_id'])
                  {
                     $row['group_name'] = ($row['group_type'] == GROUP_SPECIAL) ? $user->lang['G_' . $row['group_name']] : $row['group_name'];
                     $address['group'][$row['group_id']] = array('name' => $row['group_name'], 'colour' => $row['group_colour']);
                  }
               }

               if (isset($address['user'][$row['user_id']]))
               {
                  $address['user'][$row['user_id']]['in_group'] = $row['group_id'];
               }
            }
            $db->sql_freeresult($result);
         }
      }

      if (sizeof($address) && !$plaintext)
      {
         $template->assign_var('S_' . strtoupper($check_type) . '_RECIPIENT', true);

         foreach ($address as $type => $adr_ary)
         {
            foreach ($adr_ary as $id => $row)
            {
               $tpl_ary = array(
                  'IS_GROUP'   => ($type == 'group') ? true : false,
                  'IS_USER'   => ($type == 'user') ? true : false,
                  'UG_ID'      => $id,
                  'NAME'      => $row['name'],
                  'COLOUR'   => ($row['colour']) ? '#' . $row['colour'] : '',
                  'TYPE'      => $type,
               );

               if ($type == 'user')
               {
                  $tpl_ary = array_merge($tpl_ary, array(
                     'U_VIEW'      => get_username_string('profile', $id, $row['name'], $row['colour']),
                     'NAME_FULL'      => get_username_string('full', $id, $row['name'], $row['colour']),
                  ));
               }
               else
               {
                  $tpl_ary = array_merge($tpl_ary, array(
                     'U_VIEW'      => append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=group&amp;g=' . $id),
                  ));
               }

               $template->assign_block_vars($check_type . '_recipient', $tpl_ary);
            }
         }
      }

      $addresses[$check_type] = $address;
   }

   return $addresses;
}

/**
* Get folder status
*/
function get_folder_status($folder_id, $folder)
{
   global $db, $user, $config;

   if (isset($folder[$folder_id]))
   {
      $folder = $folder[$folder_id];
   }
   else
   {
      return false;
   }

   $return = array(
      'folder_name'   => $folder['folder_name'],
      'cur'         => $folder['num_messages'],
      'remaining'      => ($user->data['message_limit']) ? $user->data['message_limit'] - $folder['num_messages'] : 0,
      'max'         => $user->data['message_limit'],
      'percent'      => ($user->data['message_limit']) ? (($user->data['message_limit'] > 0) ? round(($folder['num_messages'] / $user->data['message_limit']) * 100) : 100) : 0,
   );

   $return['message']   = sprintf($user->lang['FOLDER_STATUS_MSG'], $return['percent'], $return['cur'], $return['max']);

   return $return;
}

//
// COMPOSE MESSAGES
//

/**
* Submit PM
*/
function submit_pm($mode, $subject, &$data, $put_in_outbox = true)
{
   global $db, $auth, $config, $phpEx, $template, $user, $phpbb_root_path;

   // We do not handle erasing pms here
   if ($mode == 'delete')
   {
      return false;
   }

   $current_time = time();

   // Collect some basic information about which tables and which rows to update/insert
   $sql_data = array();
   $root_level = 0;

   // Recipient Information
   $recipients = $to = $bcc = array();

   if ($mode != 'edit')
   {
      // Build Recipient List
      // u|g => array($user_id => 'to'|'bcc')
      $_types = array('u', 'g');
      foreach ($_types as $ug_type)
      {
         if (isset($data['address_list'][$ug_type]) && sizeof($data['address_list'][$ug_type]))
         {
            foreach ($data['address_list'][$ug_type] as $id => $field)
            {
               $id = (int) $id;

               // Do not rely on the address list being "valid"
               if (!$id || ($ug_type == 'u' && $id == ANONYMOUS))
               {
                  continue;
               }

               $field = ($field == 'to') ? 'to' : 'bcc';
               if ($ug_type == 'u')
               {
                  $recipients[$id] = $field;
               }
               ${$field}[] = $ug_type . '_' . $id;
            }
         }
      }

      if (isset($data['address_list']['g']) && sizeof($data['address_list']['g']))
      {
         // We need to check the PM status of group members (do they want to receive PM's?)
         // Only check if not a moderator or admin, since they are allowed to override this user setting
         $sql_allow_pm = (!$auth->acl_gets('a_', 'm_') && !$auth->acl_getf_global('m_')) ? ' AND u.user_allow_pm = 1' : '';

         $sql = 'SELECT u.user_type, ug.group_id, ug.user_id
            FROM ' . USERS_TABLE . ' u, ' . USER_GROUP_TABLE . ' ug
            WHERE ' . $db->sql_in_set('ug.group_id', array_keys($data['address_list']['g'])) . '
               AND ug.user_pending = 0
               AND u.user_id = ug.user_id
               AND u.user_type IN (' . USER_NORMAL . ', ' . USER_FOUNDER . ')' .
               $sql_allow_pm;
         $result = $db->sql_query($sql);

         while ($row = $db->sql_fetchrow($result))
         {
            $field = ($data['address_list']['g'][$row['group_id']] == 'to') ? 'to' : 'bcc';
            $recipients[$row['user_id']] = $field;
         }
         $db->sql_freeresult($result);
      }

      if (!sizeof($recipients))
      {
         trigger_error('NO_RECIPIENT');
      }
   }

   // First of all make sure the subject are having the correct length.
   $subject = truncate_string($subject);

   $db->sql_transaction('begin');

   $sql = '';

   switch ($mode)
   {
      case 'reply':
      case 'quote':
         $root_level = ($data['reply_from_root_level']) ? $data['reply_from_root_level'] : $data['reply_from_msg_id'];

         // Set message_replied switch for this user
         $sql = 'UPDATE ' . PRIVMSGS_TO_TABLE . '
            SET pm_replied = 1
            WHERE user_id = ' . $data['from_user_id'] . '
               AND msg_id = ' . $data['reply_from_msg_id'];

      // no break

      case 'forward':
      case 'post':
      case 'quotepost':
         $sql_data = array(
            'root_level'      => $root_level,
            'author_id'         => $data['from_user_id'],
            'icon_id'         => $data['icon_id'],
            'author_ip'         => $data['from_user_ip'],
            'message_time'      => $current_time,
            'enable_bbcode'      => $data['enable_bbcode'],
            'enable_smilies'   => $data['enable_smilies'],
            'enable_magic_url'   => $data['enable_urls'],
            'enable_sig'      => $data['enable_sig'],
            'message_subject'   => $subject,
            'message_text'      => $data['message'],
            'message_attachment'=> (!empty($data['attachment_data'])) ? 1 : 0,
            'bbcode_bitfield'   => $data['bbcode_bitfield'],
            'bbcode_uid'      => $data['bbcode_uid'],
            'to_address'      => implode(':', $to),
            'bcc_address'      => implode(':', $bcc),
            'message_reported'   => 0,
         );
      break;

      case 'edit':
         $sql_data = array(
            'icon_id'         => $data['icon_id'],
            'message_edit_time'   => $current_time,
            'enable_bbcode'      => $data['enable_bbcode'],
            'enable_smilies'   => $data['enable_smilies'],
            'enable_magic_url'   => $data['enable_urls'],
            'enable_sig'      => $data['enable_sig'],
            'message_subject'   => $subject,
            'message_text'      => $data['message'],
            'message_attachment'=> (!empty($data['attachment_data'])) ? 1 : 0,
            'bbcode_bitfield'   => $data['bbcode_bitfield'],
            'bbcode_uid'      => $data['bbcode_uid']
         );
      break;
   }

   if (sizeof($sql_data))
   {
      $query = '';

      if ($mode == 'post' || $mode == 'reply' || $mode == 'quote' || $mode == 'quotepost' || $mode == 'forward')
      {
         $db->sql_query('INSERT INTO ' . PRIVMSGS_TABLE . ' ' . $db->sql_build_array('INSERT', $sql_data));
         $data['msg_id'] = $db->sql_nextid();
      }
      else if ($mode == 'edit')
      {
         $sql = 'UPDATE ' . PRIVMSGS_TABLE . '
            SET message_edit_count = message_edit_count + 1, ' . $db->sql_build_array('UPDATE', $sql_data) . '
            WHERE msg_id = ' . $data['msg_id'];
         $db->sql_query($sql);
      }
   }

   if ($mode != 'edit')
   {
      if ($sql)
      {
         $db->sql_query($sql);
      }
      unset($sql);

      $sql_ary = array();
      foreach ($recipients as $user_id => $type)
      {
         $sql_ary[] = array(
            'msg_id'      => (int) $data['msg_id'],
            'user_id'      => (int) $user_id,
            'author_id'      => (int) $data['from_user_id'],
            'folder_id'      => PRIVMSGS_NO_BOX,
            'pm_new'      => 1,
            'pm_unread'      => 1,
            'pm_forwarded'   => ($mode == 'forward') ? 1 : 0
         );
      }

      $db->sql_multi_insert(PRIVMSGS_TO_TABLE, $sql_ary);

      $sql = 'UPDATE ' . USERS_TABLE . '
         SET user_new_privmsg = user_new_privmsg + 1, user_unread_privmsg = user_unread_privmsg + 1, user_last_privmsg = ' . time() . '
         WHERE ' . $db->sql_in_set('user_id', array_keys($recipients));
      $db->sql_query($sql);

      // Put PM into outbox
      if ($put_in_outbox)
      {
         $db->sql_query('INSERT INTO ' . PRIVMSGS_TO_TABLE . ' ' . $db->sql_build_array('INSERT', array(
            'msg_id'      => (int) $data['msg_id'],
            'user_id'      => (int) $data['from_user_id'],
            'author_id'      => (int) $data['from_user_id'],
            'folder_id'      => PRIVMSGS_OUTBOX,
            'pm_new'      => 0,
            'pm_unread'      => 0,
            'pm_forwarded'   => ($mode == 'forward') ? 1 : 0))
         );
      }
   }

   // Set user last post time
   if ($mode == 'reply' || $mode == 'quote' || $mode == 'quotepost' || $mode == 'forward' || $mode == 'post')
   {
      $sql = 'UPDATE ' . USERS_TABLE . "
         SET user_lastpost_time = $current_time
         WHERE user_id = " . $data['from_user_id'];
      $db->sql_query($sql);
   }

   // Submit Attachments
   if (!empty($data['attachment_data']) && $data['msg_id'] && in_array($mode, array('post', 'reply', 'quote', 'quotepost', 'edit', 'forward')))
   {
      $space_taken = $files_added = 0;
      $orphan_rows = array();

      foreach ($data['attachment_data'] as $pos => $attach_row)
      {
         $orphan_rows[(int) $attach_row['attach_id']] = array();
      }

      if (sizeof($orphan_rows))
      {
         $sql = 'SELECT attach_id, filesize, physical_filename
            FROM ' . ATTACHMENTS_TABLE . '
            WHERE ' . $db->sql_in_set('attach_id', array_keys($orphan_rows)) . '
               AND in_message = 1
               AND is_orphan = 1
               AND poster_id = ' . $user->data['user_id'];
         $result = $db->sql_query($sql);

         $orphan_rows = array();
         while ($row = $db->sql_fetchrow($result))
         {
            $orphan_rows[$row['attach_id']] = $row;
         }
         $db->sql_freeresult($result);
      }

      foreach ($data['attachment_data'] as $pos => $attach_row)
      {
         if ($attach_row['is_orphan'] && !isset($orphan_rows[$attach_row['attach_id']]))
         {
            continue;
         }

         if (!$attach_row['is_orphan'])
         {
            // update entry in db if attachment already stored in db and filespace
            $sql = 'UPDATE ' . ATTACHMENTS_TABLE . "
               SET attach_comment = '" . $db->sql_escape($attach_row['attach_comment']) . "'
               WHERE attach_id = " . (int) $attach_row['attach_id'] . '
                  AND is_orphan = 0';
            $db->sql_query($sql);
         }
         else
         {
            // insert attachment into db
            if (!@file_exists($phpbb_root_path . $config['upload_path'] . '/' . utf8_basename($orphan_rows[$attach_row['attach_id']]['physical_filename'])))
            {
               continue;
            }

            $space_taken += $orphan_rows[$attach_row['attach_id']]['filesize'];
            $files_added++;

            $attach_sql = array(
               'post_msg_id'      => $data['msg_id'],
               'topic_id'         => 0,
               'is_orphan'         => 0,
               'poster_id'         => $data['from_user_id'],
               'attach_comment'   => $attach_row['attach_comment'],
            );

            $sql = 'UPDATE ' . ATTACHMENTS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $attach_sql) . '
               WHERE attach_id = ' . $attach_row['attach_id'] . '
                  AND is_orphan = 1
                  AND poster_id = ' . $user->data['user_id'];
            $db->sql_query($sql);
         }
      }

      if ($space_taken && $files_added)
      {
         set_config_count('upload_dir_size', $space_taken, true);
         set_config_count('num_files', $files_added, true);
      }
   }

   // Delete draft if post was loaded...
   $draft_id = request_var('draft_loaded', 0);
   if ($draft_id)
   {
      $sql = 'DELETE FROM ' . DRAFTS_TABLE . "
         WHERE draft_id = $draft_id
            AND user_id = " . $data['from_user_id'];
      $db->sql_query($sql);
   }

   $db->sql_transaction('commit');

   // Send Notifications
// BEGIN mobiquo Mod push service
   if(!empty($data['msg_id']) && isset($config['mobiquo_push']))
   {
      require_once($phpbb_root_path . $config['tapatalkdir'].'/push_hook.' . $phpEx);
       tapatalk_push_pm($user_id, $data['msg_id'], $subject);
   }
// END mobiquo Mod
   if ($mode != 'edit')
   {
      pm_notification($mode, $data['from_username'], $recipients, $subject, $data['message'], $data['msg_id']);
   }

   return $data['msg_id'];
}

/**
* PM Notification
*/
function pm_notification($mode, $author, $recipients, $subject, $message, $msg_id)
{
   global $db, $user, $config, $phpbb_root_path, $phpEx, $auth;

   $subject = censor_text($subject);

   // Exclude guests, current user and banned users from notifications
   unset($recipients[ANONYMOUS], $recipients[$user->data['user_id']]);

   if (!sizeof($recipients))
   {
      return;
   }

   if (!function_exists('phpbb_get_banned_user_ids'))
   {
      include($phpbb_root_path . 'includes/functions_user.' . $phpEx);
   }
   $banned_users = phpbb_get_banned_user_ids(array_keys($recipients));
   $recipients = array_diff(array_keys($recipients), $banned_users);

   if (!sizeof($recipients))
   {
      return;
   }

   $sql = 'SELECT user_id, username, user_email, user_lang, user_notify_pm, user_notify_type, user_jabber
      FROM ' . USERS_TABLE . '
      WHERE ' . $db->sql_in_set('user_id', $recipients);
   $result = $db->sql_query($sql);

   $msg_list_ary = array();
   while ($row = $db->sql_fetchrow($result))
   {
      if ($row['user_notify_pm'] == 1 && trim($row['user_email']))
      {
         $msg_list_ary[] = array(
            'method'   => $row['user_notify_type'],
            'email'      => $row['user_email'],
            'jabber'   => $row['user_jabber'],
            'name'      => $row['username'],
            'lang'      => $row['user_lang']
         );
      }
   }
   $db->sql_freeresult($result);

   if (!sizeof($msg_list_ary))
   {
      return;
   }

   include_once($phpbb_root_path . 'includes/functions_messenger.' . $phpEx);
   $messenger = new messenger();

   foreach ($msg_list_ary as $pos => $addr)
   {
      $messenger->template('privmsg_notify', $addr['lang']);

      $messenger->to($addr['email'], $addr['name']);
      $messenger->im($addr['jabber'], $addr['name']);

      $messenger->assign_vars(array(
         'SUBJECT'      => htmlspecialchars_decode($subject),
         'AUTHOR_NAME'   => htmlspecialchars_decode($author),
         'USERNAME'      => htmlspecialchars_decode($addr['name']),

         'U_INBOX'         => generate_board_url() . "/ucp.$phpEx?i=pm&folder=inbox",
         'U_VIEW_MESSAGE'   => generate_board_url() . "/ucp.$phpEx?i=pm&mode=view&p=$msg_id",
      ));

      $messenger->send($addr['method']);
   }
   unset($msg_list_ary);

   $messenger->save_queue();

   unset($messenger);
}

/**
* Display Message History
*/
function message_history($msg_id, $user_id, $message_row, $folder, $in_post_mode = false)
{
   global $db, $user, $config, $template, $phpbb_root_path, $phpEx, $auth, $bbcode;

   // Select all receipts and the author from the pm we currently view, to only display their pm-history
   $sql = 'SELECT author_id, user_id
      FROM ' . PRIVMSGS_TO_TABLE . "
      WHERE msg_id = $msg_id
         AND folder_id <> " . PRIVMSGS_HOLD_BOX;
   $result = $db->sql_query($sql);

   $recipients = array();
   while ($row = $db->sql_fetchrow($result))
   {
      $recipients[] = (int) $row['user_id'];
      $recipients[] = (int) $row['author_id'];
   }
   $db->sql_freeresult($result);
   $recipients = array_unique($recipients);

   // Get History Messages (could be newer)
   $sql = 'SELECT t.*, p.*, u.*
      FROM ' . PRIVMSGS_TABLE . ' p, ' . PRIVMSGS_TO_TABLE . ' t, ' . USERS_TABLE . ' u
      WHERE t.msg_id = p.msg_id
         AND p.author_id = u.user_id
         AND t.folder_id NOT IN (' . PRIVMSGS_NO_BOX . ', ' . PRIVMSGS_HOLD_BOX . ')
         AND ' . $db->sql_in_set('t.author_id', $recipients, false, true) . "
         AND t.user_id = $user_id";

   // We no longer need those.
   unset($recipients);

   if (!$message_row['root_level'])
   {
      $sql .= " AND (p.root_level = $msg_id OR (p.root_level = 0 AND p.msg_id = $msg_id))";
   }
   else
   {
      $sql .= " AND (p.root_level = " . $message_row['root_level'] . ' OR p.msg_id = ' . $message_row['root_level'] . ')';
   }
   $sql .= ' ORDER BY p.message_time DESC';

   $result = $db->sql_query($sql);
   $row = $db->sql_fetchrow($result);

   if (!$row)
   {
      $db->sql_freeresult($result);
      return false;
   }

   $title = $row['message_subject'];

   $rowset = array();
   $bbcode_bitfield = '';
   $folder_url = append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm') . '&amp;folder=';

   do
   {
      $folder_id = (int) $row['folder_id'];

      $row['folder'][] = (isset($folder[$folder_id])) ? '<a href="' . $folder_url . $folder_id . '">' . $folder[$folder_id]['folder_name'] . '</a>' : $user->lang['UNKNOWN_FOLDER'];

      if (isset($rowset[$row['msg_id']]))
      {
         $rowset[$row['msg_id']]['folder'][] = (isset($folder[$folder_id])) ? '<a href="' . $folder_url . $folder_id . '">' . $folder[$folder_id]['folder_name'] . '</a>' : $user->lang['UNKNOWN_FOLDER'];
      }
      else
      {
         $rowset[$row['msg_id']] = $row;
         $bbcode_bitfield = $bbcode_bitfield | base64_decode($row['bbcode_bitfield']);
      }
   }
   while ($row = $db->sql_fetchrow($result));
   $db->sql_freeresult($result);

   if (sizeof($rowset) == 1 && !$in_post_mode)
   {
      return false;
   }

   // Instantiate BBCode class
   if ((empty($bbcode) || $bbcode === false) && $bbcode_bitfield !== '')
   {
      if (!class_exists('bbcode'))
      {
         include($phpbb_root_path . 'includes/bbcode.' . $phpEx);
      }
      $bbcode = new bbcode(base64_encode($bbcode_bitfield));
   }

   $title = censor_text($title);

   $url = append_sid("{$phpbb_root_path}ucp.$phpEx", 'i=pm');
   $next_history_pm = $previous_history_pm = $prev_id = 0;

   // Re-order rowset to be able to get the next/prev message rows...
   $rowset = array_values($rowset);

   for ($i = 0, $size = sizeof($rowset); $i < $size; $i++)
   {
      $row = &$rowset[$i];
      $id = (int) $row['msg_id'];

      $author_id   = $row['author_id'];
      $folder_id   = (int) $row['folder_id'];

      $subject   = $row['message_subject'];
      $message   = $row['message_text'];

      $message = censor_text($message);

      $decoded_message = false;

      if ($in_post_mode && $auth->acl_get('u_sendpm') && $author_id != ANONYMOUS)
      {
         $decoded_message = $message;
         decode_message($decoded_message, $row['bbcode_uid']);

         $decoded_message = bbcode_nl2br($decoded_message);
      }

      if ($row['bbcode_bitfield'])
      {
         $bbcode->bbcode_second_pass($message, $row['bbcode_uid'], $row['bbcode_bitfield']);
      }

      $message = bbcode_nl2br($message);
      $message = smiley_text($message, !$row['enable_smilies']);

      $subject = censor_text($subject);

      if ($id == $msg_id)
      {
         $next_history_pm = (isset($rowset[$i + 1])) ? (int) $rowset[$i + 1]['msg_id'] : 0;
         $previous_history_pm = $prev_id;
      }

      $template->assign_block_vars('history_row', array(
         'MESSAGE_AUTHOR_QUOTE'      => (($decoded_message) ? addslashes(get_username_string('username', $author_id, $row['username'], $row['user_colour'], $row['username'])) : ''),
         'MESSAGE_AUTHOR_FULL'      => get_username_string('full', $author_id, $row['username'], $row['user_colour'], $row['username']),
         'MESSAGE_AUTHOR_COLOUR'      => get_username_string('colour', $author_id, $row['username'], $row['user_colour'], $row['username']),
         'MESSAGE_AUTHOR'         => get_username_string('username', $author_id, $row['username'], $row['user_colour'], $row['username']),
         'U_MESSAGE_AUTHOR'         => get_username_string('profile', $author_id, $row['username'], $row['user_colour'], $row['username']),

         'SUBJECT'         => $subject,
         'SENT_DATE'         => $user->format_date($row['message_time']),
         'MESSAGE'         => $message,
         'FOLDER'         => implode(', ', $row['folder']),
         'DECODED_MESSAGE'   => $decoded_message,

         'S_CURRENT_MSG'      => ($row['msg_id'] == $msg_id),
         'S_AUTHOR_DELETED'   => ($author_id == ANONYMOUS) ? true : false,
         'S_IN_POST_MODE'   => $in_post_mode,

         'MSG_ID'         => $row['msg_id'],
         'U_VIEW_MESSAGE'   => "$url&amp;f=$folder_id&amp;p=" . $row['msg_id'],
         'U_QUOTE'         => (!$in_post_mode && $auth->acl_get('u_sendpm') && $author_id != ANONYMOUS) ? "$url&amp;mode=compose&amp;action=quote&amp;f=" . $folder_id . "&amp;p=" . $row['msg_id'] : '',
         'U_POST_REPLY_PM'   => ($author_id != $user->data['user_id'] && $author_id != ANONYMOUS && $auth->acl_get('u_sendpm')) ? "$url&amp;mode=compose&amp;action=reply&amp;f=$folder_id&amp;p=" . $row['msg_id'] : '')
      );
      unset($rowset[$i]);
      $prev_id = $id;
   }

   $template->assign_vars(array(
      'QUOTE_IMG'         => $user->img('icon_post_quote', $user->lang['REPLY_WITH_QUOTE']),
      'HISTORY_TITLE'      => $title,

      'U_VIEW_NEXT_HISTORY'      => ($next_history_pm) ? "$url&amp;p=" . $next_history_pm : '',
      'U_VIEW_PREVIOUS_HISTORY'   => ($previous_history_pm) ? "$url&amp;p=" . $previous_history_pm : '',
   ));

   return true;
}

/**
* Set correct users max messages in PM folder.
* If several group memberships define different amount of messages, the highest will be chosen.
*/
function set_user_message_limit()
{
   global $user, $db, $config;

   // Get maximum about from user memberships - if it is 0, there is no limit set and we use the maximum value within the config.
   $sql = 'SELECT MAX(g.group_message_limit) as max_message_limit
      FROM ' . GROUPS_TABLE . ' g, ' . USER_GROUP_TABLE . ' ug
      WHERE ug.user_id = ' . $user->data['user_id'] . '
         AND ug.user_pending = 0
         AND ug.group_id = g.group_id';
   $result = $db->sql_query($sql);
   $message_limit = (int) $db->sql_fetchfield('max_message_limit');
   $db->sql_freeresult($result);

   $user->data['message_limit'] = (!$message_limit) ? $config['pm_max_msgs'] : $message_limit;
}

/**
* Generates an array of coloured recipient names from a list of PMs - (groups & users)
*
* @param   array   $pm_by_id   An array of rows from PRIVMSGS_TABLE, keys are the msg_ids.
*
* @return   array            2D Array: array(msg_id => array('username or group string', ...), ...)
*                        Usernames are generated with {@link get_username_string get_username_string}
*                        Groups are coloured and have a link to the membership page
*/
function get_recipient_strings($pm_by_id)
{
   global $db, $phpbb_root_path, $phpEx, $user;

   $address_list = $recipient_list = $address = array();

   $_types = array('u', 'g');

   foreach ($pm_by_id as $message_id => $row)
   {
      $address[$message_id] = rebuild_header(array('to' => $row['to_address'], 'bcc' => $row['bcc_address']));

      foreach ($_types as $ug_type)
      {
         if (isset($address[$message_id][$ug_type]) && sizeof($address[$message_id][$ug_type]))
         {
            foreach ($address[$message_id][$ug_type] as $ug_id => $in_to)
            {
               $recipient_list[$ug_type][$ug_id] = array('name' => $user->lang['NA'], 'colour' => '');
            }
         }
      }
   }

   foreach ($_types as $ug_type)
   {
      if (!empty($recipient_list[$ug_type]))
      {
         if ($ug_type == 'u')
         {
            $sql = 'SELECT user_id as id, username as name, user_colour as colour
               FROM ' . USERS_TABLE . '
               WHERE ';
         }
         else
         {
            $sql = 'SELECT group_id as id, group_name as name, group_colour as colour, group_type
               FROM ' . GROUPS_TABLE . '
               WHERE ';
         }
         $sql .= $db->sql_in_set(($ug_type == 'u') ? 'user_id' : 'group_id', array_map('intval', array_keys($recipient_list[$ug_type])));

         $result = $db->sql_query($sql);

         while ($row = $db->sql_fetchrow($result))
         {
            if ($ug_type == 'g')
            {
               $row['name'] = ($row['group_type'] == GROUP_SPECIAL) ? $user->lang['G_' . $row['name']] : $row['name'];
            }

            $recipient_list[$ug_type][$row['id']] = array('name' => $row['name'], 'colour' => $row['colour']);
         }
         $db->sql_freeresult($result);
      }
   }

   foreach ($address as $message_id => $adr_ary)
   {
      foreach ($adr_ary as $type => $id_ary)
      {
         foreach ($id_ary as $ug_id => $_id)
         {
            if ($type == 'u')
            {
               $address_list[$message_id][] = get_username_string('full', $ug_id, $recipient_list[$type][$ug_id]['name'], $recipient_list[$type][$ug_id]['colour']);
            }
            else
            {
               $user_colour = ($recipient_list[$type][$ug_id]['colour']) ? ' style="font-weight: bold; color:#' . $recipient_list[$type][$ug_id]['colour'] . '"' : '';
               $link = '<a href="' . append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=group&amp;g=' . $ug_id) . '"' . $user_colour . '>';
               $address_list[$message_id][] = $link . $recipient_list[$type][$ug_id]['name'] . (($link) ? '</a>' : '');
            }
         }
      }
   }

   return $address_list;
}

?>
I don't need to "get a life." I'm a Gamer, I have lots of lives!
Q: Whats a hash and a root password?
A: hash gets you high, root password gives you god powers, combine the 2 and you are invincible.
User avatar
Mickroz
Registered User
Posts: 661
Joined: Thu Mar 06, 2003 11:20 pm
Location: Netherlands

Re: After Install Cannot Delete PM

by Joshua203 » Tue Sep 04, 2012 3:18 pm

I don't know if it's the forum here or the tool you used to copy the code but the full code is a one-liner if i copy it, making it very hard to compare, please attach the actual file.
Image
http://DutchaGoGo.com (development/under construction ..forever?¿?) ;)
User avatar
Joshua203
Registered User
Posts: 227
Joined: Tue Jul 21, 2009 7:01 pm
Location: Rotterdam, Netherlands, Europe, Earth.
Name: Joshua 203

Re: After Install Cannot Delete PM

by Mickroz » Tue Sep 04, 2012 3:45 pm

here you go.
Attachments
functions_privmsgs.zip
(14.58 KiB) Downloaded 152 times
I don't need to "get a life." I'm a Gamer, I have lots of lives!
Q: Whats a hash and a root password?
A: hash gets you high, root password gives you god powers, combine the 2 and you are invincible.
User avatar
Mickroz
Registered User
Posts: 661
Joined: Thu Mar 06, 2003 11:20 pm
Location: Netherlands

Re: After Install Cannot Delete PM

by tumba25 » Tue Sep 04, 2012 4:51 pm

I run this on phpBB 3.0.10, I'll upgrade to 3.0.11 later today or tomorrow. I have no issues with deleting PMs. Everything works as it should.

Maybe you have some other MOD that interferes with it.
Need a mod/extension created/installed, other custom-coded solution or a server admin? https://tumba25.net
User avatar
tumba25
Former Team Member
Posts: 4430
Joined: Wed Jun 06, 2007 6:42 am
Location: Kokkola, Finland.
Name: Jari Kanerva

Re: After Install Cannot Delete PM

by Joshua203 » Tue Sep 04, 2012 6:33 pm

Please rename your old file and test this one ( I tried saving your mods and not adding mine :lol: )

functions_privmsgs.zip
(13.68 KiB) Downloaded 145 times


I must say I wonder about your version or how accurate you updated.
Last edited by Joshua203 on Tue Sep 04, 2012 8:20 pm
Image
http://DutchaGoGo.com (development/under construction ..forever?¿?) ;)
User avatar
Joshua203
Registered User
Posts: 227
Joined: Tue Jul 21, 2009 7:01 pm
Location: Rotterdam, Netherlands, Europe, Earth.
Name: Joshua 203

Re: After Install Cannot Delete PM

by Mickroz » Tue Sep 04, 2012 7:50 pm

thanks, will try this.
I update when a new version is out with the auto updater.
I don't need to "get a life." I'm a Gamer, I have lots of lives!
Q: Whats a hash and a root password?
A: hash gets you high, root password gives you god powers, combine the 2 and you are invincible.
User avatar
Mickroz
Registered User
Posts: 661
Joined: Thu Mar 06, 2003 11:20 pm
Location: Netherlands

Re: After Install Cannot Delete PM

by Joshua203 » Tue Sep 04, 2012 8:27 pm

Well it's always easier to doubt someone else his work instead of your own, maybe my own updates are inaccurate who knows?

Anyway I tried saving something tapatalk related that was in your file but there were some more big differences.
The file I attached is basicly the file I use with some mods removed and your tapa-thingy added.
Feel free to compare both.
Image
http://DutchaGoGo.com (development/under construction ..forever?¿?) ;)
User avatar
Joshua203
Registered User
Posts: 227
Joined: Tue Jul 21, 2009 7:01 pm
Location: Rotterdam, Netherlands, Europe, Earth.
Name: Joshua 203