phpBB • Free and Open Source Forum Software

Leinad4Mind · by **Leinad4Mind** » Sat Sep 08, 2012 2:32 pm

After update to 3.0.11 I've the same issue. But I can delete if in "ucp.php?i=pm&mode=view", I just can't delete in "ucp.php?i=pm". So if I need to delete many pm's I can't. But if I enter one by one and delete, it works.

3.0.10 to 3.0.11 has done 2 changes that broke up this mod, it was on those 2 files:

/includes/functions_privmsgs.php,
/styles/prosilver/template/ucp_pm_message_header.html

I will try to see if I discover where the problem is.

Cheers

Leinad4Mind · by **Leinad4Mind** » Sat Sep 08, 2012 2:56 pm

Problem FOUND and SOLVED!!!

The problem is HERE: /styles/prosilver/template/ucp_pm_message_header.html

We have in the top of that file:
<form id="viewfolder" method="post" action="{S_PM_ACTION}">

We need to move that line to the end (last line) of the file.
And it will solve all the problems!

Cheers!!! ; )

Mickroz · by **Mickroz** » Sat Sep 08, 2012 3:01 pm

so basicly move the searchbox out of the form?

Leinad4Mind · by **Leinad4Mind** » Sat Sep 08, 2012 3:04 pm

It's nothing about the searchbox, but about the button itself. The Go button. That's why when you press it, it doesn't do what you want.

Well you should have:

Code: Select all

<h2>{L_TITLE}<!-- IF CUR_FOLDER_NAME -->: {CUR_FOLDER_NAME}<!-- ENDIF --></h2>

<form id="viewfolder" method="post" action="{S_PM_ACTION}">

<div class="panel">
   <div class="inner"><span class="corners-top"><span></span></span>

you need to remove the line I mention:

Code: Select all

<h2>{L_TITLE}<!-- IF CUR_FOLDER_NAME -->: {CUR_FOLDER_NAME}<!-- ENDIF --></h2>

<div class="panel">
   <div class="inner"><span class="corners-top"><span></span></span>

And in the end of that file:

Code: Select all

         <!-- ENDIF -->
      </li>
   </ul>
   <!-- ENDIF -->

It will be:

Code: Select all

         <!-- ENDIF -->
      </li>
   </ul>
   <!-- ENDIF -->
<form id="viewfolder" method="post" action="{S_PM_ACTION}">

Cheers

EDIT: I don't know if that change will broke up something new of the 3.0.11 installation. x'D But I don't think so :p

Mickroz · by **Mickroz** » Sat Sep 08, 2012 3:07 pm

i understand what you meant

but since that is core code, i was wondering how we can move the pm search code

Leinad4Mind · by **Leinad4Mind** » Sat Sep 08, 2012 3:09 pm

But maybe the problem is in the core code ahahah, but I see what you mean, I will take another look

Mickroz · by **Mickroz** » Sat Sep 08, 2012 3:14 pm

hehe

nice thanks

Leinad4Mind · by **Leinad4Mind** » Sat Sep 08, 2012 3:17 pm

Well here the many solutions:

Code: Select all

   <!-- IF S_DISPLAY_SEARCHBOX -->
      <!-- INCLUDE ucp_pm_search.html -->
   <!-- ENDIF -->

this code is the culprit. It needs to be before the "<form id="viewfolder" method="post" action="{S_PM_ACTION}">" code.

So, if we put:

Code: Select all

<h2>{L_TITLE}<!-- IF CUR_FOLDER_NAME -->: {CUR_FOLDER_NAME}<!-- ENDIF --></h2>

   <!-- IF S_DISPLAY_SEARCHBOX -->
      <!-- INCLUDE ucp_pm_search.html -->
   <!-- ENDIF -->
   
<form id="viewfolder" method="post" action="{S_PM_ACTION}">

It will works, but the search box it will be in a wrong position... and it will be ugly!

So I've tried another thing:

Code: Select all

<h2>{L_TITLE}<!-- IF CUR_FOLDER_NAME -->: {CUR_FOLDER_NAME}<!-- ENDIF --></h2>

<form id="viewfolder" method="post" action="{S_PM_ACTION}">

<div class="panel">
   <div class="inner"><span class="corners-top"><span></span></span>

   <!-- IF FOLDER_STATUS and FOLDER_MAX_MESSAGES neq 0 --><p>{FOLDER_STATUS}</p>
   <div class="pm-bar-outer">
      <div class="pm-bar-inner">
         <div style="width:{FOLDER_PERCENT}%;" class="<!-- IF FOLDER_PERCENT gt 80 -->pm-bar-alert<!-- ELSE -->pm-bar-ok<!-- ENDIF -->"></div>
      </div>
   </div>   
   <!-- ENDIF -->

   <!-- IF U_POST_REPLY_PM or U_POST_NEW_TOPIC or U_FORWARD_PM -->
      <div class="buttons">
         <!-- IF U_POST_REPLY_PM --><div class="pmreply-icon"><a title="{L_POST_REPLY_PM}" href="{U_POST_REPLY_PM}"><span></span>{L_POST_REPLY_PM}</a></div>
         <!-- ELSEIF U_POST_NEW_TOPIC --><div class="newpm-icon"><a href="{U_POST_NEW_TOPIC}" accesskey="n" title="{L_UCP_PM_COMPOSE}"><span></span>{L_UCP_PM_COMPOSE}</a></div><!-- ENDIF -->
         <!-- IF U_FORWARD_PM --><div class="forwardpm-icon"><a title="{L_POST_FORWARD_PM}" href="{U_FORWARD_PM}"><span></span>{L_FORWARD_PM}</a></div><!-- ENDIF -->
         <!-- IF U_POST_REPLY_PM and S_PM_RECIPIENTS gt 1 --><div class="reply-all"><a class="left" title="{L_REPLY_TO_ALL}" href="{U_POST_REPLY_ALL}">{L_REPLY_TO_ALL}</a></div><!-- ENDIF -->         
      </div>
   <!-- ENDIF -->


   <!-- IF S_DISPLAY_SEARCHBOX -->
      <!-- INCLUDE ucp_pm_search.html -->
      <form id="viewfolder" method="post" action="{S_PM_ACTION}">
   <!-- ENDIF -->
   <!-- IF TOTAL_MESSAGES or S_VIEW_MESSAGE -->
   <ul class="linklist">
      <li class="rightside pagination">
         <!-- IF S_VIEW_MESSAGE --><a class="{S_CONTENT_FLOW_BEGIN}" href="{U_CURRENT_FOLDER}">{L_RETURN_TO} {CUR_FOLDER_NAME}</a><!-- ENDIF -->
         <!-- IF FOLDER_CUR_MESSAGES neq 0 -->
            <!-- IF TOTAL_MESSAGES -->{TOTAL_MESSAGES}<!-- ENDIF -->
            <!-- IF PAGE_NUMBER --><!-- IF PAGINATION --> &bull; <a href="#" onclick="jumpto(); return false;" title="{L_JUMP_TO_PAGE}">{PAGE_NUMBER}</a> &bull; <span>{PAGINATION}</span><!-- ELSE --> &bull; {PAGE_NUMBER}<!-- ENDIF --><!-- ENDIF -->
         <!-- ENDIF -->
      </li>
   </ul>
   <!-- ENDIF -->

I left all the same but I've put a new same line:

Code: Select all

   <!-- IF S_DISPLAY_SEARCHBOX -->
      <!-- INCLUDE ucp_pm_search.html -->
      <form id="viewfolder" method="post" action="{S_PM_ACTION}">
   <!-- ENDIF -->

And it works too...

If anyone get a better solution, we are all listeners xD

PS: I will see if I found something else on ucp_pm_search.html x'D

EDIT2:

Editing the ucp_pm_search.html, will solved the problem without changing the ucp_pm_message_header.html nor the corecode.
The 1st line of ucp_pm_search.html is the culprit... cause it use too an "method=post", that's why when you click on "Go" it will not do the delete or mark, but it will do an search. That's why it appears "whitout messages".

So the new solution is to put "<form id="viewfolder" method="post" action="{S_PM_ACTION}">" in the end of that file...

But IMO, all my previous solutions will be the same as that one... but well... I haven't change the core code, if that matters ^^

sparkzter · by **sparkzter** » Tue Sep 11, 2012 10:07 pm

Code: Select all

<form id="viewfolder" method="post" action="{S_PM_ACTION}">

adding the above to the bottom of ucp_pm_search.html works for me...attached is the modded file which fixes the problem

thanks for the help guys

Mickroz · by **Mickroz** » Wed Sep 12, 2012 8:32 am

nice Leinad4Mind, awsome bughunt

, now tumba25 can update his mod

mwh65 · by **mwh65** » Fri Sep 28, 2012 5:10 pm

If it helps anyone I gave the PM Search its own panel. This is for phpBB 3.0.11 ...

Open ucp_message_header.html then add the following ...

Code: Select all

<!-- IF S_DISPLAY_SEARCHBOX -->
<div class="panel">
        <div class="inner"><span class="corners-top"><span></span></span>

                <!-- INCLUDE ucp_pm_search.html -->
        
        <span class="corners-bottom"><span></span></span></div>
</div>
<!-- ENDIF -->

AFTER ...

Code: Select all

<h2>{L_TITLE}<!-- IF CUR_FOLDER_NAME -->: {CUR_FOLDER_NAME}<!-- ENDIF --></h2>

Leinad4Mind · by **Leinad4Mind** » Mon Oct 01, 2012 5:14 pm

Thanks for that mwh65! I wanted that but was lazy to do it ahah.

Cheers!

yamahar · by **yamahar** » Wed May 08, 2013 8:20 pm

I have given up for now on this mod, but when I remove using automod (which finishes with no errors) I still have the Search PM in the UCP - when I click on it I get an error page

General Error
No message action specified.

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/includes/ucp/ucp_pm.php
LINE: 401
CALL: trigger_error()

FILE: [ROOT]/includes/functions_module.php
LINE: 507
CALL: ucp_pm->main()

FILE: [ROOT]/ucp.php
LINE: 358
CALL: p_master->load_active()

What do I need to remove to fix this so the Search PM is gone forever ?

Redbull254 · by **Redbull254** » Mon May 20, 2013 6:57 pm

Hallo ,

thanks for the solution.

tehohn · by **tehohn** » Thu Dec 05, 2013 5:48 pm

Good detective work everyone

And thank you mwh65 ! , your patch works perfectly on my 3.0.12 installation, running Lucid Teal, prosilver and CA Black themes.

Just mind to remove:

Code: Select all

<!-- IF S_DISPLAY_SEARCHBOX -->
      <!-- INCLUDE ucp_pm_search.html -->
   <!-- ENDIF -->

First IF it already exists in your ucp_message_header.html template files.

phpBB • Free and Open Source Forum Software

PM Search

After Install Cannot Delete PM - PM Search

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

Re: After Install Cannot Delete PM

advertisements