Hey Everyone,
Just posting a small work around for a minor issue that I noticed with this mod.
The issue is that when you try to delete the first post (which is the start of the topic) by using the checkbox in the edit post, it goes to the prime delete confirm page and when you choose to permanently delete the topic it just redirects to the edit post page instead of any other action.
This delete is what I'm referring to, and only for the first post does it have the issue. Still goes to the prime confirm, but the prime confirm permanent delete no work for topic start.
(Side note: Yes I know, my topic icons are fabulous, LOL)
The mod still will delete posts using the check box to delete when editing posts, and all other delete functions with this mod work perfectly as far as clicking the delete button, using quick mod, and from the mcp, so those are fine, several options offered still for deleting the topics and posts and with those can still delete topics and posts permanently.
So since using the checkbox to delete posts still works, again only does not work for the first post.
This is not the fix to make it delete the topic start using that check box in edit post, but rather a work around to hide the option only in the first post of the topic.
Since we already have a template variable that works for this in posting.php, which has statements to make is recognize first post and edit post, and looks like so.
Note: this part is for reference only and learning. You don't need to do anything with it because it's already present, just displaying the code here again to show where the template variable came from and why I used it.
Code: Select all
if ($mode == 'post' || ($mode == 'edit' && $post_data['topic_first_post_id'] == $post_data['post_id']))
{
$template->assign_var('S_NEW_MESSAGE', true);
}
Work-Around Edits begin:
//Prosilver (and all prosilver based styles)
Open: styles/prosilver/template/posting_editor.html
Find:
Code: Select all
<!-- IF S_DELETE_ALLOWED -->
Code: Select all
<!-- IF S_DELETE_ALLOWED and not S_NEW_MESSAGE -->
//Subsilver2 (and all subsilver2 based styles)
Open: styles/prosilver/template/posting_body.html
Find:
Code: Select all
<!-- IF S_DELETE_ALLOWED -->
Code: Select all
<!-- IF S_DELETE_ALLOWED and not S_NEW_MESSAGE -->
Clear your cache and refresh your templates. If someone else wants to make an actual fix where the delete through using the checkbox redirect does not just redirect to the editing page again and actually does delete topics, then by all means post it.
The work-around is good enough for me because frankly having 3 other delete options to delete a topic doing the same options desired is enough for me. Otherwise I would try at the actual fix myself, but since it does not throw any errors and this is the only issue I have with this mod and love it, I am not going to even attempt it.
Perhaps it was that way on purpose to begin with, lol, not sure but here ya go folks, Enjoy!
__________________________________
Disclaimer: I decided to share my edits, fixes, addons, companion mods, e.t.c. for "wiki" type purposes and for those out there like me who are on older versions of phpbb3 still. Also for those who still have or wanted this mod to have a new feature or a fix this is for you!
