phpBB • Free and Open Source Forum Software

RSS Facebook Twitter
Menu

prosilver Special Edition

Missing CSS file on pages used for printing - prosilver Special Edition

Missing CSS file on pages used for printing

by cabot » Thu Jul 14, 2022 8:02 am

Hello,

The bidi.css file loaded by the PM and topic print pages is missing in the /theme/ directory.

It is called in the current style by the parent style files in ucp_pm_viewmessage_print.html and viewtopic_print.html :

Code: Select all

<link href="{T_THEME_PATH}/bidi.css" rel="stylesheet">
User avatar
cabot
Jr. Style Validator
Posts: 990
Joined: Sat Jan 07, 2012 4:16 pm
Top

Re: Missing CSS file on pages used for printing

by Raul [ThE KuKa] » Thu Jul 28, 2022 5:54 pm

Hi,

bidi.css file is loaded from the prosilver style "inherit".

Code: Select all

<!-- IF S_CONTENT_DIRECTION eq 'rtl' -->
	<link href="{ROOT_PATH}styles/prosilver/theme/bidi.css?assets_version={T_ASSETS_VERSION}" rel="stylesheet">
<!-- ENDIF -->
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies | Styles Queue Stats :warning:

If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate.
:flag_es: phpBB Spain - Online Since 2003 :heart:


User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 11148
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Top

Re: Missing CSS file on pages used for printing

by cabot » Sat Jul 30, 2022 9:52 am

Yep, this is true for overall_header.html and simple_header.html.

But not for ucp_pm_viewmessage_print.html and viewtopic_print.html which are inherited from prosilver, they call the print.css and bidi.css files in the current style with T_THEME_PATH.

Code: Select all

<!DOCTYPE html>
<html dir="{S_CONTENT_DIRECTION}" lang="{S_USER_LANG}">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="robots" content="noindex" />
{META}
<title>{SITENAME} &bull; {PAGE_TITLE}</title>

<link href="{T_THEME_PATH}/print.css" rel="stylesheet">
<link href="{T_THEME_PATH}/bidi.css" rel="stylesheet">
Print.css is present in the child style but bidi.css returns a 404 error in the console because it is missing.
User avatar
cabot
Jr. Style Validator
Posts: 990
Joined: Sat Jan 07, 2012 4:16 pm
Top

Re: Missing CSS file on pages used for printing

by Raul [ThE KuKa] » Sat Jul 30, 2022 12:23 pm

OK, I see now.

Thanks! 👌
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies | Styles Queue Stats :warning:

If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate.
:flag_es: phpBB Spain - Online Since 2003 :heart:


User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 11148
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Top

Re: Missing CSS file on pages used for printing

by Raul [ThE KuKa] » Sat Jul 30, 2022 12:38 pm

PR ready (solved in 3.3.9 version)

Thanks again cabot ;)
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies | Styles Queue Stats :warning:

If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate.
:flag_es: phpBB Spain - Online Since 2003 :heart:


User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 11148
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Top

Re: Missing CSS file on pages used for printing

by cabot » Sat Jul 30, 2022 2:23 pm

Cheers!
User avatar
cabot
Jr. Style Validator
Posts: 990
Joined: Sat Jan 07, 2012 4:16 pm
Top