pycode

Visible error text - pycode

Visible error text

by scr00chy » Mon Nov 12, 2018 7:32 pm

Hi, there are error strings visible in the viewtopic menu (but only in the simplifed mobile version):

BUTTON_REPORT_POST
BUTTON_WARN_USER

I thought it was a language pack issue but the issue happens also in standard British English while it's fine in prosilver.

Screenshot:

Image
scr00chy
Registered User
Posts: 3
Joined: Mon Nov 12, 2018 7:27 pm
Contact:

Re: Visible error text

by danceban » Sun Nov 18, 2018 2:41 am

Hello scr00chy,
thank you for reporting this problem. As a quick patch, you can do the following file edits to fix this issue. Please report back if problem is gone, as I have not tested it yet. Do not forget to make a backup before editing any code. This issue will be fixed in the 1.0.2 style update, along with the changes made in the 3.2.4 version of phpBB.

Edit viewtopic_body.html located in pycode/template/

Find the following code:

Code: Select all

					<!-- IF postrow.U_REPORT -->
						<li>
							<a href="{postrow.U_REPORT}" title="{L_REPORT_POST}" class="button button-icon-only">
								<i class="icon fa-exclamation fa-fw" aria-hidden="true"></i><span class="sr-only">{L_BUTTON_REPORT_POST}</span>
							</a>
						</li>
					<!-- ENDIF -->
Replace it with the following code:

Code: Select all

					<!-- IF postrow.U_REPORT -->
						<li>
							<a href="{postrow.U_REPORT}" title="{L_REPORT_POST}" class="button button-icon-only">
								<i class="icon fa-exclamation fa-fw" aria-hidden="true"></i><span class="sr-only">{L_BUTTON_REPORT}</span>
							</a>
						</li>
					<!-- ENDIF -->
Find the following code:

Code: Select all

					<!-- IF postrow.U_WARN -->
						<li>
							<a href="{postrow.U_WARN}" title="{L_WARN_USER}" class="button button-icon-only">
								<i class="icon fa-exclamation-triangle fa-fw" aria-hidden="true"></i><span class="sr-only">{L_BUTTON_WARN_USER}</span>
							</a>
						</li>
					<!-- ENDIF -->
Replace it with the following code:

Code: Select all

					<!-- IF postrow.U_WARN -->
						<li>
							<a href="{postrow.U_WARN}" title="{L_WARN_USER}" class="button button-icon-only">
								<i class="icon fa-exclamation-triangle fa-fw" aria-hidden="true"></i><span class="sr-only">{L_BUTTON_WARN}</span>
							</a>
						</li>
					<!-- ENDIF -->
Thank you,
Daniel
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact:

Re: Visible error text

by scr00chy » Sun Nov 18, 2018 11:03 am

Hi, these changes didn't fix the issue, unfortunately.
scr00chy
Registered User
Posts: 3
Joined: Mon Nov 12, 2018 7:27 pm
Contact:

Re: Visible error text

by danceban » Wed Nov 21, 2018 4:45 pm

Have you cleared the caches from the Admin Control Panel? Every time you add changes to any of the template files, you need to clear the caches from the ACP. Give it a try and report back with the results. Thank you
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact:

Re: Visible error text

by scr00chy » Wed Nov 21, 2018 4:54 pm

Ah okay, didn't know about having to clear the cache. It's fixed now. Thanks!
scr00chy
Registered User
Posts: 3
Joined: Mon Nov 12, 2018 7:27 pm
Contact:

Re: Visible error text

by danceban » Wed Nov 21, 2018 4:58 pm

Glad to hear that, enjoy using the pycode style. Btw, can you PM me a link to your forum? Thank you
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact: