pycode

New version adjustments - pycode

New version adjustments

by DV1 » Thu Nov 15, 2018 2:38 pm

Danceban

Well, I see you have the latest version of Pycode. :)

As you know, I did a lot of color changes and some simple tweaks here and there.

What's the best approach to update? Do I just upload the new version and then just replace the code changes or after uploading it then just replace the files.

In short, is (are) there any specific items to be aware of where more is required than replacing a file?

Thanks

Daniel
DV1
Registered User
Posts: 329
Joined: Sun Jul 11, 2010 8:49 pm
Location: Nevada
Contact:

Re: New version adjustments

by danceban » Sun Nov 18, 2018 2:54 am

Hello DV1,
yep, I am trying to keep up with latest updates, but I need to work on 1.0.2 version already, as few days ago phpBB 3.2.4 version was released.
About updating to the latest releases, it really depends on you. If you know how to work with the update code changes, you can take a look at all the changes made in the latest version of phpBB 3.2.4 here: https://gist.github.com/marc1706/751896 ... 5bc1ae1da8
Regarding pycode style update, always download the latest version available, install and add your code color changes to the style files manually. If you will upload the latest version and just replace the files that you edited from the previous version, you may loose different bug fixes and improvements added in the latest update.
Best regards,
Daniel
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact:

Re: New version adjustments

by DV1 » Fri Nov 23, 2018 4:02 pm

Please excuse the late reply, I thought I had it set for notification.

Re the phpBB version update, yes, I've done version updates many times so I think can do it easily by now unless the phpBB team have become diabolically gleeful and just want to watch everyone struggle. :D

I already updated to Pycode 1.0.1. But there's one thing I'm going to have to do and that is keep a sheet with the changes I've made for quick reference. Not a big deal since the changes are mostly color and some minor details but still I think the sheet would help when Pycode 1.0.3 and beyond rolls around.

One thing that I did want to ask about was the changing of the linklist and breadcrumbs when you're logged in. Rather than getting into elaborate describing I will just show an image of what I'm attempting that I altered in a graphics program:

Image

Basically, just switch the areas so that Quicklinks, Faq, ACP, and the rest are on the bottom. I'm aware that you're working on the new version along with everything else you do so when/if you get a chance let me know where on the template that's adjusted.

By the way, did you get the email I sent recently? :)

Thanks

Daniel
DV1
Registered User
Posts: 329
Joined: Sun Jul 11, 2010 8:49 pm
Location: Nevada
Contact:

Re: New version adjustments

by danceban » Mon Nov 26, 2018 1:56 am

Hello DV1,

in order to make the changes you want to achieve, you should make the following edits. Do not forget to backup first and proceed carefully!

1. Open /styles/prosilver/template/navbar_header.html and delete all the code from this template.
2. Add the following code to this template

Code: Select all

<div class="navbar" role="navigation">
		<div class="inner">
	
		<ul id="nav-breadcrumbs" class="nav-breadcrumbs linklist navlinks" role="menubar">
						<!-- DEFINE $MICRODATA = ' itemtype="http://schema.org/ListItem" itemprop="itemListElement" itemscope' -->
						<!-- EVENT overall_header_breadcrumbs_before -->
						<li class="breadcrumbs" itemscope itemtype="http://schema.org/BreadcrumbList">
							<!-- IF U_SITE_HOME -->
								<span class="crumb" {$MICRODATA}><a href="{U_SITE_HOME}" itemprop="url" data-navbar-reference="home"><i class="icon fa-home fa-fw" aria-hidden="true"></i><span itemprop="title">{L_SITE_HOME}</span></a></span>
							<!-- ENDIF -->
							<!-- EVENT overall_header_breadcrumb_prepend -->
								<span class="crumb" {$MICRODATA}><a href="{U_INDEX}" itemprop="url" accesskey="h" data-navbar-reference="index"><!-- IF not U_SITE_HOME --><i class="icon fa-home fa-fw"></i><!-- ENDIF --><span itemprop="title">{L_INDEX}</span></a></span>
				
							<!-- BEGIN navlinks -->
								<!-- EVENT overall_header_navlink_prepend -->
								<span class="crumb" {$MICRODATA}<!-- IF navlinks.MICRODATA --> {navlinks.MICRODATA}<!-- ENDIF -->><a href="{navlinks.U_VIEW_FORUM}" itemprop="url"><span itemprop="title">{navlinks.FORUM_NAME}</span></a></span>
								<!-- EVENT overall_header_navlink_append -->
							<!-- END navlinks -->
							<!-- EVENT overall_header_breadcrumb_append -->
						</li>
						<!-- EVENT overall_header_breadcrumbs_after -->
				
						<!-- IF S_DISPLAY_SEARCH and not S_IN_SEARCH -->
							<li class="rightside responsive-search">
								<a href="{U_SEARCH}" title="{L_SEARCH_ADV_EXPLAIN}" role="menuitem">
									<i class="icon fa-search fa-fw" aria-hidden="true"></i><span class="sr-only">{L_SEARCH}</span>
								</a>
							</li>
						<!-- ENDIF -->
		</ul>
	
		<ul id="nav-main" class="nav-main linklist" role="menubar">
	
			<li id="quick-links" class="quick-links dropdown-container responsive-menu<!-- IF not S_DISPLAY_QUICK_LINKS and not S_DISPLAY_SEARCH --> hidden<!-- ENDIF -->" data-skip-responsive="true">
				<a href="#" class="dropdown-trigger">
					<i class="icon fa-bars fa-fw" aria-hidden="true"></i><span>{L_QUICK_LINKS}</span>
				</a>
				<div class="dropdown">
					<div class="pointer"><div class="pointer-inner"></div></div>
					<ul class="dropdown-contents" role="menu">
						<!-- EVENT navbar_header_quick_links_before -->
	
						<!-- IF S_DISPLAY_SEARCH -->
							<li class="separator"></li>
							<!-- IF S_REGISTERED_USER -->
								<li>
									<a href="{U_SEARCH_SELF}" role="menuitem">
										<i class="icon fa-file-o fa-fw icon-gray" aria-hidden="true"></i><span>{L_SEARCH_SELF}</span>
									</a>
								</li>
							<!-- ENDIF -->
							<!-- IF S_USER_LOGGED_IN -->
								<li>
									<a href="{U_SEARCH_NEW}" role="menuitem">
										<i class="icon fa-file-o fa-fw icon-red" aria-hidden="true"></i><span>{L_SEARCH_NEW}</span>
									</a>
								</li>
							<!-- ENDIF -->
							<!-- IF S_LOAD_UNREADS -->
								<li>
									<a href="{U_SEARCH_UNREAD}" role="menuitem">
										<i class="icon fa-file-o fa-fw icon-red" aria-hidden="true"></i><span>{L_SEARCH_UNREAD}</span>
									</a>
								</li>
							<!-- ENDIF -->
								<li>
									<a href="{U_SEARCH_UNANSWERED}" role="menuitem">
										<i class="icon fa-file-o fa-fw icon-gray" aria-hidden="true"></i><span>{L_SEARCH_UNANSWERED}</span>
									</a>
								</li>
								<li>
									<a href="{U_SEARCH_ACTIVE_TOPICS}" role="menuitem">
										<i class="icon fa-file-o fa-fw icon-blue" aria-hidden="true"></i><span>{L_SEARCH_ACTIVE_TOPICS}</span>
									</a>
								</li>
								<li class="separator"></li>
								<li>
									<a href="{U_SEARCH}" role="menuitem">
										<i class="icon fa-search fa-fw" aria-hidden="true"></i><span>{L_SEARCH}</span>
									</a>
								</li>
						<!-- ENDIF -->
	
						<!-- IF not S_IS_BOT and (S_DISPLAY_MEMBERLIST or U_TEAM) -->
							<li class="separator"></li>
							<!-- IF S_DISPLAY_MEMBERLIST -->
								<li>
									<a href="{U_MEMBERLIST}" role="menuitem">
										<i class="icon fa-group fa-fw" aria-hidden="true"></i><span>{L_MEMBERLIST}</span>
									</a>
								</li>
							<!-- ENDIF -->
							<!-- IF U_TEAM -->
								<li>
									<a href="{U_TEAM}" role="menuitem">
										<i class="icon fa-shield fa-fw" aria-hidden="true"></i><span>{L_THE_TEAM}</span>
									</a>
								</li>
							<!-- ENDIF -->
						<!-- ENDIF -->
						<li class="separator"></li>
	
						<!-- EVENT navbar_header_quick_links_after -->
					</ul>
				</div>
			</li>
	
			<!-- EVENT overall_header_navigation_prepend -->
			<li <!-- IF not S_USER_LOGGED_IN -->data-skip-responsive="true"<!-- ELSE -->data-last-responsive="true"<!-- ENDIF -->>
				<a href="{U_FAQ}" rel="help" title="{L_FAQ_EXPLAIN}" role="menuitem">
					<i class="icon fa-question-circle fa-fw" aria-hidden="true"></i><span>{L_FAQ}</span>
				</a>
			</li>
			<!-- EVENT overall_header_navigation_append -->
			<!-- IF U_ACP -->
				<li data-last-responsive="true">
					<a href="{U_ACP}" title="{L_ACP}" role="menuitem">
						<i class="icon fa-cogs fa-fw" aria-hidden="true"></i><span>{L_ACP_SHORT}</span>
					</a>
				</li>
			<!-- ENDIF -->
			<!-- IF U_MCP -->
				<li data-last-responsive="true">
					<a href="{U_MCP}" title="{L_MCP}" role="menuitem">
						<i class="icon fa-gavel fa-fw" aria-hidden="true"></i><span>{L_MCP_SHORT}</span>
					</a>
				</li>
			<!-- ENDIF -->
	
		<!-- IF S_REGISTERED_USER -->
			<!-- EVENT navbar_header_user_profile_prepend -->
			<li id="username_logged_in" class="rightside <!-- IF CURRENT_USER_AVATAR --> no-bulletin<!-- ENDIF -->" data-skip-responsive="true">
				<!-- EVENT navbar_header_username_prepend -->
				<div class="header-profile dropdown-container">
					<a href="{U_PROFILE}" class="header-avatar dropdown-trigger"><!-- IF CURRENT_USER_AVATAR -->{CURRENT_USER_AVATAR} <!-- ENDIF --> {CURRENT_USERNAME_SIMPLE}</a>
					<div class="dropdown">
						<div class="pointer"><div class="pointer-inner"></div></div>
						<ul class="dropdown-contents" role="menu">
							<!-- IF U_RESTORE_PERMISSIONS -->
								<li>
									<a href="{U_RESTORE_PERMISSIONS}">
										<i class="icon fa-refresh fa-fw" aria-hidden="true"></i><span>{L_RESTORE_PERMISSIONS}</span>
									</a>
								</li>
							<!-- ENDIF -->
	
						<!-- EVENT navbar_header_profile_list_before -->
	
							<li>
								<a href="{U_PROFILE}" title="{L_PROFILE}" role="menuitem">
									<i class="icon fa-sliders fa-fw" aria-hidden="true"></i><span>{L_PROFILE}</span>
								</a>
							</li>
							<!-- IF U_USER_PROFILE -->
								<li>
									<a href="{U_USER_PROFILE}" title="{L_READ_PROFILE}" role="menuitem">
										<i class="icon fa-user fa-fw" aria-hidden="true"></i><span>{L_READ_PROFILE}</span>
									</a>
								</li>
							<!-- ENDIF -->
	
							<!-- EVENT navbar_header_profile_list_after -->
	
							<li class="separator"></li>
							<li>
								<a href="{U_LOGIN_LOGOUT}" title="{L_LOGIN_LOGOUT}" accesskey="x" role="menuitem">
									<i class="icon fa-power-off fa-fw" aria-hidden="true"></i><span>{L_LOGIN_LOGOUT}</span>
								</a>
							</li>
						</ul>
					</div>
				</div>
				<!-- EVENT navbar_header_username_append -->
			</li>
			<!-- IF S_DISPLAY_PM -->
				<li class="rightside" data-skip-responsive="true">
					<a href="{U_PRIVATEMSGS}" role="menuitem">
						<i class="icon fa-inbox fa-fw" aria-hidden="true"></i><span>{L_PRIVATE_MESSAGES} </span><strong class="badge<!-- IF not PRIVATE_MESSAGE_COUNT --> hidden<!-- ENDIF -->">{PRIVATE_MESSAGE_COUNT}</strong>
					</a>
				</li>
			<!-- ENDIF -->
			<!-- IF S_NOTIFICATIONS_DISPLAY -->
				<li class="dropdown-container dropdown-{S_CONTENT_FLOW_END} rightside" data-skip-responsive="true">
					<a href="{U_VIEW_ALL_NOTIFICATIONS}" id="notification_list_button" class="dropdown-trigger">
						<i class="icon fa-bell fa-fw" aria-hidden="true"></i><span>{L_NOTIFICATIONS} </span><strong class="badge<!-- IF not NOTIFICATIONS_COUNT --> hidden<!-- ENDIF -->">{NOTIFICATIONS_COUNT}</strong>
					</a>
					<!-- INCLUDE notification_dropdown.html -->
				</li>
			<!-- ENDIF -->
			<!-- EVENT navbar_header_user_profile_append -->
		<!-- ELSE -->
			<li class="rightside"  data-skip-responsive="true">
				<a href="{U_LOGIN_LOGOUT}" title="{L_LOGIN_LOGOUT}" accesskey="x" role="menuitem">
					<i class="icon fa-power-off fa-fw" aria-hidden="true"></i><span>{L_LOGIN_LOGOUT}</span>
				</a>
			</li>
			<!-- IF S_REGISTER_ENABLED and not (S_SHOW_COPPA or S_REGISTRATION) -->
				<li class="rightside" data-skip-responsive="true">
					<a href="{U_REGISTER}" role="menuitem">
						<i class="icon fa-pencil-square-o  fa-fw" aria-hidden="true"></i><span>{L_REGISTER}</span>
					</a>
				</li>
			<!-- ENDIF -->
			<!-- EVENT navbar_header_logged_out_content -->
		<!-- ENDIF -->
		</ul>
	
		</div>
	</div>
	
3. Open /styles/pycode/theme/colours.css
Find following code:

Code: Select all

ul.navlinks {
	border-top-color: rgba(183,183,189, 0.7);
}
Replace with following code:

Code: Select all

ul.navlinks {
	border-bottom-color: rgba(183,183,189, 0.7);
}
4. Open /styles/pycode/theme/common.css
Find following code:

Code: Select all

ul.navlinks {
	border-top: 1px solid transparent;
}
Replace it with following code:

Code: Select all

ul.navlinks {
	border-bottom: 1px solid transparent;
}
5. Clear the caches from the ACP and refresh page.

I did a quick test and this edits should do the job, please report back if it solves your problem.

I will prepare the style for the 3.2.4 version update in several days, so keep in mind that all the edits you make to the style, should be made again on the latest version of the style that will be released after being revisioned by phpBB team.

Thank you,
Daniel.
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact:

Re: New version adjustments

by DV1 » Tue Dec 11, 2018 2:50 pm

danceban

Your instructions worked excellently. :)

Please excuse the late response, with the holidays and all that it's been a bit hectic.

One of the things I had to do was also finishing the new piece at Sitesetis.com: A Friend Visits - October 2018. Have a look at it when you get a chance.

I haven't updated phpBB yet, will wait for your 3.2.4 pycode version and then will update both. :)

Cheers

Daniel V.
DV1
Registered User
Posts: 329
Joined: Sun Jul 11, 2010 8:49 pm
Location: Nevada
Contact:

Re: New version adjustments

by DV1 » Wed Jan 16, 2019 12:20 am

Danceban

I tried updating to the new version of phpBB 3.2.5 but encountered some issues. I was wondering if you have the navbar_header.html previous to the instructions you gave above; I guess it would be 3.2.3. When trying to update it signalled that as an error. I tried downloading the 3.2.5 template for that but it still wasn't working. I asks this because I'm not sure if there's a place to download previous versions and the the files needed. Anyway, I had the host just backup the forum to its previous state since it got all squirrelly.
DV1
Registered User
Posts: 329
Joined: Sun Jul 11, 2010 8:49 pm
Location: Nevada
Contact:

Re: New version adjustments

by danceban » Wed Jan 16, 2019 12:25 am

Hello,
been busy lately and didn't managed to update the style. In the meanwhile, phpBB released 3.2.5. I will update the style tomorrow to 3.2.5 and post a link to github page in the description, while the phpBB team will approve it.
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact:

Re: New version adjustments

by DV1 » Thu Jan 17, 2019 6:55 pm

Okay, got the updated version of phpBB on 2nd try. There was an issue with the FTP along with the changes to the navbar (prosilver template) you gave previously. I will wait till pycode update and see if the navbar switch works with it. :)
DV1
Registered User
Posts: 329
Joined: Sun Jul 11, 2010 8:49 pm
Location: Nevada
Contact:

Re: New version adjustments

by danceban » Thu Jan 24, 2019 9:07 am

It will work, nothing changed there :)
User avatar
danceban
Registered User
Posts: 25
Joined: Mon Mar 12, 2018 9:45 am
Name: Dan Ceban
Contact: