we_universal

we_universal for phpBB v3.2.3 - we_universal

Re: we_universal for phpBB v3.2.3

by sp3ctre » Sat Oct 13, 2018 11:32 am

Hi,

I just upgraded from a quite old version to the latest compatible with 3.2.3. Not sure I understand the issue with the dashboard image having to be brought to the foreground. This knobbles my setup as I had a banner in the header bar.

Please take a look on z4-forum.com to see how it looks at the moment. The dashboard image is set to when the screen gets smaller it cuts off the right side, but the image is designed in a way that it is ok.

Is it really a requirement to make the dashboard image foreground?
sp3ctre
Registered User
Posts: 285
Joined: Sun Jul 15, 2007 11:06 am
Contact:

Re: we_universal for phpBB v3.2.3

by v12mike » Sat Oct 13, 2018 6:51 pm

The main objective I have had for the changes I have made to we-universal for the 3.2.0, 3.2.1, 3.2.2 and 3.2.3 releases is to improve the usability on small screens, as an increasing majority of forum users are using phones. The original 700px break-point for responsive mode hiding the buttons on any screen smaller than that just did not work for me, and I tried several different schemes to make the responsive mode more adaptive to screen size.

Whatever I did, I hit the problem that the buttons in the foreground could not be scaled to fit an adaptive background image, and there are limited options for scaling a background image while keeping the proportions correct. Moving the image to the foreground means that the button just fit with no micro-management needed.
The current version of we_universal is (depending on language and extensions) usable with buttons on screens down to about 330px.

Moving the header image from the css to the html had 2 obvious side effects, both of which affect your header. the first is that the header image is scaled rather than cropped on small screens, the second is that the buttons are now situated in the border rather than the image.

There may be a way of using the new version with a transparent foreground image and an additional background image, but I am busy on other projects at present so cannot immediately put any effort into solving your problem, but I would suggest that the appearance of the new version of we-universal with your header image could be improved by changing the colour of the border pars and by adjusting your image, either cropping or scaling the right hand end to reduce the aspect ratio.
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: we_universal for phpBB v3.2.3

by sp3ctre » Mon Oct 15, 2018 8:57 am

v12mike wrote:The main objective I have had for the changes I have made to we-universal for the 3.2.0, 3.2.1, 3.2.2 and 3.2.3 releases is to improve the usability on small screens, as an increasing majority of forum users are using phones. The original 700px break-point for responsive mode hiding the buttons on any screen smaller than that just did not work for me, and I tried several different schemes to make the responsive mode more adaptive to screen size.
Hi Mike, thanks for the detailed reply.

I get the focus on mobile, although not sure I agree we need buttons for it. Most sites designed for mobile now use the hamburger menu, so I don't think it is unfamiliar for most people. It's your theme though, so your call.

Unfortunately unless I can hack it so the image is in the background I can't use the theme, as one of my primary ad banners sits in the header bar. I don't see it as a deal-breaker, but I will have to keep an eye on how much fettling I need to do when there are changes.

Cheers
sp3ctre
Registered User
Posts: 285
Joined: Sun Jul 15, 2007 11:06 am
Contact:

Re: we_universal for phpBB v3.2.3

by adt » Tue Oct 30, 2018 2:37 pm

v12mike wrote:The version of we_universal that was recently approved (v2.5.5) was submitted for approval before the release of phpBB v3.2.3, so was only approved for v3.2.2.

I have now made the updates for full compatibility with phpBB v3.2.3 and have created we_universal v2.5.6-b4.

The changes from v2.5.5 are minimal, and all in the layout/format of the page footer, so nothing major.

You can download v2.5.6-b4 at: https://github.com/v12mike/we_universal ... 5.6-b4.zip

I will be submitting this for approval after a trial period.
Hi v12mike,

How long do you think it would be the trial period? I have been waiting sooo long for phpBB 3.2.3 and its fix for the dreaded multi-attachment bug, and now I'm waiting for your official updated style to update my production forum.

Thanks for the great work!
adt
Registered User
Posts: 3
Joined: Tue Oct 30, 2018 2:32 pm
Contact:

Re: we_universal for phpBB v3.2.3

by v12mike » Sat Nov 10, 2018 8:52 am

I submitted this for approval by the phpBB team some time ago.

The approval process is outside of my control, I don't even know where it is in the queue. My advice would be to install either the unapproved version linked above, or the version for phpBB 3.2.2. I have used both of those on v3.2.3 forums with no new issues.
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: we_universal for phpBB v3.2.3

by adt » Fri Feb 01, 2019 10:18 am

Hi v12mike,

Now that we_universal v2.5.6 has been validated, I've tried to install it on my updated 3.2.3 phpBB.
However, there's an ugly gray rectangle all over the banner image, and the buttons/links have "popped out" of the image:
ss_forum_phpbb-3.2.3_style-2.5.6.png

I made these edits to the style, in order to go back to the old (desired) layout:

Code: Select all

diff -r -U 5 old/we_universal/template/overall_header.html new/we_universal/template/overall_header.html
--- old/we_universal/template/overall_header.html	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/template/overall_header.html	2019-02-01 10:12:01.000000000 +0100
@@ -176,11 +176,11 @@
 
 		<div class="inventea-header">
 			<header >
 		<!-- EVENT overall_header_headerbar_before -->	
 			<!-- EVENT overall_header_navbar_before -->
-			<nav>
+			<nav style="position: absolute; top: 0px; width: 100%">
 			<div class="inventea-posts-menu">
 				<ul class="inventea-menu" role="menubar">
 					<!-- EVENT navbar_header_quick_links_before -->
 					<!-- IF S_DISPLAY_SEARCH -->
 					<!-- IF S_REGISTERED_USER -->
@@ -214,11 +214,11 @@
 					</div>
 				</a>
 				<img src="{ROOT_PATH}styles/we_universal/theme/images/dashboard.jpg?assets_version={T_ASSETS_VERSION}" alt="forum header image">
 			</div>
 
-			<nav>
+			<nav style="position: absolute; bottom: 0px; width: 100%">
 				<div class="inventea-forum-menu">
 					<ul class="inventea-menu" role="menubar">
 						<!-- EVENT overall_header_navigation_prepend -->
 						<li id="button_faq">
 							<a href="{U_FAQ}" rel="help" title="{L_FAQ_EXPLAIN}" role="menuitem">{L_FAQ}</a>
diff -r -U 5 old/we_universal/theme/common.css new/we_universal/theme/common.css
--- old/we_universal/theme/common.css	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/theme/common.css	2019-02-01 10:14:14.000000000 +0100
@@ -92,11 +92,11 @@
 
 .inventea-header {
     position: relative;
     margin: auto;
 	width: 100%;
-	background: #b4b4b4;
+    background: transparent;
     overflow: hidden;
 }
 
 .inventea-dashboard img {
     width: 100%;

Now the result is this:
ss_forum_phpbb-3.2.3_style-2.5.6+dtmods.png

I like the theme to be like this, and I thought I'd share my edits.
Feel free to take these edits and include them in the theme if you want.
I can carry over my changes on new we_universal versions if you don't include them.
Thanks for the great work in keeping this awesome theme alive!
adt
Registered User
Posts: 3
Joined: Tue Oct 30, 2018 2:32 pm
Contact:

Re: we_universal for phpBB v3.2.3

by sp3ctre » Fri Feb 01, 2019 10:28 am

adt wrote:Hi v12mike,

Now that we_universal v2.5.6 has been validated, I've tried to install it on my updated 3.2.3 phpBB.
However, there's an ugly gray rectangle all over the banner image, and the buttons/links have "popped out" of the image:
ss_forum_phpbb-3.2.3_style-2.5.6.png

I made these edits to the style, in order to go back to the old (desired) layout:

Code: Select all

diff -r -U 5 old/we_universal/template/overall_header.html new/we_universal/template/overall_header.html
--- old/we_universal/template/overall_header.html	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/template/overall_header.html	2019-02-01 10:12:01.000000000 +0100
@@ -176,11 +176,11 @@
 
 		<div class="inventea-header">
 			<header >
 		<!-- EVENT overall_header_headerbar_before -->	
 			<!-- EVENT overall_header_navbar_before -->
-			<nav>
+			<nav style="position: absolute; top: 0px; width: 100%">
 			<div class="inventea-posts-menu">
 				<ul class="inventea-menu" role="menubar">
 					<!-- EVENT navbar_header_quick_links_before -->
 					<!-- IF S_DISPLAY_SEARCH -->
 					<!-- IF S_REGISTERED_USER -->
@@ -214,11 +214,11 @@
 					</div>
 				</a>
 				<img src="{ROOT_PATH}styles/we_universal/theme/images/dashboard.jpg?assets_version={T_ASSETS_VERSION}" alt="forum header image">
 			</div>
 
-			<nav>
+			<nav style="position: absolute; bottom: 0px; width: 100%">
 				<div class="inventea-forum-menu">
 					<ul class="inventea-menu" role="menubar">
 						<!-- EVENT overall_header_navigation_prepend -->
 						<li id="button_faq">
 							<a href="{U_FAQ}" rel="help" title="{L_FAQ_EXPLAIN}" role="menuitem">{L_FAQ}</a>
diff -r -U 5 old/we_universal/theme/common.css new/we_universal/theme/common.css
--- old/we_universal/theme/common.css	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/theme/common.css	2019-02-01 10:14:14.000000000 +0100
@@ -92,11 +92,11 @@
 
 .inventea-header {
     position: relative;
     margin: auto;
 	width: 100%;
-	background: #b4b4b4;
+    background: transparent;
     overflow: hidden;
 }
 
 .inventea-dashboard img {
     width: 100%;

Now the result is this:
ss_forum_phpbb-3.2.3_style-2.5.6+dtmods.png

I like the theme to be like this, and I though I'd share my edits.
Feel free to take these edits and include them in the theme if you want.
I can carry over my changes on new we_universal versions if you don't include them.
Thanks for the great work in keeping this awesome theme alive!
Nice work. I love this theme but the decision to change the header has completely baffled me. I have a google ad banner in my header so the changes mean I either have to give up that or not update the theme. Great job with your changes, I think they should either be merged in as an option for the theme or forked into a modified version. Happy with either but hopefully I can start upgrading we_universal again :)
sp3ctre
Registered User
Posts: 285
Joined: Sun Jul 15, 2007 11:06 am
Contact:

Re: we_universal for phpBB v3.2.3

by adt » Fri Feb 01, 2019 11:13 am

sp3ctre wrote: Nice work. I love this theme but the decision to change the header has completely baffled me. I have a google ad banner in my header so the changes mean I either have to give up that or not update the theme. Great job with your changes, I think they should either be merged in as an option for the theme or forked into a modified version. Happy with either but hopefully I can start upgrading we_universal again :)
Thank you sp3ctre!

For me, the new buttons outside of the image in v3.2.3 simply looked like a bug.
Using the theme as-is would have been unacceptable for me too.

Please note that I realized that the last change (background color) actually changed the appearance of the original style by INVENTEA: it actually had a dark gray rectangle that extended over the banner image on left and right.

If you like to be more "we_universal" 'ish, you should simply revert that to the original color from INVENTEA which is rgb(41, 44, 47).

I'm keeping the transparent color on my forum, as the extending rectangle always looked a bit "wrong" to me.

Thank you for your appreciation!
adt
Registered User
Posts: 3
Joined: Tue Oct 30, 2018 2:32 pm
Contact:

Re: we_universal for phpBB v3.2.3

by J-W43 » Sat Feb 02, 2019 1:14 pm

I like the header buttons above and below the header image as they don't appear on top of it now.
The rectangle colour surrounding the image can be changed by editing the code given previously and I like that too. In my case black to merge with the image background which is also black.
Please don't change these code changes.
J-W43
Registered User
Posts: 54
Joined: Sun Jan 17, 2016 3:38 pm
Contact:

Re: we_universal for phpBB v3.2.3

by v12mike » Tue Feb 05, 2019 6:26 am

Thanks for the comments.
I won't be changing anything in a hurry. I do intend to try integrating some of the suggested changes as options, but other work has pushed this out by a few months.
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: we_universal for phpBB v3.2.3

by kjh-mov » Mon Feb 25, 2019 8:01 pm

Hi, look to my version with the header buttons and the background.

https://www.kjh-move.de/
Wer nichts weiƟ, muss alles glauben.

Marie von Ebner-Eschenbach
User avatar
kjh-mov
Registered User
Posts: 32
Joined: Mon May 07, 2018 12:23 pm
Contact: