phpBB • Free and Open Source Forum Software

v12mike wrote:The main objective I have had for the changes I have made to we-universal for the 3.2.0, 3.2.1, 3.2.2 and 3.2.3 releases is to improve the usability on small screens, as an increasing majority of forum users are using phones. The original 700px break-point for responsive mode hiding the buttons on any screen smaller than that just did not work for me, and I tried several different schemes to make the responsive mode more adaptive to screen size.

v12mike wrote:The version of we_universal that was recently approved (v2.5.5) was submitted for approval before the release of phpBB v3.2.3, so was only approved for v3.2.2.

I have now made the updates for full compatibility with phpBB v3.2.3 and have created we_universal v2.5.6-b4.

The changes from v2.5.5 are minimal, and all in the layout/format of the page footer, so nothing major.

You can download v2.5.6-b4 at: https://github.com/v12mike/we_universal ... 5.6-b4.zip

I will be submitting this for approval after a trial period.

adt wrote:Hi v12mike,

Now that we_universal v2.5.6 has been validated, I've tried to install it on my updated 3.2.3 phpBB.
However, there's an ugly gray rectangle all over the banner image, and the buttons/links have "popped out" of the image:

ss_forum_phpbb-3.2.3_style-2.5.6.png

I made these edits to the style, in order to go back to the old (desired) layout:

Code: Select all

diff -r -U 5 old/we_universal/template/overall_header.html new/we_universal/template/overall_header.html
--- old/we_universal/template/overall_header.html	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/template/overall_header.html	2019-02-01 10:12:01.000000000 +0100
@@ -176,11 +176,11 @@
 
 		<div class="inventea-header">
 			<header >
 		<!-- EVENT overall_header_headerbar_before -->	
 			<!-- EVENT overall_header_navbar_before -->
-			<nav>
+			<nav style="position: absolute; top: 0px; width: 100%">
 			<div class="inventea-posts-menu">
 				<ul class="inventea-menu" role="menubar">
 					<!-- EVENT navbar_header_quick_links_before -->
 					<!-- IF S_DISPLAY_SEARCH -->
 					<!-- IF S_REGISTERED_USER -->
@@ -214,11 +214,11 @@
 					</div>
 				</a>
 				<img src="{ROOT_PATH}styles/we_universal/theme/images/dashboard.jpg?assets_version={T_ASSETS_VERSION}" alt="forum header image">
 			</div>
 
-			<nav>
+			<nav style="position: absolute; bottom: 0px; width: 100%">
 				<div class="inventea-forum-menu">
 					<ul class="inventea-menu" role="menubar">
 						<!-- EVENT overall_header_navigation_prepend -->
 						<li id="button_faq">
 							<a href="{U_FAQ}" rel="help" title="{L_FAQ_EXPLAIN}" role="menuitem">{L_FAQ}</a>
diff -r -U 5 old/we_universal/theme/common.css new/we_universal/theme/common.css
--- old/we_universal/theme/common.css	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/theme/common.css	2019-02-01 10:14:14.000000000 +0100
@@ -92,11 +92,11 @@
 
 .inventea-header {
     position: relative;
     margin: auto;
 	width: 100%;
-	background: #b4b4b4;
+    background: transparent;
     overflow: hidden;
 }
 
 .inventea-dashboard img {
     width: 100%;

Now the result is this:

ss_forum_phpbb-3.2.3_style-2.5.6+dtmods.png

I like the theme to be like this, and I though I'd share my edits.
Feel free to take these edits and include them in the theme if you want.
I can carry over my changes on new we_universal versions if you don't include them.
Thanks for the great work in keeping this awesome theme alive!

sp3ctre wrote: Nice work. I love this theme but the decision to change the header has completely baffled me. I have a google ad banner in my header so the changes mean I either have to give up that or not update the theme. Great job with your changes, I think they should either be merged in as an option for the theme or forked into a modified version. Happy with either but hopefully I can start upgrading we_universal again

adt wrote:Hi v12mike,

Now that we_universal v2.5.6 has been validated, I've tried to install it on my updated 3.2.3 phpBB.
However, there's an ugly gray rectangle all over the banner image, and the buttons/links have "popped out" of the image:

ss_forum_phpbb-3.2.3_style-2.5.6.png

I made these edits to the style, in order to go back to the old (desired) layout:

Code: Select all

diff -r -U 5 old/we_universal/template/overall_header.html new/we_universal/template/overall_header.html
--- old/we_universal/template/overall_header.html	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/template/overall_header.html	2019-02-01 10:12:01.000000000 +0100
@@ -176,11 +176,11 @@
 
 		<div class="inventea-header">
 			<header >
 		<!-- EVENT overall_header_headerbar_before -->	
 			<!-- EVENT overall_header_navbar_before -->
-			<nav>
+			<nav style="position: absolute; top: 0px; width: 100%">
 			<div class="inventea-posts-menu">
 				<ul class="inventea-menu" role="menubar">
 					<!-- EVENT navbar_header_quick_links_before -->
 					<!-- IF S_DISPLAY_SEARCH -->
 					<!-- IF S_REGISTERED_USER -->
@@ -214,11 +214,11 @@
 					</div>
 				</a>
 				<img src="{ROOT_PATH}styles/we_universal/theme/images/dashboard.jpg?assets_version={T_ASSETS_VERSION}" alt="forum header image">
 			</div>
 
-			<nav>
+			<nav style="position: absolute; bottom: 0px; width: 100%">
 				<div class="inventea-forum-menu">
 					<ul class="inventea-menu" role="menubar">
 						<!-- EVENT overall_header_navigation_prepend -->
 						<li id="button_faq">
 							<a href="{U_FAQ}" rel="help" title="{L_FAQ_EXPLAIN}" role="menuitem">{L_FAQ}</a>
diff -r -U 5 old/we_universal/theme/common.css new/we_universal/theme/common.css
--- old/we_universal/theme/common.css	2018-09-23 12:01:48.000000000 +0200
+++ new/we_universal/theme/common.css	2019-02-01 10:14:14.000000000 +0100
@@ -92,11 +92,11 @@
 
 .inventea-header {
     position: relative;
     margin: auto;
 	width: 100%;
-	background: #b4b4b4;
+    background: transparent;
     overflow: hidden;
 }
 
 .inventea-dashboard img {
     width: 100%;

Now the result is this:

ss_forum_phpbb-3.2.3_style-2.5.6+dtmods.png

I like the theme to be like this, and I thought I'd share my edits.
Feel free to take these edits and include them in the theme if you want.
I can carry over my changes on new we_universal versions if you don't include them.
Thanks for the great work in keeping this awesome theme alive!

Zinnn wrote:

adt wrote:

hey

any chance you could write this code again for the new version of this style?

the default setting is so ugly, I don't understand why it was changed in first place?

diff -r -U 5 old/we_universal/theme/custom.css new/we_universal/theme/custom.css
--- old/we_universal/theme/custom.css	2019-07-12 20:21:10.000000000 +0200
+++ new/we_universal/theme/custom.css	2019-09-13 15:11:53.000000000 +0200
@@ -29,15 +29,15 @@
 */
 
 /*
  * set header background colour (appears as a border around the image)
  */
-/*
+
 .inventea-header {
-	background: #424242;   
+	background: transparent;
 }
-*/
+
 /*
 .inventea-sitename, .inventea-sitename h1{
 	color: #005599;   
 }
 */
@@ -104,11 +104,11 @@
  * Thanks to Picaron
  * To move the header buttons to overlap the header image and hide the bars above and below the header image,
  * This matches (almost) the original we_universal layout for phpBB v3.1.
  * Uncomment the following blocks:
 */
-/*
+
 .inventea-posts-menu {
     position: absolute;
     right: 0;
     z-index: 3;
 }
@@ -116,6 +116,6 @@
 .inventea-forum-menu {
     position: absolute;
     bottom: 0;
     z-index: 3;
 }
-*/
+