we_universal

Test version of we_universal for phpBB v3.2.4 - we_universal

Test version of we_universal for phpBB v3.2.4

by v12mike » Mon Nov 19, 2018 6:24 pm

I am working on an update for phpBB 3.2.4. There should be a beta version available later this week.
Last edited by v12mike on Wed Nov 21, 2018 9:06 am
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: we_universal for phpBB v3.2.4

by strelok-by » Tue Nov 20, 2018 6:04 pm

There are defects
11.JPG
22.JPG
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: we_universal for phpBB v3.2.4

by v12mike » Tue Nov 20, 2018 10:10 pm

I have not investigated that yet, but could you check to see if the issue exists also in prosilver, and also if it exists with the language set to english? If it exists in english, could you please post a screen shot, as it is easier for me to understand.
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: we_universal for phpBB v3.2.4

by v12mike » Wed Nov 21, 2018 9:05 am

I have updated we_universal with the new template events for phpBB v3.2.4 creating version 2.5.7-a1 https://github.com/v12mike/we_universal ... master.zip
This version is only for testing (although it should be OK).
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Wed Nov 21, 2018 2:53 pm

v12mike wrote:I have not investigated that yet, but could you check to see if the issue exists also in prosilver, and also if it exists with the language set to english? If it exists in english, could you please post a screen shot, as it is easier for me to understand.
In prosilvere and a different style to 3.2.4 no such defect
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Wed Nov 21, 2018 3:00 pm

v12mike wrote:I have updated we_universal with the new template events for phpBB v3.2.4 creating version 2.5.7-a1
Снимок.JPG
There is a defect in version 2.5.7-a1
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by v12mike » Wed Nov 21, 2018 7:14 pm

Are you referring to the "Postprofile Right"? I don't see that on my test board, can you try disabling all extensions?
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Wed Nov 21, 2018 7:21 pm

I'm talking about the buttons are those that should be font instead of text, red font
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Wed Nov 21, 2018 7:35 pm

My knowledge of css is weak, but through the browser I found a piece of code that is responsible for the buttons

Code: Select all

<!-- IF not S_IS_BOT -->
	<!-- EVENT viewtopic_topic_tools_before -->
	<!-- IF U_WATCH_TOPIC -->
		<a href="{U_WATCH_TOPIC}" class="button" title="S_WATCH_TOPIC_TITLE">
				<span>{S_WATCH_TOPIC_TITLE}</span> <i class="icon fa-<!-- IF S_WATCHING_TOPIC -->check-<!-- ENDIF -->square-o fa-fw" aria-hidden="true"></i>
		</a>
	<!-- ENDIF -->
	<span class="responsive-hide">
		<!-- IF U_BOOKMARK_TOPIC -->
			<a href="{U_BOOKMARK_TOPIC}" class="button" title="L_BOOKMARK_TOPIC">
					<span>{S_BOOKMARK_TOPIC}</span> <i class="icon fa-bookmark-o fa-fw" aria-hidden="false"></i>
			</a>
		<!-- ENDIF -->
		<!-- IF U_BUMP_TOPIC -->
			<a href="{U_BUMP_TOPIC}" class="button" title="L_BUMP_TOPIC">
					<span>{L_BUMP_TOPIC}</span> <i class="icon fa-level-up fa-fw" aria-hidden="false"></i>
			</a>
		<!-- ENDIF -->
	</span>
	<!-- IF(U_BOOKMARK_TOPIC or U_BUMP_TOPIC or U_EMAIL_TOPIC or U_PRINT_TOPIC or S_DISPLAY_TOPIC_TOOLS) -->
		<div class="dropdown-container dropdown-button-control topic-tools responsive-show"<!-- IF!(U_BUMP_TOPIC or U_EMAIL_TOPIC or U_PRINT_TOPIC or S_DISPLAY_TOPIC_TOOLS) --> style="display: none;"<!-- ENDIF -->>
			<span title="{L_TOPIC_TOOLS}" class="button button-secondary dropdown-trigger dropdown-select">
				<i class="icon fa-wrench fa-fw" aria-hidden="false"></i>
				<span class="caret"><i class="icon fa-sort-down fa-fw" aria-hidden="false"></i></span>
			</span>
			<div class="dropdown">
				<div class="pointer"><div class="pointer-inner"></div></div>
				<ul class="dropdown-contents">
					<!-- EVENT viewtopic_topic_tools_before -->
					<!-- IF U_BOOKMARK_TOPIC -->
						<li>
							<a href="{U_BOOKMARK_TOPIC}" class="bookmark-link" title="{L_BOOKMARK_TOPIC}" data-ajax="alt_text" data-alt-text="{S_BOOKMARK_TOGGLE}" data-update-all=".bookmark-link">
								<i class="icon fa-bookmark-o fa-fw" aria-hidden="true"></i><span>{S_BOOKMARK_TOPIC}</span>
							</a>
						</li>
					<!-- ENDIF -->
					<!-- IF U_BUMP_TOPIC -->
					<li>
						<a href="{U_BUMP_TOPIC}" title="{L_BUMP_TOPIC}" data-ajax="true">
							<i class="icon fa-level-up fa-fw" aria-hidden="true"></i><span>{L_BUMP_TOPIC}</span>
						</a>
					</li>
					<!-- ENDIF -->
					<!-- IF U_EMAIL_TOPIC -->
					<li>
						<a href="{U_EMAIL_TOPIC}" title="{L_EMAIL_TOPIC}">
							<i class="icon fa-envelope-o fa-fw" aria-hidden="true"></i><span>{L_EMAIL_TOPIC}</span>
						</a>
					</li>
					<!-- ENDIF -->
					<!-- IF U_PRINT_TOPIC -->
					<li>
						<a href="{U_PRINT_TOPIC}" title="{L_PRINT_TOPIC}" accesskey="p">
							<i class="icon fa-print fa-fw" aria-hidden="true"></i><span>{L_PRINT_TOPIC}</span>
						</a>
					</li>
					<!-- ENDIF -->
					<!-- EVENT viewtopic_topic_tools_after -->
				</ul>
			</div>
		</div>
	<!-- ENDIF -->
	<!-- EVENT viewtopic_topic_tools_after -->
<!-- ENDIF -->
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by v12mike » Thu Nov 22, 2018 1:39 am

I now understand what you were looking at.

The change to make the buttons visible was intentional, I have found that most users of my forum cannot find the "Subscribe" link in the drop-down, and prefer to have the visible button. I have now added configurability for this in custom.css, the default is for the "Subscribe" button to be visible and the others hidden, but you can change this is you prefer.

I have also fixed the hover text on those buttons.

You can download v2.5.7-a2 from the same location.
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Thu Nov 22, 2018 9:20 am

And how to remove the button in the blue frame? it is in the hidden menu
Снимок.JPG
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by v12mike » Thu Nov 22, 2018 5:56 pm

strelok-by wrote:And how to remove the button in the blue frame? it is in the hidden menu
Снимок.JPG
In custom.css, change:

Code: Select all

/*#topic_watch_button, */#topic_bookmark_button, #topic_bump_button{
    display: none;
}
to:

Code: Select all

#topic_watch_button, #topic_bookmark_button, #topic_bump_button{
    display: none;
}
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Thu Nov 22, 2018 6:09 pm

v12mike wrote:
strelok-by wrote:And how to remove the button in the blue frame? it is in the hidden menu
In custom.css, change:

Code: Select all

/*#topic_watch_button, */#topic_bookmark_button, #topic_bump_button{
    display: none;
}
to:

Code: Select all

#topic_watch_button, #topic_bookmark_button, #topic_bump_button{
    display: none;
}
Thank you, I'm probably fed up, but how is this button called to add it to css too? :D
ss.JPG
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by v12mike » Thu Nov 22, 2018 6:15 pm

The button is defined at line 4 of template/viewtopic_topic_tools.html .

Code: Select all

	<!-- IF U_WATCH_TOPIC -->
		<a href="{U_WATCH_TOPIC}" class="button" title="{S_WATCH_TOPIC_TITLE}" id="topic_watch_button">
			<span>{S_WATCH_TOPIC_TITLE}</span> <i class="icon fa-<!-- IF S_WATCHING_TOPIC -->check-<!-- ENDIF -->square-o fa-fw" aria-hidden="true"></i>
		</a>
	<!-- ENDIF -->
v12mike
Registered User
Posts: 291
Joined: Thu Jul 09, 2015 5:03 pm
Contact:

Re: Test version of we_universal for phpBB v3.2.4

by strelok-by » Thu Nov 22, 2018 6:25 pm

v12mike wrote:The button is defined at line 4 of template/viewtopic_topic_tools.html .

Code: Select all

	<!-- IF U_WATCH_TOPIC -->
		<a href="{U_WATCH_TOPIC}" class="button" title="{S_WATCH_TOPIC_TITLE}" id="topic_watch_button">
			<span>{S_WATCH_TOPIC_TITLE}</span> <i class="icon fa-<!-- IF S_WATCHING_TOPIC -->check-<!-- ENDIF -->square-o fa-fw" aria-hidden="true"></i>
		</a>
	<!-- ENDIF -->
thanks. Am I going to be a release so soon? It seems that I did not see the mistakes of others and did not find it, the console in the browser is also silent
User avatar
strelok-by
Registered User
Posts: 102
Joined: Fri Nov 21, 2014 10:22 am
Location: Mozyr / Belarus
Name: Stanislav
Contact: